feat(sca): map stripe error codes to user-facing copy in tui

.github/workflows/ci.yml

@@ -8,9 +8,9 @@ jobs:
   check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v4
 
-      - uses: actions/setup-go@v6
+      - uses: actions/setup-go@v5
         with:
           go-version-file: go.mod
 
@@ -30,36 +30,9 @@ jobs:
           fi
 
       - name: Lint
-        if: ${{ !env.ACT }}
         uses: golangci/golangci-lint-action@v7
         with:
           version: v2.4.0
 
-      - name: Install tparse
-        run: go install github.com/mfridman/tparse@v0.18.0
-
       - name: Test (race detector)
-        run: |
-          set +e
-          go tool gotestsum \
-            --format pkgname \
-            --format-icons hivis \
-            --hide-summary=skipped,output,errors,failed \
-            --jsonfile test-output.json \
-            --junitfile test-report.xml \
-            --packages="./..." \
-            -- -count=1 -race -covermode=atomic -coverprofile=coverage.out
-          rc=$?
-          echo
-          tparse -all -notests -slow 10 -file=test-output.json || true
-          exit $rc
-
-      - name: Upload test report 
-        if: always()
-        uses: actions/upload-artifact@v4
-        with:
-          name: test-report
-          path: |
-            test-output.json
-            test-report.xml
-            coverage.out
+        run: go test -race ./...

.github/workflows/deploy.yml

@@ -8,10 +8,10 @@ jobs:
   deploy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
-      - uses: actions/setup-go@v6
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
         with:
-          go-version-file: go.mod
+          go-version: '1.23'
       - name: Run tests
         run: go test ./...
       - name: Deploy to server
@@ -22,15 +22,6 @@ jobs:
           key: ${{ secrets.SERVER_SSH_KEY }}
           port: ${{ secrets.SERVER_PORT }}
           script: |
-            set -euo pipefail
             cd ~/terminalShop
-            git fetch origin master
-            git reset --hard origin/master
-            deployed=$(git rev-parse HEAD)
-            expected="${{ github.sha }}"
-            if [ "$deployed" != "$expected" ]; then
-              echo "::error::deploy HEAD mismatch: box=$deployed expected=$expected"
-              exit 1
-            fi
+            git pull
             docker compose -f docker-compose.prod.yml up -d --build
-            echo "deploy verified: HEAD=$deployed"

.gitignore

@@ -7,7 +7,6 @@
 
 docs/sca-psd2-compliance.md
 accept-a-payment/
-codemap/
 
 
 FULFILLMENT.md
@@ -34,8 +33,6 @@ api/api-server
 *.out
 coverage.txt
 coverage.html
-test-output.json
-test-report.xml
 
 # Dependency directories
 vendor/
@@ -117,6 +114,3 @@ ROADMAP.md
 
 *.bak
 terminalshop.prod.*
-
-# Backup verification config (real values; example file is committed)
-scripts/backups/config.env

Makefile

@@ -1,55 +0,0 @@
-.PHONY: test test-pretty test-watch test-ci test-summary cover
-
-PKGS ?= ./...
-JSON_OUT ?= test-output.json
-JUNIT ?= test-report.xml
-COVER ?= coverage.out
-
-# Plain go test. Fastest, no extra deps loaded
-test:
-	go test $(PKGS)
-
-# Live pretty output. Groups by test name, reruns flakes once.
-# Hides gotestsum's plain-text summary; tparse renders failures instead.
-test-pretty:
-	@set +e; \
-	go tool gotestsum \
-		--format testname \
-		--format-icons hivis \
-		--hide-summary=skipped,output,errors,failed \
-		--rerun-fails=1 \
-		--jsonfile $(JSON_OUT) \
-		--packages="$(PKGS)" \
-		-- -count=1; \
-	rc=$$?; \
-	echo; \
-	tparse -all -notests -file=$(JSON_OUT) || true; \
-	exit $$rc
-
-# TDD loop: re-runs affected packages on file save.
-test-watch:
-	go tool gotestsum --watch --format testname --packages="$(PKGS)"
-
-# CI / pre-push: race + coverage + JSON + JUnit + tparse summary table
-test-ci:
-	@set +e; \
-	go tool gotestsum \
-		--format pkgname \
-		--format-icons hivis \
-		--hide-summary=skipped,output,errors,failed \
-		--jsonfile $(JSON_OUT) \
-		--junitfile $(JUNIT) \
-		--packages="$(PKGS)" \
-		-- -count=1 -race -covermode=atomic -coverprofile=$(COVER); \
-	rc=$$?; \
-	echo; \
-	tparse -all -notests -slow 10 -file=$(JSON_OUT) || true; \
-	exit $$rc
-
-# Replay last summary without re-running tests
-test-summary:
-	tparse -all -notests -file=$(JSON_OUT)
-
-# Open HTML coverage report from last `test-ci` run
-cover:
-	go tool cover -html=$(COVER)

README.md

@@ -71,4 +71,3 @@ uses SQLite by default so there's nothing to spin up.
 ## inspiration
 
 [terminal.shop](https://terminal.shop) for the original idea and most of the patterns in `pkg/tui/`. their source is open and worth reading.
-# something

api/doc.go

@@ -1,3 +0,0 @@
-// Command api is the HTTP backend: it boots the router, bolts on all the
-// middleware, and answers the requests the TUI throws at it.
-package main

api/handlers/account.go

@@ -1,111 +0,0 @@
-package handlers
-
-import (
-	"encoding/json"
-	"net/http"
-
-	"terminalShop/api/middleware"
-	"terminalShop/pkg/audit"
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-	"terminalShop/pkg/utils"
-)
-
-// AccountHandler serves JWT-authed, customer-facing account-settings endpoints.
-// Unlike AdminUserHandler (X-Admin-Key gated), every route here edits the
-// logged-in user's own row, identified by the JWT user id in context.
-type AccountHandler struct {
-	// maxOrderCents is the global spend cap, needed to bound a self-limit: a
-	// customer may only TIGHTEN their effective ceiling, never raise it.
-	maxOrderCents int
-}
-
-// NewAccountHandler constructs an AccountHandler. maxOrderCents is the global
-// MAX_ORDER_CENTS, wired from cfg in routes.SetupRoutes (same value the cart
-// handler receives).
-func NewAccountHandler(maxOrderCents int) *AccountHandler {
-	return &AccountHandler{maxOrderCents: maxOrderCents}
-}
-
-// SetSpendLimit sets or clears the logged-in user's self-service spend limit
-// (User.SelfLimitCents). Body: {"self_limit_cents": <int|null>}.
-//   - null -> clears the self-limit; the user reverts to the admin/global cap
-//   - 0    -> a real "block everything" ceiling (NOT an off-switch; that is the
-//     whole point of a customer-set limit — it can only tighten)
-//   - >0   -> custom ceiling, must be <= the effective admin/global cap
-//
-// Security: this endpoint is JWT-authed and edits the caller's OWN row, so a
-// self-limit is LOWER-ONLY. A value above the user's effective admin/global cap
-// is rejected here (HTTP 400) so a compromised session cannot lift its own
-// ceiling; the min() fold in cart.go:ConvertCart is the authoritative second
-// guard. Negative values are rejected at the write boundary (the ConvertCart
-// read path also ignores a stray negative from a direct DB write).
-//
-// Mirrors AdminUserHandler.SetUserOrderCap but reads the user id from the JWT
-// context instead of a {id} URL param, uses a distinct body key + audit event,
-// and gates the value against the cap.
-func (h *AccountHandler) SetSpendLimit(w http.ResponseWriter, r *http.Request) {
-	db := database.GetDB().WithContext(r.Context())
-	userID := middleware.UserIDFromContext(r.Context())
-
-	var raw map[string]json.RawMessage
-	if err := json.NewDecoder(r.Body).Decode(&raw); err != nil {
-		utils.RespondError(w, http.StatusBadRequest, "INVALID_BODY", "invalid request body", nil)
-		return
-	}
-	rawLimit, ok := raw["self_limit_cents"]
-	if !ok {
-		utils.RespondError(w, http.StatusBadRequest, "MISSING_FIELD", "self_limit_cents is required (use null to clear the limit)", nil)
-		return
-	}
-
-	var limitCents *int
-	if string(rawLimit) != "null" {
-		var n int
-		if err := json.Unmarshal(rawLimit, &n); err != nil {
-			utils.RespondError(w, http.StatusBadRequest, "INVALID_BODY", "self_limit_cents must be an integer or null", nil)
-			return
-		}
-		if n < 0 {
-			utils.RespondError(w, http.StatusBadRequest, "INVALID_LIMIT", "self_limit_cents must be >= 0 (use null to clear the limit)", nil)
-			return
-		}
-		limitCents = &n
-	}
-
-	var user models.User
-	if err := db.First(&user, userID).Error; err != nil {
-		utils.RespondError(w, http.StatusNotFound, "USER_NOT_FOUND", "user not found", nil)
-		return
-	}
-
-	// A self-limit may only tighten the effective cap, never raise it. Compute
-	// the user's effective admin/global ceiling exactly as cart.go:ConvertCart
-	// does (per-user override wins when present and non-negative; an active cap
-	// is > 0). Reject any self-limit above an ACTIVE admin ceiling. When no admin
-	// ceiling is active (global disabled and no override) there is nothing to
-	// raise, so any non-negative self-limit is allowed — it can only ADD a cap.
-	if limitCents != nil {
-		adminCap := h.maxOrderCents
-		if user.MaxOrderCents != nil && *user.MaxOrderCents >= 0 {
-			adminCap = *user.MaxOrderCents
-		}
-		if adminCap > 0 && *limitCents > adminCap {
-			utils.RespondError(w, http.StatusBadRequest, "SELF_LIMIT_ABOVE_CAP", "self_limit_cents may not exceed your account spend cap", map[string]any{"self_limit_cents": *limitCents, "cap_cents": adminCap})
-			return
-		}
-	}
-
-	// Map form so a nil pointer persists SQL NULL; a struct Updates would skip it.
-	if err := db.Model(&user).Updates(map[string]any{"self_limit_cents": limitCents}).Error; err != nil {
-		utils.RespondError(w, http.StatusInternalServerError, "DATABASE_ERROR", "failed to update spend limit", nil)
-		return
-	}
-
-	audit.UserSelfLimitSet(user.ID, limitCents)
-
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
-		"user_id":          user.ID,
-		"self_limit_cents": limitCents,
-	})
-}

api/handlers/account_test.go

@@ -1,118 +0,0 @@
-package handlers
-
-import (
-	"net/http"
-	"net/http/httptest"
-	"strings"
-	"testing"
-
-	"github.com/go-chi/chi/v5"
-
-	"terminalShop/api/middleware"
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-)
-
-func TestSetSpendLimit(t *testing.T) {
-	const globalCap = 5000
-	cases := []struct {
-		name       string
-		seedSelf   *int // starting SelfLimitCents on the row
-		seedAdmin  *int // per-user MaxOrderCents override (effective admin cap)
-		body       string
-		wantStatus int
-		wantCode   string // error code; "" means success
-		wantLimit  *int   // expected SelfLimitCents after a successful update
-	}{
-		{"set positive under cap", nil, nil, `{"self_limit_cents":2000}`, http.StatusOK, "", intPtr(2000)},
-		{"set zero blocks all", nil, nil, `{"self_limit_cents":0}`, http.StatusOK, "", intPtr(0)},
-		{"set equal to cap", nil, nil, `{"self_limit_cents":5000}`, http.StatusOK, "", intPtr(5000)},
-		{"clear with null", intPtr(2000), nil, `{"self_limit_cents":null}`, http.StatusOK, "", nil},
-		{"overwrite existing", intPtr(2000), nil, `{"self_limit_cents":1000}`, http.StatusOK, "", intPtr(1000)},
-		{"above global cap rejected", nil, nil, `{"self_limit_cents":6000}`, http.StatusBadRequest, "SELF_LIMIT_ABOVE_CAP", nil},
-		{"under per-user override accepted", nil, intPtr(10000), `{"self_limit_cents":8000}`, http.StatusOK, "", intPtr(8000)},
-		{"above per-user override rejected", nil, intPtr(10000), `{"self_limit_cents":12000}`, http.StatusBadRequest, "SELF_LIMIT_ABOVE_CAP", nil},
-		{"negative rejected", nil, nil, `{"self_limit_cents":-1}`, http.StatusBadRequest, "INVALID_LIMIT", nil},
-		{"missing field rejected", nil, nil, `{}`, http.StatusBadRequest, "MISSING_FIELD", nil},
-		{"non-integer rejected", nil, nil, `{"self_limit_cents":"lots"}`, http.StatusBadRequest, "INVALID_BODY", nil},
-		{"malformed json rejected", nil, nil, `{`, http.StatusBadRequest, "INVALID_BODY", nil},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			user := setupOrderTestDB(t)
-			db := database.GetDB()
-			if tc.seedSelf != nil {
-				if err := db.Model(&user).Update("self_limit_cents", *tc.seedSelf).Error; err != nil {
-					t.Fatalf("seed self limit: %v", err)
-				}
-			}
-			if tc.seedAdmin != nil {
-				if err := db.Model(&user).Update("max_order_cents", *tc.seedAdmin).Error; err != nil {
-					t.Fatalf("seed admin cap: %v", err)
-				}
-			}
-
-			handler := NewAccountHandler(globalCap)
-			req := authRequest("PUT", "/api/v1/account/spend-limit", []byte(tc.body), user.ID)
-			w := httptest.NewRecorder()
-			handler.SetSpendLimit(w, req)
-
-			if w.Code != tc.wantStatus {
-				t.Fatalf("status: want %d got %d (%s)", tc.wantStatus, w.Code, w.Body.String())
-			}
-			assertErrCode(t, w, tc.wantCode)
-
-			var got models.User
-			if err := db.First(&got, user.ID).Error; err != nil {
-				t.Fatalf("reload user: %v", err)
-			}
-			if tc.wantStatus == http.StatusOK {
-				if !eqIntPtr(got.SelfLimitCents, tc.wantLimit) {
-					t.Errorf("db SelfLimitCents: want %s got %s", fmtIntPtr(tc.wantLimit), fmtIntPtr(got.SelfLimitCents))
-				}
-			} else if !eqIntPtr(got.SelfLimitCents, tc.seedSelf) {
-				// A rejected request must not mutate the column.
-				t.Errorf("rejected request changed db limit: want %s got %s", fmtIntPtr(tc.seedSelf), fmtIntPtr(got.SelfLimitCents))
-			}
-		})
-	}
-}
-
-// TestSetSpendLimit_CapDisabledAllowsAnyLimit: with no active admin ceiling
-// (global 0, no override) any non-negative self-limit is accepted — a self-limit
-// can only ADD a ceiling, so there is nothing to raise.
-func TestSetSpendLimit_CapDisabledAllowsAnyLimit(t *testing.T) {
-	user := setupOrderTestDB(t)
-	handler := NewAccountHandler(0) // global cap disabled
-	req := authRequest("PUT", "/api/v1/account/spend-limit", []byte(`{"self_limit_cents":999999}`), user.ID)
-	w := httptest.NewRecorder()
-	handler.SetSpendLimit(w, req)
-	if w.Code != http.StatusOK {
-		t.Fatalf("status: want 200 got %d (%s)", w.Code, w.Body.String())
-	}
-	var got models.User
-	if err := database.GetDB().First(&got, user.ID).Error; err != nil {
-		t.Fatalf("reload user: %v", err)
-	}
-	if !eqIntPtr(got.SelfLimitCents, intPtr(999999)) {
-		t.Errorf("db SelfLimitCents: want 999999 got %s", fmtIntPtr(got.SelfLimitCents))
-	}
-}
-
-// TestSetSpendLimit_RequireAuthGate exercises the JWT gate through a real
-// router: no user context => 401, the handler is never reached.
-func TestSetSpendLimit_RequireAuthGate(t *testing.T) {
-	setupOrderTestDB(t)
-	router := chi.NewRouter()
-	router.With(middleware.RequireAuth).
-		Put("/api/v1/account/spend-limit", NewAccountHandler(5000).SetSpendLimit)
-
-	req := httptest.NewRequest("PUT", "/api/v1/account/spend-limit", strings.NewReader(`{"self_limit_cents":1000}`))
-	w := httptest.NewRecorder()
-	router.ServeHTTP(w, req)
-	if w.Code != http.StatusUnauthorized {
-		t.Fatalf("status: want 401 got %d", w.Code)
-	}
-	assertErrCode(t, w, "UNAUTHORIZED")
-}

api/handlers/addresses.go

@@ -42,7 +42,7 @@ func (h *AddressHandler) GetAddresses(w http.ResponseWriter, r *http.Request) {
 	var addresses []models.Address
 	db.Where("user_id = ?", userID).Order("is_default DESC, created_at DESC").Find(&addresses)
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"addresses": addresses,
 	})
 }
@@ -154,7 +154,7 @@ func (h *AddressHandler) CreateAddress(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusCreated, map[string]any{
+	utils.RespondSuccess(w, http.StatusCreated, map[string]interface{}{
 		"address": address,
 	})
 }
@@ -183,7 +183,7 @@ func (h *AddressHandler) DeleteAddress(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"message": "address successfully deleted",
 	})
 }
@@ -218,7 +218,7 @@ func (h *AddressHandler) SetDefaultAddress(w http.ResponseWriter, r *http.Reques
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"address": address,
 	})
 }

api/handlers/addresses_test.go

@@ -58,7 +58,7 @@ func TestGetAddressesEmpty(t *testing.T) {
 	var resp struct {
 		Success bool `json:"success"`
 		Data    struct {
-			Addresses []any `json:"addresses"`
+			Addresses []interface{} `json:"addresses"`
 		} `json:"data"`
 	}
 	if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {

api/handlers/admin_users.go

@@ -1,97 +0,0 @@
-package handlers
-
-import (
-	"encoding/json"
-	"net/http"
-	"strconv"
-
-	"github.com/go-chi/chi/v5"
-
-	"terminalShop/pkg/audit"
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-	"terminalShop/pkg/utils"
-)
-
-// AdminUserHandler serves admin-gated user-administration endpoints. Routes that
-// use it are mounted behind middleware.RequireAdmin (X-Admin-Key), not the JWT
-// auth used by customer-facing endpoints.
-type AdminUserHandler struct{}
-
-// NewAdminUserHandler constructs an AdminUserHandler.
-func NewAdminUserHandler() *AdminUserHandler {
-	return &AdminUserHandler{}
-}
-
-// SetUserOrderCap sets or clears a user's per-user spend-cap override
-// (User.MaxOrderCents). Body: {"max_order_cents": <int|null>}.
-//   - null  -> clears the override; the user reverts to the global MAX_ORDER_CENTS
-//   - 0     -> per-user off-switch (disables the cap for this user)
-//   - >0    -> custom ceiling
-//
-// Negative values are rejected here at the write boundary (HTTP 400) to keep bad
-// data out of the column. The read path in cart.go:ConvertCart independently
-// defends against a negative that arrives via a direct DB write (falls back to
-// the global cap), so the two layers cover each other.
-//
-// Adapted from the admin OrderHandler.UpdateTracking pattern in
-// api/handlers/orders.go (URL id param -> body decode -> row lookup -> update ->
-// audit -> respond).
-func (h *AdminUserHandler) SetUserOrderCap(w http.ResponseWriter, r *http.Request) {
-	db := database.GetDB().WithContext(r.Context())
-
-	idStr := chi.URLParam(r, "id")
-	id, err := strconv.ParseUint(idStr, 10, 32)
-	if err != nil {
-		utils.RespondError(w, http.StatusBadRequest, "INVALID_ID", "invalid user id", nil)
-		return
-	}
-
-	// Decode raw so an explicit null (clear) is distinguishable from an absent key.
-	var raw map[string]json.RawMessage
-	if err := json.NewDecoder(r.Body).Decode(&raw); err != nil {
-		utils.RespondError(w, http.StatusBadRequest, "INVALID_BODY", "invalid request body", nil)
-		return
-	}
-	rawCap, ok := raw["max_order_cents"]
-	if !ok {
-		utils.RespondError(w, http.StatusBadRequest, "MISSING_FIELD",
-			"max_order_cents is required (use null to clear the override)", nil)
-		return
-	}
-
-	var capCents *int
-	if string(rawCap) != "null" {
-		var n int
-		if err := json.Unmarshal(rawCap, &n); err != nil {
-			utils.RespondError(w, http.StatusBadRequest, "INVALID_BODY",
-				"max_order_cents must be an integer or null", nil)
-			return
-		}
-		if n < 0 {
-			utils.RespondError(w, http.StatusBadRequest, "INVALID_CAP",
-				"max_order_cents must be >= 0 (use null to clear the override)", nil)
-			return
-		}
-		capCents = &n
-	}
-
-	var user models.User
-	if err := db.First(&user, id).Error; err != nil {
-		utils.RespondError(w, http.StatusNotFound, "USER_NOT_FOUND", "user not found", nil)
-		return
-	}
-
-	// Map form so a nil pointer persists SQL NULL; a struct Updates would skip it.
-	if err := db.Model(&user).Updates(map[string]any{"max_order_cents": capCents}).Error; err != nil {
-		utils.RespondError(w, http.StatusInternalServerError, "DATABASE_ERROR", "failed to update order cap", nil)
-		return
-	}
-
-	audit.UserOrderCapSet("admin", user.ID, capCents)
-
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
-		"user_id":         user.ID,
-		"max_order_cents": capCents,
-	})
-}

api/handlers/admin_users_test.go

@@ -1,194 +0,0 @@
-package handlers
-
-import (
-	"encoding/json"
-	"net/http"
-	"net/http/httptest"
-	"strconv"
-	"strings"
-	"testing"
-
-	"github.com/go-chi/chi/v5"
-
-	"terminalShop/api/middleware"
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-)
-
-// adminCapRequest builds a PATCH request carrying the {id} chi URL param, as the
-// admin order-cap route would. No JWT — the route is gated by RequireAdmin.
-func adminCapRequest(idParam, body string) *http.Request {
-	req := httptest.NewRequest("PATCH", "/api/v1/users/"+idParam+"/order-cap", strings.NewReader(body))
-	rc := chi.NewRouteContext()
-	rc.URLParams.Add("id", idParam)
-	return req.WithContext(contextWithRoute(req.Context(), rc))
-}
-
-func eqIntPtr(a, b *int) bool {
-	if a == nil || b == nil {
-		return a == b
-	}
-	return *a == *b
-}
-
-func fmtIntPtr(p *int) string {
-	if p == nil {
-		return "<nil>"
-	}
-	return strconv.Itoa(*p)
-}
-
-func TestSetUserOrderCap(t *testing.T) {
-	cases := []struct {
-		name       string
-		seed       *int // starting MaxOrderCents on the user row
-		body       string
-		wantStatus int
-		wantCode   string // error code; "" means success
-		wantCap    *int   // expected DB value after a successful update
-	}{
-		{"set positive", nil, `{"max_order_cents":7500}`, http.StatusOK, "", intPtr(7500)},
-		{"set zero off-switch", nil, `{"max_order_cents":0}`, http.StatusOK, "", intPtr(0)},
-		{"clear with null reverts to global", intPtr(500), `{"max_order_cents":null}`, http.StatusOK, "", nil},
-		{"overwrite existing value", intPtr(500), `{"max_order_cents":12000}`, http.StatusOK, "", intPtr(12000)},
-		{"negative rejected", nil, `{"max_order_cents":-1}`, http.StatusBadRequest, "INVALID_CAP", nil},
-		{"missing field rejected", nil, `{}`, http.StatusBadRequest, "MISSING_FIELD", nil},
-		{"non-integer rejected", nil, `{"max_order_cents":"lots"}`, http.StatusBadRequest, "INVALID_BODY", nil},
-		{"malformed json rejected", nil, `{`, http.StatusBadRequest, "INVALID_BODY", nil},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			user := setupOrderTestDB(t)
-			db := database.GetDB()
-			if tc.seed != nil {
-				if err := db.Model(&user).Update("max_order_cents", *tc.seed).Error; err != nil {
-					t.Fatalf("seed cap: %v", err)
-				}
-			}
-
-			handler := NewAdminUserHandler()
-			req := adminCapRequest(strconv.FormatUint(uint64(user.ID), 10), tc.body)
-			w := httptest.NewRecorder()
-			handler.SetUserOrderCap(w, req)
-
-			if w.Code != tc.wantStatus {
-				t.Fatalf("status: want %d got %d (%s)", tc.wantStatus, w.Code, w.Body.String())
-			}
-
-			var resp struct {
-				Error struct {
-					Code string `json:"code"`
-				} `json:"error"`
-			}
-			_ = json.Unmarshal(w.Body.Bytes(), &resp)
-			if resp.Error.Code != tc.wantCode {
-				t.Errorf("error code: want %q got %q", tc.wantCode, resp.Error.Code)
-			}
-
-			var got models.User
-			if err := db.First(&got, user.ID).Error; err != nil {
-				t.Fatalf("reload user: %v", err)
-			}
-			if tc.wantStatus == http.StatusOK {
-				if !eqIntPtr(got.MaxOrderCents, tc.wantCap) {
-					t.Errorf("db MaxOrderCents: want %s got %s", fmtIntPtr(tc.wantCap), fmtIntPtr(got.MaxOrderCents))
-				}
-			} else if !eqIntPtr(got.MaxOrderCents, tc.seed) {
-				// A rejected request must not mutate the column.
-				t.Errorf("rejected request changed db cap: want %s got %s", fmtIntPtr(tc.seed), fmtIntPtr(got.MaxOrderCents))
-			}
-		})
-	}
-}
-
-func TestSetUserOrderCap_InvalidID(t *testing.T) {
-	setupOrderTestDB(t)
-	w := httptest.NewRecorder()
-	NewAdminUserHandler().SetUserOrderCap(w, adminCapRequest("abc", `{"max_order_cents":100}`))
-	if w.Code != http.StatusBadRequest {
-		t.Fatalf("status: want 400 got %d", w.Code)
-	}
-	assertErrCode(t, w, "INVALID_ID")
-}
-
-func TestSetUserOrderCap_UserNotFound(t *testing.T) {
-	setupOrderTestDB(t)
-	w := httptest.NewRecorder()
-	NewAdminUserHandler().SetUserOrderCap(w, adminCapRequest("99999", `{"max_order_cents":100}`))
-	if w.Code != http.StatusNotFound {
-		t.Fatalf("status: want 404 got %d", w.Code)
-	}
-	assertErrCode(t, w, "USER_NOT_FOUND")
-}
-
-// TestSetUserOrderCap_AdminGate exercises the RequireAdmin middleware through a
-// real router (the handler-direct tests above bypass middleware).
-func TestSetUserOrderCap_AdminGate(t *testing.T) {
-	user := setupOrderTestDB(t)
-	idStr := strconv.FormatUint(uint64(user.ID), 10)
-
-	router := func() http.Handler {
-		r := chi.NewRouter()
-		r.With(middleware.RequireAdmin).
-			Patch("/api/v1/users/{id}/order-cap", NewAdminUserHandler().SetUserOrderCap)
-		return r
-	}
-	newReq := func() *http.Request {
-		return httptest.NewRequest("PATCH", "/api/v1/users/"+idStr+"/order-cap",
-			strings.NewReader(`{"max_order_cents":100}`))
-	}
-
-	t.Run("disabled when ADMIN_API_KEY unset", func(t *testing.T) {
-		t.Setenv("ADMIN_API_KEY", "")
-		w := httptest.NewRecorder()
-		router().ServeHTTP(w, newReq())
-		if w.Code != http.StatusServiceUnavailable {
-			t.Fatalf("status: want 503 got %d", w.Code)
-		}
-		assertErrCode(t, w, "ADMIN_DISABLED")
-	})
-
-	t.Run("rejects wrong key", func(t *testing.T) {
-		t.Setenv("ADMIN_API_KEY", "secret")
-		req := newReq()
-		req.Header.Set("X-Admin-Key", "nope")
-		w := httptest.NewRecorder()
-		router().ServeHTTP(w, req)
-		if w.Code != http.StatusUnauthorized {
-			t.Fatalf("status: want 401 got %d", w.Code)
-		}
-		assertErrCode(t, w, "UNAUTHORIZED")
-	})
-
-	t.Run("accepts correct key", func(t *testing.T) {
-		t.Setenv("ADMIN_API_KEY", "secret")
-		req := newReq()
-		req.Header.Set("X-Admin-Key", "secret")
-		w := httptest.NewRecorder()
-		router().ServeHTTP(w, req)
-		if w.Code != http.StatusOK {
-			t.Fatalf("status: want 200 got %d (%s)", w.Code, w.Body.String())
-		}
-		var got models.User
-		if err := database.GetDB().First(&got, user.ID).Error; err != nil {
-			t.Fatalf("reload user: %v", err)
-		}
-		if !eqIntPtr(got.MaxOrderCents, intPtr(100)) {
-			t.Errorf("db MaxOrderCents: want 100 got %s", fmtIntPtr(got.MaxOrderCents))
-		}
-	})
-}
-
-func assertErrCode(t *testing.T, w *httptest.ResponseRecorder, want string) {
-	t.Helper()
-	var resp struct {
-		Error struct {
-			Code string `json:"code"`
-		} `json:"error"`
-	}
-	_ = json.Unmarshal(w.Body.Bytes(), &resp)
-	if resp.Error.Code != want {
-		t.Errorf("error code: want %q got %q", want, resp.Error.Code)
-	}
-}

api/handlers/auth.go

@@ -108,7 +108,7 @@ func (h *AuthHandler) GetToken(w http.ResponseWriter, r *http.Request) {
 	}
 
 	middleware.RecordAuthAttempt("success")
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"access_token": token,
 		"token_type":   "Bearer",
 		"expires_in":   1800, // 30 minutes in seconds
@@ -146,7 +146,7 @@ func (h *AuthHandler) RegisterWithSSHKey(w http.ResponseWriter, r *http.Request)
 	}
 
 	if len(errors) > 0 {
-		utils.RespondError(w, http.StatusBadRequest, "VALIDATION_ERROR", "validation failed", map[string]any{
+		utils.RespondError(w, http.StatusBadRequest, "VALIDATION_ERROR", "validation failed", map[string]interface{}{
 			"errors": errors,
 		})
 		return
@@ -173,7 +173,7 @@ func (h *AuthHandler) RegisterWithSSHKey(w http.ResponseWriter, r *http.Request)
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusCreated, map[string]any{
+	utils.RespondSuccess(w, http.StatusCreated, map[string]interface{}{
 		"user": user.ToPublic(),
 	})
 }
@@ -195,7 +195,7 @@ func (h *AuthHandler) GetUserBySSHKey(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"user": user.ToPublic(),
 	})
 }

api/handlers/card_test.go

@@ -1,156 +0,0 @@
-package handlers
-
-import (
-	"encoding/json"
-	"net/http"
-	"net/http/httptest"
-	"os"
-	"strconv"
-	"testing"
-	"time"
-
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-
-	"github.com/go-chi/chi/v5"
-)
-
-// TestGetCards_FiltersExpiredRows drives the SQL WHERE claude used by
-// GetCards. a column-name typo (e.g used_id instead of user_id) surfaces
-// here as a sqlite error, not in prod
-func TestGetCards_FiltersExpiredRows(t *testing.T) {
-	testDB, user := setupCardsExpireTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	now := time.Now()
-	past := now.Add(-1 * time.Hour)
-	future := now.Add(24 * time.Hour)
-
-	expired := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_expired", Last4: "1111",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &past,
-	}
-	fresh := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_fresh", Last4: "2222",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &future,
-	}
-	legacy := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_legacy", Last4: "3333",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030,
-	}
-	for _, card := range []*models.Card{&expired, &fresh, &legacy} {
-		if err := db.Create(card).Error; err != nil {
-			t.Fatalf("seed card: %v", err)
-		}
-	}
-
-	handler := NewCardHandler("")
-	req := authRequest("GET", "/api/v1/cards", nil, user.ID)
-	w := httptest.NewRecorder()
-	handler.GetCards(w, req)
-
-	if w.Code != http.StatusOK {
-		t.Fatalf("GetCards status %d, body %s", w.Code, w.Body.String())
-	}
-
-	var resp struct {
-		Success bool `json:"success"`
-		Data    struct {
-			Cards []models.Card `json:"cards"`
-		} `json:"data"`
-	}
-	if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
-		t.Fatalf("decode: %v", err)
-	}
-	if len(resp.Data.Cards) != 2 {
-		t.Fatalf("want 2 visible cards (fresh + legacy NULL), got %d", len(resp.Data.Cards))
-	}
-	for _, card := range resp.Data.Cards {
-		if card.ID == expired.ID {
-			t.Fatalf("expired card leaked into GetCards response")
-		}
-	}
-}
-
-// TestSetDefaultCard_ExpiredReturns410 verifies the sync-expire branch when
-// the user acts on a card whose retention deadline already elapsed
-func TestSetDefaultCard_ExpiredReturns410(t *testing.T) {
-	testDB, user := setupCardsExpireTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	past := time.Now().Add(-1 * time.Hour)
-	card := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_expired", Last4: "1111",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &past,
-	}
-	if err := db.Create(&card).Error; err != nil {
-		t.Fatalf("seed card: %v", err)
-	}
-
-	handler := NewCardHandler("")
-	idStr := strconv.FormatUint(uint64(card.ID), 10)
-	req := authRequest("PUT", "/api/v1/cards/"+idStr+"/default", nil, user.ID)
-	routeCtx := chi.NewRouteContext()
-	routeCtx.URLParams.Add("id", idStr)
-	req = req.WithContext(contextWithRoute(req.Context(), routeCtx))
-
-	w := httptest.NewRecorder()
-	handler.SetDefaultCard(w, req)
-
-	if w.Code != http.StatusGone {
-		t.Fatalf("want 410 gone, got %d, body %s", w.Code, w.Body.String())
-	}
-	var resp struct {
-		Error struct {
-			Code string `json:"code"`
-		} `json:"error"`
-	}
-	_ = json.NewDecoder(w.Body).Decode(&resp)
-	if resp.Error.Code != "CARD_STORAGE_EXPIRED" {
-		t.Fatalf("want CARD_STORAGE_EXPIRED code, got %q", resp.Error.Code)
-	}
-
-	var soft models.Card
-	if err := db.Unscoped().First(&soft, card.ID).Error; err != nil {
-		t.Fatalf("reload card unscoped: %v", err)
-	}
-	if !soft.DeletedAt.Valid {
-		t.Fatalf("expired card was not soft-deleted")
-	}
-}
-
-// TestRefreshCardStorageTTL_BumpLastUsedAndExpiry exercises the SQL Updates
-// map used by both the payment_intent.succeede webhook and the duplicate-card
-// add path. Column-name typos in the map surface here
-func TestRefreshCardStorageTTL_BumpLastUsedAndExpiry(t *testing.T) {
-	testDB, user := setupCardsExpireTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	old := time.Now().Add(-30 * 24 * time.Hour)
-	card := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_refresh", Last4: "4242",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &old,
-	}
-	if err := db.Create(&card).Error; err != nil {
-		t.Fatalf("seed card: %v", err)
-	}
-
-	now := time.Now()
-	if err := refreshCardStorageTTL(db, card.ID, now); err != nil {
-		t.Fatalf("refreshCardStorageTTL: %v", err)
-	}
-
-	var reloaded models.Card
-	if err := db.First(&reloaded, card.ID).Error; err != nil {
-		t.Fatalf("reload card: %v", err)
-	}
-	if reloaded.LastUsedAt == nil || !reloaded.StorageExpiresAt.After(now.Add(179*24*time.Hour)) {
-		t.Fatalf("storage_expires_at not extended, got %v", reloaded.StorageExpiresAt)
-	}
-}

api/handlers/cards.go

@@ -5,11 +5,9 @@ import (
 	"encoding/hex"
 	"encoding/json"
 	"fmt"
-	"log/slog"
 	"net/http"
 	"strconv"
-	"strings"
-	"time"
+	"sync"
 
 	"github.com/go-chi/chi/v5"
 	"github.com/stripe/stripe-go/v78"
@@ -26,75 +24,62 @@ import (
 	stripeSession "github.com/stripe/stripe-go/v78/checkout/session"
 )
 
-const RedirectTTL = 10 * time.Minute
+// payRedirects maps short tokens to full Stripe checkout URLs.
+var (
+	payRedirects   = map[string]string{}
+	payRedirectsMu sync.Mutex
+)
 
-func storeRedirect(stripeURL, purpose string) (string, error) {
+func storeRedirect(stripeURL string) (string, error) {
 	b := make([]byte, 16)
 	if _, err := rand.Read(b); err != nil {
 		return "", err
 	}
 	token := hex.EncodeToString(b)
-	now := time.Now()
-	rec := models.PayRedirect{
-		Token:     token,
-		URL:       stripeURL,
-		Purpose:   purpose,
-		CreatedAt: now,
-		ExpiresAt: now.Add(RedirectTTL),
-	}
-	if err := database.GetDB().Create(&rec).Error; err != nil {
-		return "", err
-	}
+	payRedirectsMu.Lock()
+	payRedirects[token] = stripeURL
+	payRedirectsMu.Unlock()
 	return token, nil
 }
 
 // PayRedirect resolves a short token and redirects to the Stripe checkout URL.
 func PayRedirect(w http.ResponseWriter, r *http.Request) {
 	token := chi.URLParam(r, "token")
-	db := database.GetDB().WithContext(r.Context())
-	var rec models.PayRedirect
-	if err := db.Where("token = ?", token).First(&rec).Error; err != nil {
+	payRedirectsMu.Lock()
+	url, ok := payRedirects[token]
+	payRedirectsMu.Unlock()
+	if !ok {
 		http.NotFound(w, r)
 		return
 	}
-	if time.Now().After(rec.ExpiresAt) {
-		db.Where("token = ?", rec.Token).Delete(&models.PayRedirect{})
-		http.NotFound(w, r)
-		return
-	}
-	http.Redirect(w, r, rec.URL, http.StatusFound)
+	http.Redirect(w, r, url, http.StatusFound)
 }
 
 // CardHandler handles saved payment method CRUD.
 type CardHandler struct {
-	appURL string
+	stripeKey string
+	appURL    string
 }
 
-// NewCardHandler creates a new card handler. Stripe credentials are wired
-// once at startup via stripe.Key in api/main.go.
-func NewCardHandler(appURL string) *CardHandler {
-	return &CardHandler{appURL: appURL}
+// NewCardHandler creates a new card handler with the Stripe secret key.
+func NewCardHandler(stripeSecretKey string, appURL string) *CardHandler {
+	return &CardHandler{stripeKey: stripeSecretKey, appURL: appURL}
 }
 
 // GetCards returns all saved cards for the authenticated user.
-// Cards past their retention deadline are filtered out at read time;
-// physical deletion runs in handlers.ReconcileExpiredCards.
 func (h *CardHandler) GetCards(w http.ResponseWriter, r *http.Request) {
 	db := database.GetDB().WithContext(r.Context())
 	userID := middleware.UserIDFromContext(r.Context())
 
 	var cards []models.Card
-	db.Where(
-		"user_id = ? AND (storage_expires_at IS NULL OR storage_expires_at > ?)",
-		userID, time.Now(),
-	).Order("is_default DESC, created_at DESC").Find(&cards)
+	db.Where("user_id = ?", userID).Order("is_default DESC, created_at DESC").Find(&cards)
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"cards": cards,
 	})
 }
 
-// func utils.RespondError(w http.ResponseWriter, statusCode int, code string, message string, details map[string]any)
+// func utils.RespondError(w http.ResponseWriter, statusCode int, code string, message string, details map[string]interface{})
 
 // GetCard returns a single saved card by ID.
 func (h *CardHandler) GetCard(w http.ResponseWriter, r *http.Request) {
@@ -114,7 +99,7 @@ func (h *CardHandler) GetCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"card": card,
 	})
 }
@@ -136,15 +121,6 @@ func (h *CardHandler) SetDefaultCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if card.IsStorageExpired(time.Now()) {
-		if err := expireStoredCard(db, &card); err != nil {
-			utils.RespondError(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to expire card", nil)
-			return
-		}
-		respondCardStorageExpired(w)
-		return
-	}
-
 	if err := db.Model(&models.Card{}).Where("user_id = ?", userID).Update("is_default", false).Error; err != nil {
 		utils.RespondError(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to update card", nil)
 		return
@@ -156,7 +132,7 @@ func (h *CardHandler) SetDefaultCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"card": card,
 	})
 }
@@ -171,6 +147,8 @@ func (h *CardHandler) CollectCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	stripe.Key = h.stripeKey
+
 	if err := ensureStripeCustomer(db, &user); err != nil {
 		utils.RespondError(w, http.StatusInternalServerError, "STRIPE_ERROR", "failed to create stripe customer", nil)
 		return
@@ -190,12 +168,12 @@ func (h *CardHandler) CollectCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	token, err := storeRedirect(sess.URL, models.RedirectPurposeAddCard)
+	token, err := storeRedirect(sess.URL)
 	if err != nil {
 		utils.RespondError(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to generate redirect token", nil)
 		return
 	}
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"url": fmt.Sprintf("%s/pay/%s", h.appURL, token),
 	})
 }
@@ -232,6 +210,8 @@ func (h *CardHandler) SaveCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	stripe.Key = h.stripeKey
+
 	// Ensure the user has a Stripe customer, creating one if needed.
 	if err := ensureStripeCustomer(db, &user); err != nil {
 		utils.RespondError(w, http.StatusInternalServerError, "STRIPE_ERROR", "failed to create stripe customer", nil)
@@ -298,7 +278,7 @@ func (h *CardHandler) SaveCard(w http.ResponseWriter, r *http.Request) {
 
 	audit.CardAdded(userID, card.ID, card.Brand, card.Last4)
 
-	utils.RespondSuccess(w, http.StatusCreated, map[string]any{
+	utils.RespondSuccess(w, http.StatusCreated, map[string]interface{}{
 		"card": card,
 	})
 }
@@ -331,6 +311,7 @@ func (h *CardHandler) DeleteCard(w http.ResponseWriter, r *http.Request) {
 
 	// Detach from Stripe (best-effort; don't block deletion on Stripe errors).
 	if len(card.StripePaymentID) >= 3 && card.StripePaymentID[:3] == "pm_" {
+		stripe.Key = h.stripeKey
 		_, _ = paymentmethod.Detach(card.StripePaymentID, &stripe.PaymentMethodDetachParams{})
 	}
 
@@ -342,57 +323,11 @@ func (h *CardHandler) DeleteCard(w http.ResponseWriter, r *http.Request) {
 
 	audit.CardDeleted(userID, card.ID)
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"message": "card deleted",
 	})
 }
 
-// expireStoredCard removes a card whose retention deadline elapsed.
-// Local state (cart references + card row) is committed atomically;
-// Stripe detach and audit run only after the local commit so retries
-// cannot double-fire the audit event. Stripe detach is gated on
-// stripe.Key being non-empty so tests (which never init the SDK key)
-// skip the real network call without an explicit flag.
-func expireStoredCard(db *gorm.DB, card *models.Card) error {
-	if err := db.Transaction(func(tx *gorm.DB) error {
-		if err := tx.Model(&models.Cart{}).Where("card_id = ? AND user_id = ?", card.ID, card.UserID).Update("card_id", nil).Error; err != nil {
-			return fmt.Errorf("failed to clear expired card from cart: %w", err)
-		}
-		if err := tx.Delete(card).Error; err != nil {
-			return fmt.Errorf("failed to delete expired card: %w", err)
-		}
-		return nil
-	}); err != nil {
-		return err
-	}
-
-	if stripe.Key != "" && strings.HasPrefix(card.StripePaymentID, "pm_") {
-		if _, err := paymentmethod.Detach(card.StripePaymentID, &stripe.PaymentMethodDetachParams{}); err != nil {
-			slog.Warn("failed to detach expired card", "card_id", card.ID, "error", err)
-		}
-	}
-
-	audit.CardExpired(card.UserID, card.ID)
-	return nil
-}
-
-func refreshCardStorageTTL(db *gorm.DB, cardID uint, now time.Time) error {
-	return db.Model(&models.Card{}).Where("id = ?", cardID).Updates(map[string]any{
-		"last_used_at":       now,
-		"storage_expires_at": models.CardStorageExpiresAt(now),
-	}).Error
-}
-
-func respondCardStorageExpired(w http.ResponseWriter) {
-	utils.RespondError(
-		w,
-		http.StatusGone,
-		"CARD_STORAGE_EXPIRED",
-		"saved card expired, add it again",
-		nil,
-	)
-}
-
 // ensureStripeCustomer creates a Stripe Customer for the user if they don't
 // already have one and persists the customer ID. Safe to call concurrently —
 // a duplicate Stripe customer is harmless; the local record reflects the first

api/handlers/cards_expire_test.go

@@ -1,156 +0,0 @@
-package handlers
-
-import (
-	"context"
-	"os"
-	"testing"
-	"time"
-
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-)
-
-// TestReconcileExpiredCards_RemovesPastDeadlineOnly drives the real SQL path
-// so a column-name typo in the WHERE clause surfaces here, not in production.
-func TestReconcileExpiredCards_RemovesPastDeadlineOnly(t *testing.T) {
-	testDB, user := setupCardsExpireTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	now := time.Now()
-	past := now.Add(-1 * time.Hour)
-	future := now.Add(24 * time.Hour)
-
-	expired := models.Card{
-		UserID:           user.ID,
-		StripePaymentID:  "tok_expired",
-		Last4:            "1111",
-		Brand:            "Visa",
-		ExpMonth:         1,
-		ExpYear:          2030,
-		StorageExpiresAt: &past,
-	}
-	fresh := models.Card{
-		UserID:           user.ID,
-		StripePaymentID:  "tok_fresh",
-		Last4:            "2222",
-		Brand:            "Visa",
-		ExpMonth:         1,
-		ExpYear:          2030,
-		StorageExpiresAt: &future,
-	}
-	noTTL := models.Card{
-		UserID:          user.ID,
-		StripePaymentID: "tok_legacy",
-		Last4:           "3333",
-		Brand:           "Visa",
-		ExpMonth:        1,
-		ExpYear:         2030,
-	}
-	for _, c := range []*models.Card{&expired, &fresh, &noTTL} {
-		if err := db.Create(c).Error; err != nil {
-			t.Fatalf("seed card: %v", err)
-		}
-	}
-
-	cart := models.Cart{UserID: user.ID, CardID: &expired.ID}
-	if err := db.Create(&cart).Error; err != nil {
-		t.Fatalf("seed cart: %v", err)
-	}
-
-	ReconcileExpiredCards(context.Background())
-
-	var remaining []models.Card
-	if err := db.Where("user_id = ?", user.ID).Find(&remaining).Error; err != nil {
-		t.Fatalf("list cards: %v", err)
-	}
-	if len(remaining) != 2 {
-		t.Fatalf("want 2 cards remaining, got %d", len(remaining))
-	}
-	for _, c := range remaining {
-		if c.ID == expired.ID {
-			t.Fatalf("expired card was not deleted")
-		}
-	}
-
-	var refreshed models.Cart
-	if err := db.First(&refreshed, cart.ID).Error; err != nil {
-		t.Fatalf("reload cart: %v", err)
-	}
-	if refreshed.CardID != nil {
-		t.Fatalf("cart still references expired card: %v", refreshed.CardID)
-	}
-}
-
-// TestReconcileExpiredCards_SweepsAcrossUsers verifies the sweeper is not
-// scoped to one user; it must collect every past-deadline row in one pass.
-func TestReconcileExpiredCards_SweepsAcrossUsers(t *testing.T) {
-	testDB, user := setupCardsExpireTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	past := time.Now().Add(-1 * time.Hour)
-
-	other := models.User{
-		SSHKeyFingerprint: "SHA256:other",
-		SSHPublicKey:      "ssh-ed25519 AAAA other",
-		Name:              "Other",
-		Email:             "other@example.com",
-	}
-	if err := db.Create(&other).Error; err != nil {
-		t.Fatalf("seed other user: %v", err)
-	}
-
-	for _, uid := range []uint{user.ID, other.ID} {
-		c := models.Card{
-			UserID:           uid,
-			StripePaymentID:  "tok_expired",
-			Last4:            "9999",
-			Brand:            "Visa",
-			ExpMonth:         1,
-			ExpYear:          2030,
-			StorageExpiresAt: &past,
-		}
-		if err := db.Create(&c).Error; err != nil {
-			t.Fatalf("seed card: %v", err)
-		}
-	}
-
-	ReconcileExpiredCards(context.Background())
-
-	var count int64
-	if err := db.Model(&models.Card{}).Count(&count).Error; err != nil {
-		t.Fatalf("count cards: %v", err)
-	}
-	if count != 0 {
-		t.Fatalf("want 0 cards after sweep, got %d", count)
-	}
-}
-
-func setupCardsExpireTestDB(t *testing.T) (string, models.User) {
-	t.Helper()
-	testDB := "test_cards_expire.db"
-	_ = os.Remove(testDB)
-	database.ResetForTesting()
-
-	db, err := database.Connect(testDB)
-	if err != nil {
-		t.Fatalf("connect: %v", err)
-	}
-	if err := database.Migrate(db); err != nil {
-		t.Fatalf("migrate: %v", err)
-	}
-
-	user := models.User{
-		SSHKeyFingerprint: "SHA256:cards-expire",
-		SSHPublicKey:      "ssh-ed25519 AAAA cardsexpire",
-		Name:              "Test User",
-		Email:             "cards-expire@example.com",
-	}
-	if err := db.Create(&user).Error; err != nil {
-		t.Fatalf("seed user: %v", err)
-	}
-	return testDB, user
-}

api/handlers/cart.go

@@ -4,12 +4,9 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"log/slog"
 	"net/http"
-	"strconv"
 	"time"
 
-	"github.com/go-chi/chi/v5"
 	"github.com/stripe/stripe-go/v78"
 	"github.com/stripe/stripe-go/v78/paymentintent"
 	"github.com/stripe/stripe-go/v78/paymentmethod"
@@ -26,25 +23,12 @@ import (
 )
 
 type CartHandler struct {
-	appURL        string
-	maxOrderCents int
+	stripeKey string
 }
 
-// maxAuthIssuances caps how many times a single ordes's PaymentIntent can be
-// pushed into requires_action; one initial challende plus up to three retries
-// before we tell the customer to use a different card. Counted via existing
-// audit rows (audit.EventOrderRequiresAction) so the cap stays migration-free.
-const maxAuthIssuances = 4
-
-// paymentIntentNewFn lets tests stub the Stripe create call without spinning
-// up an httptest backend. Production callers go straight through to the real
-// paymentintent.New. Mirrors paymentIntentGetFn in reconcile.go.
-var paymentIntentNewFn = paymentintent.New
-
-// NewCartHandler creates a new cart handler. Stripe credentials are wired
-// once at startup via stripe.Key in api/main.go.
-func NewCartHandler(appURL string, maxOrderCents int) *CartHandler {
-	return &CartHandler{appURL: appURL, maxOrderCents: maxOrderCents}
+// NewCartHandler creates a new cart handler with the Stripe secret key
+func NewCartHandler(stripeSecretKey string) *CartHandler {
+	return &CartHandler{stripeKey: stripeSecretKey}
 }
 
 // getOrCreateCart finds the users cart or creates one.
@@ -61,18 +45,18 @@ func getOrCreateCart(ctx context.Context, userID uint) (*models.Cart, error) {
 	return &cart, nil
 }
 
-func cartResponse(ctx context.Context, cart *models.Cart) map[string]any {
+func cartResponse(ctx context.Context, cart *models.Cart) map[string]interface{} {
 	db := database.GetDB().WithContext(ctx)
 
 	var items []models.CartItem
 	db.Where("cart_id = ? AND quantity > 0", cart.ID).Preload("Coffee").Find(&items)
 
 	subtotal := 0
-	itemsData := make([]map[string]any, 0, len(items))
+	itemsData := make([]map[string]interface{}, 0, len(items))
 	for _, item := range items {
 		lineTotal := item.Coffee.Price * item.Quantity
 		subtotal += lineTotal
-		itemsData = append(itemsData, map[string]any{
+		itemsData = append(itemsData, map[string]interface{}{
 			"id":        item.ID,
 			"coffee_id": item.CoffeeID,
 			"quantity":  item.Quantity,
@@ -81,7 +65,7 @@ func cartResponse(ctx context.Context, cart *models.Cart) map[string]any {
 		})
 	}
 
-	return map[string]any{
+	return map[string]interface{}{
 		"items":            itemsData,
 		"subtotal":         subtotal,
 		"address_id":       cart.AddressID,
@@ -100,7 +84,7 @@ func (h *CartHandler) GetCart(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"cart": cartResponse(r.Context(), cart),
 	})
 }
@@ -163,7 +147,7 @@ func (h *CartHandler) SetItem(w http.ResponseWriter, r *http.Request) {
 		}
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"cart": cartResponse(r.Context(), cart),
 	})
 }
@@ -199,7 +183,7 @@ func (h *CartHandler) SetAddress(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"message": "address set",
 	})
 }
@@ -224,15 +208,6 @@ func (h *CartHandler) SetCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if card.IsStorageExpired(time.Now()) {
-		if err := expireStoredCard(db, &card); err != nil {
-			utils.RespondError(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to expire card", nil)
-			return
-		}
-		respondCardStorageExpired(w)
-		return
-	}
-
 	cart, err := getOrCreateCart(r.Context(), userID)
 	if err != nil {
 		utils.RespondError(w, http.StatusInternalServerError, "CART_ERROR", "failed to get cart", nil)
@@ -244,7 +219,7 @@ func (h *CartHandler) SetCard(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"message": "card set",
 	})
 }
@@ -264,7 +239,7 @@ func (h *CartHandler) ClearCart(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"message": "cart cleared",
 	})
 }
@@ -319,16 +294,6 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if card.IsStorageExpired(time.Now()) {
-		middleware.RecordCartConversion("validation_card_expired")
-		if err := expireStoredCard(db, &card); err != nil {
-			utils.RespondError(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to expire card", nil)
-			return
-		}
-		respondCardStorageExpired(w)
-		return
-	}
-
 	var user models.User
 	if err := db.First(&user, userID).Error; err != nil {
 		middleware.RecordCartConversion("user_not_found")
@@ -336,6 +301,8 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	stripe.Key = h.stripeKey
+
 	// Ensure the user has a Stripe customer (shared helper with cards handler).
 	if err := ensureStripeCustomer(db, &user); err != nil {
 		middleware.RecordCartConversion("stripe_customer_failed")
@@ -386,50 +353,6 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 
 	total := subtotal + cart.ShippingCost
 
-	// Per-user overridable spend cap. The override may raise OR lower the global
-	// cap — operators set it in both directions deliberately. A negative override
-	// is nonsense: ignore it and fall back to the global so an erroneous DB write
-	// cannot silently disable a fraud control (mirrors loadMaxOrderCents in
-	// pkg/config/config.go, which defaults a negative MAX_ORDER_CENTS). An explicit
-	// 0 is a valid per-user off-switch (same semantics as the global).
-	capCents := h.maxOrderCents
-	if user.MaxOrderCents != nil {
-		if *user.MaxOrderCents < 0 {
-			slog.Warn("ignoring negative per-user order cap, using global",
-				"user_id", user.ID,
-				"user_cap_cents", *user.MaxOrderCents,
-				"global_cap_cents", h.maxOrderCents)
-		} else {
-			capCents = *user.MaxOrderCents
-		}
-	}
-
-	// A user-set self-limit may only TIGHTEN the effective cap, never raise it.
-	// a compromised account must not be able to lift its own ceiling to drain a
-	// stolen card. Unlike the admin/global cap (where 0 is an off-switch), a
-	// present self-limit always activates a ceiling, a self-limit of 0 means
-	// "block everything", not "disable", so it folds in via min() and can only
-	// lower capCents. A negative value is ignored (mirrors the maxOrderCents
-	// guard above); this min() is the authoritative lower-only guard.
-	capActive := capCents > 0
-	if user.SelfLimitCents != nil && *user.SelfLimitCents >= 0 {
-		if self := *user.SelfLimitCents; !capActive || self < capCents {
-			capCents = self
-		}
-		capActive = true
-	}
-	if capActive && total > capCents {
-		middleware.RecordCartConversion("validation_over_limit")
-		audit.CartRejected(userID, total, capCents)
-		utils.RespondError(w, http.StatusBadRequest, "CART_OVER_LIMIT",
-			fmt.Sprintf("order total must be at most $%.2f", float64(capCents)/100),
-			map[string]any{
-				"total_cents": total,
-				"limit_cents": capCents,
-			})
-		return
-	}
-
 	if total < 50 {
 		middleware.RecordCartConversion("validation_min_amount")
 		utils.RespondError(w, http.StatusBadRequest, "VALIDATION_ERROR", "order total must be at least $0.50", nil)
@@ -465,28 +388,20 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 
 	audit.OrderCreated(userID, order.ID, total)
 
-	// Charge the card. This is a Customer-Initiated Transaction (CIT): the
-	// customer is present in the TUI at checkout. We deliberately do NOT set
-	// OffSession — that flag marks a Merchant-Initiated Transaction (MIT),
-	// which under PSD2/SCA may only claim an exemption when a stored mandate
-	// authorises the merchant to charge while the customer is away. We capture
-	// no mandate and run no recurring billing, so MIT would misrepresent the
-	// transaction type. As a CIT, an SCA challenge surfaces as
-	// pi.Status == requires_action (handled below), not as an
-	// authentication_required error. See docs/sca-psd2-compliance.md "Gap 1".
-	// Reference: stripe-samples accept-a-payment custom-payment-flow —
-	// php/public/google-pay.php drives 3DS off status==requires_action and sets
-	// no off_session on a customer-present confirm.
-	// The idempotency key is tied to the order ID so retries never double charge.
+	// Charge the card. The idempotency key is tied to the order ID so retries
+	// never produce a double charge.
 	piParams := &stripe.PaymentIntentParams{
-		Amount:             stripe.Int64(int64(total)),
-		Currency:           stripe.String(string(stripe.CurrencyUSD)),
-		Customer:           stripe.String(user.StripeCustomerID),
-		PaymentMethod:      stripe.String(paymentMethodID),
-		PaymentMethodTypes: stripe.StringSlice([]string{"card"}),
-		ReturnURL:          stripe.String(h.appURL + "/post-3ds"),
-		Confirm:            stripe.Bool(true),
-		Description:        stripe.String(fmt.Sprintf("terminal.shop order #%d", order.ID)),
+		Amount:        stripe.Int64(int64(total)),
+		Currency:      stripe.String(string(stripe.CurrencyUSD)),
+		Customer:      stripe.String(user.StripeCustomerID),
+		PaymentMethod: stripe.String(paymentMethodID),
+		OffSession:    stripe.Bool(true),
+		AutomaticPaymentMethods: &stripe.PaymentIntentAutomaticPaymentMethodsParams{
+			Enabled:        stripe.Bool(true),
+			AllowRedirects: stripe.String("never"),
+		},
+		Confirm:     stripe.Bool(true),
+		Description: stripe.String(fmt.Sprintf("terminal.shop order #%d", order.ID)),
 		Shipping: &stripe.ShippingDetailsParams{
 			Name: stripe.String(address.Name),
 			Address: &stripe.AddressParams{
@@ -505,21 +420,12 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 	}
 
 	stripeStart := time.Now()
-	pi, err := paymentIntentNewFn(piParams)
+	pi, err := paymentintent.New(piParams)
 	stripeDur := time.Since(stripeStart).Seconds()
 	if err != nil {
 		middleware.ObserveStripeRequest("payment_intent_create", "error", stripeDur)
+		db.Model(&order).Update("status", models.OrderStatusFailed)
 		if stripeErr, ok := err.(*stripe.Error); ok {
-			// Defensive fallback: as CIT (no off_session) Stripe normally
-			// signals 3DS via status=requires_action below, not via this error.
-			// authentication_required can still appear if the saved card needs
-			// auth that could not run inline; respondRequiresAction re-Confirms
-			// on-session to recover. (Pre-CIT migration this was the main path.)
-			if stripeErr.Code == stripe.ErrorCodeAuthenticationRequired && stripeErr.PaymentIntent != nil {
-				h.respondRequiresAction(w, &order, paymentMethodID, stripeErr.PaymentIntent)
-				return
-			}
-			db.Model(&order).Update("status", models.OrderStatusFailed)
 			switch stripeErr.Type {
 			case stripe.ErrorTypeCard:
 				middleware.RecordCartConversion("card_declined")
@@ -536,7 +442,6 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 			}
 			return
 		}
-		db.Model(&order).Update("status", models.OrderStatusFailed)
 		middleware.RecordCartConversion("stripe_error")
 		audit.OrderFailed(userID, order.ID, total, err.Error())
 		utils.RespondError(w, http.StatusInternalServerError, "PAYMENT_FAILED", "payment failed", nil)
@@ -544,11 +449,6 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 	}
 	middleware.ObserveStripeRequest("payment_intent_create", "success", stripeDur)
 
-	if pi.Status == stripe.PaymentIntentStatusRequiresAction {
-		h.respondRequiresAction(w, &order, paymentMethodID, pi)
-		return
-	}
-
 	// Commit payment ID and clear cart in a single transaction.
 	txErr := db.Transaction(func(tx *gorm.DB) error {
 		order.StripePaymentID = pi.ID
@@ -559,7 +459,7 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 		if err := tx.Where("cart_id = ?", cart.ID).Delete(&models.CartItem{}).Error; err != nil {
 			return err
 		}
-		return tx.Model(cart).Updates(map[string]any{
+		return tx.Model(cart).Updates(map[string]interface{}{
 			"address_id": nil,
 			"card_id":    nil,
 		}).Error
@@ -586,73 +486,11 @@ func (h *CartHandler) ConvertCart(w http.ResponseWriter, r *http.Request) {
 	}
 	go notify.SlackOrderPaid(&order)
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"order": order,
 	})
 }
 
-// respondRequiresAction handles a PaymentIntent that needs 3DS auth. The order
-// transitions to requires_action (see caveat #20 in sca-psd2-compliance.md);
-// the payment_intent.succeeded webhook flips it to paid once the customer
-// completes the bank-hosted challenge. The TUI polls /api/v1/orders/{id}/status.
-func (h *CartHandler) respondRequiresAction(w http.ResponseWriter, order *models.Order, paymentMethodID string, pi *stripe.PaymentIntent) {
-	db := database.GetDB()
-
-	// After an off-session authentication_required decline, the PI sits in
-	// status=requires_payment_method with payment_method detached. Re-confirm
-	// on-session with the same PM so Stripe pushes the PI into requires_action
-	// and populates next_action.redirect_to_url with the 3DS challenge URL.
-	if pi.NextAction == nil || pi.NextAction.RedirectToURL == nil || pi.NextAction.RedirectToURL.URL == "" {
-		confirmed, cerr := paymentintent.Confirm(pi.ID, &stripe.PaymentIntentConfirmParams{
-			PaymentMethod: stripe.String(paymentMethodID),
-			OffSession:    stripe.Bool(false),
-			ReturnURL:     stripe.String(h.appURL + "/post-3ds"),
-		})
-		if cerr == nil && confirmed != nil {
-			pi = confirmed
-		}
-	}
-
-	if pi.NextAction == nil || pi.NextAction.RedirectToURL == nil || pi.NextAction.RedirectToURL.URL == "" {
-		middleware.RecordCartConversion("sca_missing_next_action")
-		db.Model(order).Update("status", models.OrderStatusFailed)
-		audit.OrderFailed(order.UserID, order.ID, order.Total, "stripe returned requires_action without redirect url")
-		utils.RespondError(w, http.StatusBadGateway, "PAYMENT_FAILED", "stripe did not return a 3ds url", nil)
-		return
-	}
-
-	// Persist the paymentIntent id AND set status to requires_action so list
-	// UIs can distinguish "charging" from "awaiting customer 3DS". The
-	// payment_intent.payment_failed webhook from the initial off-session
-	// decline often arrives before this response and flips the order to
-	// failed - override it back so the 3DS-in-flight order shows the
-	// correct state
-	if err := db.Model(order).Updates(map[string]any{
-		"stripe_payment_id": pi.ID,
-		"status":            models.OrderStatusRequiresAction,
-	}).Error; err != nil {
-		utils.RespondError(w, http.StatusInternalServerError, "DATABASE_ERROR", "failed to save payment id", nil)
-		return
-	}
-
-	token, err := storeRedirect(pi.NextAction.RedirectToURL.URL, models.RedirectPurposeCheckout3DS)
-	if err != nil {
-		utils.RespondError(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to allocate redirect token", nil)
-		return
-	}
-
-	middleware.RecordCartConversion("requires_action")
-	audit.OrderRequiresAction(order.UserID, order.ID, pi.ID)
-
-	utils.RespondSuccess(w, http.StatusAccepted, map[string]any{
-		"order_id":          order.ID,
-		"payment_intent_id": pi.ID,
-		"status":            "requires_action",
-		"redirect_token":    token,
-		"redirect_url":      fmt.Sprintf("%s/pay/%s", h.appURL, token),
-	})
-}
-
 func mapStripeCardErrCode(code stripe.ErrorCode) string {
 	switch code {
 	case stripe.ErrorCodeAuthenticationRequired:
@@ -685,149 +523,3 @@ func appURLForHandler(r *http.Request) string {
 	}
 	return fmt.Sprintf("%s://%s", scheme, host)
 }
-
-// RetryAuth re-Confirms an in-flight PaymentIntent that the customer failed
-// or abandoned during the 3DS challenge, recovering the existing order rather
-// than starting a new checkout. Bound to POST /api/v1/orders/{id}/retry-auth.
-//
-// Stripe's PI state machine bounces back to requires_payment_method after a
-// failed or abandoned 3DS, so paymentintent.Confirm(pi.id, …) mints a fresh
-// next_action.redirect_to_url — the same shape respondRequiresAction already
-// handles. No idempotency key is set: Confirm mutates an existing PI and
-// Stripe collapses by id (see sca-psd2-compliance.md caveat #5).
-func (h *CartHandler) RetryAuth(w http.ResponseWriter, r *http.Request) {
-	db := database.GetDB().WithContext(r.Context())
-	userID := middleware.UserIDFromContext(r.Context())
-
-	idStr := chi.URLParam(r, "id")
-	id64, err := strconv.ParseUint(idStr, 10, 32)
-	if err != nil {
-		utils.RespondError(w, http.StatusBadRequest, "INVALID_ID", "invalid order id", nil)
-		return
-	}
-	orderID := uint(id64)
-
-	var order models.Order
-	if err := db.Where("id = ? AND user_id = ?", orderID, userID).First(&order).Error; err != nil {
-		utils.RespondError(w, http.StatusNotFound, "ORDER_NOT_FOUND", "order not found", nil)
-		return
-	}
-
-	// Retryable source states:
-	//	pending 		- initial attempt mid-flight (pre-PI confirm page)
-	//	requires_action - customer abandoned or failed the 3DS challenge
-	//	failed 			- webhook flipped after a non-recoverable error
-	// terminal states (paid, shipped, delivered, cancelled, refunded) refuse.
-	if order.Status != models.OrderStatusPending &&
-		order.Status != models.OrderStatusRequiresAction &&
-		order.Status != models.OrderStatusFailed {
-		utils.RespondError(w, http.StatusConflict, "INVALID_STATE", "order is already finalized", nil)
-		return
-	}
-	if order.StripePaymentID == "" {
-		utils.RespondError(w, http.StatusConflict, "INVALID_STATE", "order has no payment intent to retry", nil)
-		return
-	}
-
-	// Cap is best-effort: two concurrent retries at issuances=cap-1 will both
-	// pass this check and both Confirm before either writes a new event row.
-	// Per-user RateLimitByUser(10/min) on the route bounds the worst case.
-	// SQLite-WAL has no SELECT ... FOR UPDATE, so a stricter guard would need
-	// a serializing INSERT - not worth the cimplexity at current traffic.
-	var issuances int64
-	if err := db.Model(&models.OrderEvent{}).
-		Where("order_id = ? AND type = ?", order.ID, audit.EventOrderRequiresAction).
-		Count(&issuances).Error; err != nil {
-		utils.RespondError(w, http.StatusInternalServerError, "DATABASE_ERROR", "failed to count auth attempts", nil)
-		return
-	}
-	if issuances >= maxAuthIssuances {
-		middleware.RecordCartConversion("retry_max_attempts")
-		utils.RespondError(w, http.StatusTooManyRequests, "RETRY_LIMIT", "too many authentication attempts, please use a different card", nil)
-		return
-	}
-
-	// scoped card lookup - match the initial-flow policy in ConvertCart so a
-	// card the user deleted (or that the storage-TTL reconciler removed)
-	// cannot be silently re-charged through retry. The ownership clause is
-	// defensive: order.CardID is enforced at SetCard time today but binding
-	// the retry path to that invariant explicitly costs nothing.
-	var card models.Card
-	if err := db.Where("id = ? AND user_id = ?", order.CardID, userID).First(&card).Error; err != nil {
-		utils.RespondError(w, http.StatusConflict, "CARD_NO_LONGER_AVAILABLE", "saved card is no longer available, add it again to retry", nil)
-		return
-	}
-	if card.IsStorageExpired(time.Now()) {
-		if err := expireStoredCard(db, &card); err != nil {
-			utils.RespondError(w, http.StatusInternalServerError, "INTERNAL_ERROR", "failed to expire card", nil)
-			return
-		}
-		respondCardStorageExpired(w)
-		return
-	}
-
-	stripeStart := time.Now()
-	confirmed, cerr := paymentintent.Confirm(order.StripePaymentID, &stripe.PaymentIntentConfirmParams{
-		PaymentMethod: stripe.String(card.StripePaymentID),
-		OffSession:    stripe.Bool(false),
-		ReturnURL:     stripe.String(h.appURL + "/post-3ds"),
-	})
-	stripeDur := time.Since(stripeStart).Seconds()
-	if cerr != nil {
-		middleware.ObserveStripeRequest("payment_intent_confirm", "error", stripeDur)
-		if stripeErr, ok := cerr.(*stripe.Error); ok && stripeErr.Type == stripe.ErrorTypeCard {
-			db.Model(&order).Update("status", models.OrderStatusFailed)
-			audit.OrderFailed(userID, order.ID, order.Total, stripeErr.Msg)
-			middleware.RecordCartConversion("retry_card_declined")
-			utils.RespondError(w, http.StatusPaymentRequired, mapStripeCardErrCode(stripeErr.Code), stripeErr.Msg, nil)
-			return
-		}
-		if stripeErr, ok := cerr.(*stripe.Error); ok && stripeErr.Code == "payment_intent_unexpected_state" {
-			actual, gerr := paymentintent.Get(order.StripePaymentID, nil)
-			if gerr != nil {
-				middleware.RecordCartConversion("retry_stripe_error")
-				utils.RespondError(w, http.StatusBadGateway, "PAYMENT_FAILED", "payment failed", nil)
-				return
-			}
-			switch actual.Status {
-			case stripe.PaymentIntentStatusSucceeded:
-				middleware.RecordCartConversion("retry_race_already_done")
-				utils.RespondSuccess(w, http.StatusAccepted, map[string]any{
-					"order_id": order.ID,
-					"status":   "succeeded",
-				})
-				return
-			case stripe.PaymentIntentStatusCanceled:
-				db.Model(&order).Update("status", models.OrderStatusFailed)
-				audit.OrderFailed(userID, order.ID, order.Total, "payment intent canceled")
-				middleware.RecordCartConversion("retry_pi_canceled")
-				utils.RespondError(w, http.StatusConflict, "INVALID_STATE", "payment intent is canceled, please start a new order", nil)
-				return
-			default:
-				middleware.RecordCartConversion("retry_pi_unexpected_state")
-				utils.RespondError(w, http.StatusBadGateway, "PAYMENT_FAILED", "payment intent in unexpected state", nil)
-				return
-			}
-		}
-
-		middleware.RecordCartConversion("retry_stripe_error")
-		utils.RespondError(w, http.StatusBadGateway, "PAYMENT_FAILED", "payment failed", nil)
-		return
-	}
-	middleware.ObserveStripeRequest("payment_intent_confirm", "success", stripeDur)
-
-	// frictionless 3DS on retry, stripe approved without a new challenge.
-	// the payment_intent.succeeded webhook owns the order.status=paid
-	// transition (matches the initial-flow contract); tell the TUI to keep
-	// polling /orders/{id}/status until it lands
-	if confirmed.Status == stripe.PaymentIntentStatusSucceeded {
-		middleware.RecordCartConversion("retry_frictionless")
-		utils.RespondSuccess(w, http.StatusAccepted, map[string]any{
-			"order_id": order.ID,
-			"status":   "succeeded",
-		})
-		return
-	}
-
-	h.respondRequiresAction(w, &order, card.StripePaymentID, confirmed)
-}

api/handlers/doc.go

@@ -1,3 +0,0 @@
-// Package handlers is where the real work happens, one function per endpoint:
-// carts, orders, products, addresses, cards, webhooks, and the rest.
-package handlers

api/handlers/orders.go

@@ -28,6 +28,7 @@ import (
 )
 
 type OrderHandler struct {
+	stripeKey           string
 	bringAPIUID         string
 	bringAPIKey         string
 	bringCustomerNumber string
@@ -43,10 +44,9 @@ type refundRequestPayload struct {
 // repeated submissions from spamming the operator's Slack channel.
 const refundRequestCooldown = 15 * time.Minute
 
-// NewOrderHandler creates an order handler. Stripe credentials are wired
-// once at startup via stripe.Key in api/main.go.
-func NewOrderHandler(bringAPIUID, bringAPIKey, bringCustomerNumber string) *OrderHandler {
+func NewOrderHandler(stripeSecretKey, bringAPIUID, bringAPIKey, bringCustomerNumber string) *OrderHandler {
 	return &OrderHandler{
+		stripeKey:           stripeSecretKey,
 		bringAPIUID:         bringAPIUID,
 		bringAPIKey:         bringAPIKey,
 		bringCustomerNumber: bringCustomerNumber,
@@ -200,6 +200,8 @@ func (h *OrderHandler) RefundOrder(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	stripe.Key = h.stripeKey
+
 	rf, err := refund.New(&stripe.RefundParams{
 		PaymentIntent: stripe.String(order.StripePaymentID),
 	})
@@ -219,7 +221,7 @@ func (h *OrderHandler) RefundOrder(w http.ResponseWriter, r *http.Request) {
 
 	audit.OrderRefunded(userID, order.ID, order.Total, rf.ID)
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"refund_id": rf.ID,
 		"status":    "refunded",
 	})
@@ -285,7 +287,7 @@ func (h *OrderHandler) UpdateTracking(w http.ResponseWriter, r *http.Request) {
 
 	audit.OrderShipped(order.UserID, order.ID, req.Carrier, req.TrackingNumber)
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"order_id":        order.ID,
 		"carrier":         req.Carrier,
 		"tracking_number": req.TrackingNumber,

api/handlers/orders_test.go

@@ -60,7 +60,7 @@ func contextWithRoute(ctx context.Context, routeCtx *chi.Context) context.Contex
 func TestCreateRefundRequestRequiresMessageForOther(t *testing.T) {
 	user := setupOrderTestDB(t)
 
-	handler := NewOrderHandler("", "", "")
+	handler := NewOrderHandler("", "", "", "")
 	body := []byte(`{"reason":"Other","message":"   "}`)
 	req := orderRequest("POST", "/api/v1/orders/1/refund-request", body, user.ID, "1")
 	w := httptest.NewRecorder()
@@ -100,7 +100,7 @@ func TestCreateRefundRequestRejectsInvalidOrderState(t *testing.T) {
 		t.Fatalf("failed to create order: %v", err)
 	}
 
-	handler := NewOrderHandler("", "", "")
+	handler := NewOrderHandler("", "", "", "")
 	body := []byte(`{"reason":"Quality issue","message":""}`)
 	req := orderRequest("POST", "/api/v1/orders/1/refund-request", body, user.ID, fmt.Sprintf("%d", order.ID))
 	w := httptest.NewRecorder()
@@ -142,7 +142,7 @@ func TestCreateRefundRequestEnforcesCooldown(t *testing.T) {
 		t.Fatalf("failed to create order: %v", err)
 	}
 
-	handler := NewOrderHandler("", "", "")
+	handler := NewOrderHandler("", "", "", "")
 	body := []byte(`{"reason":"Quality issue","message":""}`)
 	req := orderRequest("POST", "/api/v1/orders/1/refund-request", body, user.ID, fmt.Sprintf("%d", order.ID))
 	w := httptest.NewRecorder()

api/handlers/products.go

@@ -30,7 +30,7 @@ func (h *ProductHandler) GetProducts(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"products": products,
 	})
 }
@@ -53,7 +53,7 @@ func (h *ProductHandler) GetProduct(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"product": product,
 	})
 }

api/handlers/reconcile.go

@@ -1,13 +1,10 @@
 package handlers
 
 import (
-	"context"
 	"fmt"
 	"log/slog"
 	"time"
 
-	"terminalShop/api/middleware"
-	"terminalShop/pkg/audit"
 	"terminalShop/pkg/database"
 	"terminalShop/pkg/models"
 	"terminalShop/pkg/notify"
@@ -17,19 +14,15 @@ import (
 	"gorm.io/gorm"
 )
 
-// paymentIntentGetFn lets tests stub the Stripe Get call without spinning
-// up an httptest backend. Production callers go straight through to the
-// real paymentintent.Get.
-var paymentIntentGetFn = paymentintent.Get
-
 func reconcileLog() *slog.Logger { return slog.With("component", "reconcile") }
 
 // ReconcileOrders finds pending orders with no Stripe ID older than 10 minutes
 // and checks whether Stripe has a succeeded PaymentIntent for them. This fixes
 // the case where the server crashed after charging but before the DB transaction
 // completed.
-func ReconcileOrders(ctx context.Context) {
-	db := database.GetDB().WithContext(ctx)
+func ReconcileOrders(stripeKey string) {
+	stripe.Key = stripeKey
+	db := database.GetDB()
 
 	var orders []models.Order
 	cutoff := time.Now().Add(-10 * time.Minute)
@@ -43,14 +36,9 @@ func ReconcileOrders(ctx context.Context) {
 	reconcileLog().Info("checking pending orders", "count", len(orders))
 
 	for _, order := range orders {
-		if err := ctx.Err(); err != nil {
-			reconcileLog().Info("reconcile orders cancelled mid-loop", "error", err)
-			return
-		}
 		params := &stripe.PaymentIntentSearchParams{
 			SearchParams: stripe.SearchParams{
-				Context: ctx,
-				Query:   fmt.Sprintf("metadata['order_id']:'%d' AND status:'succeeded'", order.ID),
+				Query: fmt.Sprintf("metadata['order_id']:'%d' AND status:'succeeded'", order.ID),
 			},
 		}
 
@@ -61,7 +49,7 @@ func ReconcileOrders(ctx context.Context) {
 				"order_id", order.ID, "pi", pi.ID)
 
 			txErr := db.Transaction(func(tx *gorm.DB) error {
-				if err := tx.Model(&order).Updates(map[string]any{
+				if err := tx.Model(&order).Updates(map[string]interface{}{
 					"status":            models.OrderStatusPaid,
 					"stripe_payment_id": pi.ID,
 				}).Error; err != nil {
@@ -74,7 +62,7 @@ func ReconcileOrders(ctx context.Context) {
 				if err := tx.Where("cart_id = ?", cart.ID).Delete(&models.CartItem{}).Error; err != nil {
 					return err
 				}
-				return tx.Model(&cart).Updates(map[string]any{
+				return tx.Model(&cart).Updates(map[string]interface{}{
 					"address_id": nil,
 					"card_id":    nil,
 				}).Error
@@ -89,163 +77,10 @@ func ReconcileOrders(ctx context.Context) {
 	}
 }
 
-// ReconcileStale3DSOrders flips requires_action orders that have been
-// awaiting the customer's 3DS challenge longer than threshold to failed,
-// after re-checking the PaymentIntent with Stripe so a late
-// payment_intent.succeeded webhook is respected. Deliberately separate
-// from ReconcileOrders: the empty-PI predicate there is load-bearing for
-// the crash-mid-create case (see sca-psd2-compliance.md caveat #20).
-// stripe.Key is wired once at startup in api/main.go.
-func ReconcileStale3DSOrders(ctx context.Context, threshold time.Duration) {
-	db := database.GetDB().WithContext(ctx)
-
-	var orders []models.Order
-	// Predicate keys off updated_at, not created_at: respondRequiresAction
-	// and RetryAuth both bump updated_at via GORM auto-stamping, so every
-	// customer-driven retry extends the grace window. Intentional - sweeping
-	// a row the customer just re-armed would race the new challenge.
-	cutoff := time.Now().Add(-threshold)
-	if err := db.Where("status = ? AND updated_at < ?",
-		models.OrderStatusRequiresAction, cutoff).Find(&orders).Error; err != nil {
-		reconcileLog().Error("stale 3ds scan failed", "error", err)
-		return
-	}
-	if len(orders) == 0 {
-		return
-	}
-
-	reconcileLog().Info("checking stale requires_action orders", "count", len(orders))
-
-	piParams := &stripe.PaymentIntentParams{Params: stripe.Params{Context: ctx}}
-	for i := range orders {
-		if err := ctx.Err(); err != nil {
-			reconcileLog().Info("stale 3ds sweep cancelled mid-loop", "error", err)
-			return
-		}
-		order := &orders[i]
-		if order.StripePaymentID == "" {
-			// respondRequiresAction writes stripe_payment_id and status in
-			// one UPDATE so this should be unreachable; guard anyway so a
-			// future regression noisily logs instead of 4xx'ing Stripe.
-			reconcileLog().Warn("requires_action row missing PI id; skipping", "order_id", order.ID)
-			middleware.RecordAbandoned3DSSweep("missing_pi")
-			continue
-		}
-		actual, err := paymentIntentGetFn(order.StripePaymentID, piParams)
-		if err != nil {
-			reconcileLog().Error("stripe get failed",
-				"order_id", order.ID, "pi", order.StripePaymentID, "error", err)
-			middleware.RecordAbandoned3DSSweep("stripe_error")
-			continue
-		}
-		switch actual.Status {
-		case stripe.PaymentIntentStatusSucceeded:
-			// Stripe says paid but our row still says requires_action, the
-			// payment_intent.succeeded webhook has not landed yet (or was
-			//  dropped). Defer to handlePaymentIntentsucceeded; it owns the
-			// paid transition + cart cleanup atomically. The next sweep
-			// tick re-checks and surfaces the dropped webhook if it persists
-			reconcileLog().Warn("stripe reports succeeded for requires_action row; deferring to webhook",
-				"order_id", order.ID, "pi", order.StripePaymentID)
-			middleware.RecordAbandoned3DSSweep("succeeded_skip")
-		case stripe.PaymentIntentStatusProcessing,
-			stripe.PaymentIntentStatusRequiresCapture:
-			reconcileLog().Info("payment intent still transitioning; skipping",
-				"order_id", order.ID, "pi", order.StripePaymentID, "stripe_status", string(actual.Status))
-			middleware.RecordAbandoned3DSSweep("processing_skip")
-		case stripe.PaymentIntentStatusRequiresAction,
-			stripe.PaymentIntentStatusRequiresPaymentMethod,
-			stripe.PaymentIntentStatusRequiresConfirmation,
-			stripe.PaymentIntentStatusCanceled:
-			flipStale3DSToFailed(db, order, string(actual.Status))
-		default:
-			reconcileLog().Warn("unrecognized stripe status; skipping",
-				"order_id", order.ID, "pi", order.StripePaymentID, "stripe_status", string(actual.Status))
-			middleware.RecordAbandoned3DSSweep("unrecognized_status")
-		}
-	}
-}
-
-// flipStale3DSToFailed transitions a single stale requires_action row
-// to failed. The UPDATE is conditional on status = requires_action so a
-// payment_intent.succeeded webhook that landed between the stripe get and
-// this write (caveat #20 race) wins and we silently no-op
-func flipStale3DSToFailed(db *gorm.DB, order *models.Order, stripeStatus string) {
-	// Map form so the single-field UPDATE is explicit at the call site.
-	// GORM still auto-stamps updated_at; the row exits the sweep predicate
-	// naturally on the next tick because status no longer matches anyway.
-	res := db.Model(&models.Order{}).
-		Where("id = ? AND status = ?", order.ID, models.OrderStatusRequiresAction).
-		Updates(map[string]any{"status": models.OrderStatusFailed})
-	if res.Error != nil {
-		reconcileLog().Error("flip stale 3ds failed", "order_id", order.ID, "error", res.Error)
-		middleware.RecordAbandoned3DSSweep("flip_failed")
-		return
-	}
-	if res.RowsAffected == 0 {
-		reconcileLog().Info("stale 3ds row already transitioned; sweep no-op",
-			"order_id", order.ID)
-		middleware.RecordAbandoned3DSSweep("flip_noop")
-		return
-	}
-	audit.Order3DSAbandoned(order.UserID, order.ID, order.StripePaymentID)
-	reconcileLog().Info("3ds abandoned order flipped to failed",
-		"order_id", order.ID, "pi", order.StripePaymentID, "stripe_status", stripeStatus)
-	middleware.RecordAbandoned3DSSweep("flipped")
-}
-
-// ReconcileExpiredCards removes saved cards whose retention deadline elapsed.
-// Read paths filter out expired rows so users never see them; this job drives
-// the Stripe detach + audit + physical row delete out of band so request
-// handlers never block on Stripe API calls during a card sweep.
-func ReconcileExpiredCards(ctx context.Context) {
-	db := database.GetDB().WithContext(ctx)
-
-	var cards []models.Card
-	if err := db.Where(
-		"storage_expires_at IS NOT NULL AND storage_expires_at <= ?",
-		time.Now(),
-	).Find(&cards).Error; err != nil {
-		reconcileLog().Error("expired card scan failed", "error", err)
-		return
-	}
-	if len(cards) == 0 {
-		return
-	}
-
-	reconcileLog().Info("expiring inactive saved cards", "count", len(cards))
-	for i := range cards {
-		if err := ctx.Err(); err != nil {
-			reconcileLog().Info("card sweep cancelled mid-loop", "error", err)
-			return
-		}
-		if err := expireStoredCard(db, &cards[i]); err != nil {
-			reconcileLog().Error("expire card failed", "card_id", cards[i].ID, "error", err)
-		}
-	}
-}
-
-// ReconcilePayRedirects deletes pay_redirects rows whose ExpiresAt had passed.
-// Lazy deletion on read (PayRedirect) is the primary path, this sweep only
-// reclaims tokens nobody ever followed so the table stays bounded.
-func ReconcilePayRedirects(ctx context.Context) {
-	db := database.GetDB().WithContext(ctx)
-
-	res := db.Where("expires_at < ?", time.Now()).Delete(&models.PayRedirect{})
-	if res.Error != nil {
-		reconcileLog().Error("pay_redirects sweep failed", "error", res.Error)
-		return
-	}
-	if res.RowsAffected == 0 {
-		return
-	}
-	reconcileLog().Info("swept expired pay_redirects", "count", res.RowsAffected)
-}
-
-// ReconcileUnshipped finds paid orders older than 24h with no tracking
-// number and posts a single Slack reminder. Pure read + notify.
-func ReconcileUnshipped(ctx context.Context) {
-	db := database.GetDB().WithContext(ctx)
+// ReconcileUnshipped finds paid order orlder than 24h with no tracking
+// number and posts single Slack reminder. Pure read + notif
+func ReconcileUnshipped() {
+	db := database.GetDB()
 
 	var orders []models.Order
 	cutoff := time.Now().Add(-24 * time.Hour)

api/handlers/reconcile_test.go

@@ -1,598 +0,0 @@
-package handlers
-
-import (
-	"context"
-	"fmt"
-	"os"
-	"testing"
-	"time"
-
-	"terminalShop/api/middleware"
-	"terminalShop/pkg/audit"
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-
-	"github.com/prometheus/client_golang/prometheus/testutil"
-	"github.com/stripe/stripe-go/v78"
-)
-
-// TestReconcileStale3DSOrders_FlipsAbandonedToFailed verifies the predicate
-// and Stripe-Get branching: a row past the threshold whose PaymentIntent
-// Stripe still reports as requires_payment_method (the customer never
-// completed the challenge) transitions to failed and emits the new
-// order_3ds_abandoned audit row.
-func TestReconcileStale3DSOrders_FlipsAbandonedToFailed(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_stale_abandoned",
-		time.Now().Add(-1*time.Hour))
-
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatusRequiresPaymentMethod,
-		}, nil
-	}
-
-	flipped := middleware.Abandoned3DSSweepCounter().WithLabelValues("flipped")
-	before := testutil.ToFloat64(flipped)
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload order: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusFailed {
-		t.Fatalf("status: want %q, got %q", models.OrderStatusFailed, reloaded.Status)
-	}
-
-	var events []models.OrderEvent
-	if err := db.Where("order_id = ? AND type = ?",
-		order.ID, audit.EventOrder3DSAbandoned).Find(&events).Error; err != nil {
-		t.Fatalf("list events: %v", err)
-	}
-	if len(events) != 1 {
-		t.Fatalf("want 1 order_3ds_abandoned audit row, got %d", len(events))
-	}
-	if got := testutil.ToFloat64(flipped) - before; got != 1 {
-		t.Fatalf("want 1 flipped sweep counter increment, got %v", got)
-	}
-}
-
-// TestReconcileStale3DSOrders_SkipsRecent verifies the threshold predicate
-// excludes rows still within the grace window. A fresh requires_action row
-// must not even reach the Stripe Get call.
-func TestReconcileStale3DSOrders_SkipsRecent(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_fresh_3ds",
-		time.Now().Add(-5*time.Minute))
-
-	called := false
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		called = true
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatusRequiresPaymentMethod,
-		}, nil
-	}
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	if called {
-		t.Fatalf("stripe Get called for in-window row")
-	}
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusRequiresAction {
-		t.Fatalf("status changed unexpectedly: %q", reloaded.Status)
-	}
-}
-
-// TestReconcileStale3DSOrders_SkipsWhenStripeSaysSucceeded covers the
-// webhook-race guard from caveat #20. If Stripe-side already says succeeded,
-// the sweep must defer to handlePaymentIntentSucceeded rather than overwrite
-// the authoritative end state.
-func TestReconcileStale3DSOrders_SkipsWhenStripeSaysSucceeded(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_succeeded_late_webhook",
-		time.Now().Add(-1*time.Hour))
-
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatusSucceeded,
-		}, nil
-	}
-
-	skip := middleware.Abandoned3DSSweepCounter().WithLabelValues("succeeded_skip")
-	before := testutil.ToFloat64(skip)
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusRequiresAction {
-		t.Fatalf("must defer to webhook on succeeded; got %q", reloaded.Status)
-	}
-	if got := testutil.ToFloat64(skip) - before; got != 1 {
-		t.Fatalf("want 1 succeeded_skip sweep counter increment, got %v", got)
-	}
-}
-
-// TestReconcileStale3DSOrders_GuardsAgainstWebhookRace covers the conditional
-// UPDATE. If the row flipped to paid between the Stripe Get and the flip,
-// the WHERE status = requires_action clause prevents clobber.
-func TestReconcileStale3DSOrders_GuardsAgainstWebhookRace(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_race_paid",
-		time.Now().Add(-1*time.Hour))
-
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		db.Model(&models.Order{}).Where("id = ?", order.ID).
-			Update("status", models.OrderStatusPaid)
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatusRequiresPaymentMethod,
-		}, nil
-	}
-
-	noop := middleware.Abandoned3DSSweepCounter().WithLabelValues("flip_noop")
-	before := testutil.ToFloat64(noop)
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusPaid {
-		t.Fatalf("conditional update must preserve paid; got %q", reloaded.Status)
-	}
-	if got := testutil.ToFloat64(noop) - before; got != 1 {
-		t.Fatalf("want 1 flip_noop sweep counter increment, got %v", got)
-	}
-}
-
-// TestReconcileStale3DSOrders_FlipsCanceledPI covers the canceled-PI branch:
-// Stripe-terminal-canceled maps to OrderStatusFailed (matches RetryAuth's
-// existing precedent — see api/handlers/cart.go RetryAuth canceled branch).
-func TestReconcileStale3DSOrders_FlipsCanceledPI(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_canceled_stale",
-		time.Now().Add(-1*time.Hour))
-
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatusCanceled,
-		}, nil
-	}
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusFailed {
-		t.Fatalf("canceled PI must flip to failed; got %q", reloaded.Status)
-	}
-}
-
-// TestReconcileStale3DSOrders_DoesNotConsumeRetryCap regression-tests the
-// caveat #17 decoupling: the new sweep emits EventOrder3DSAbandoned, never
-// EventOrderRequiresAction, so a swept-then-stuck order does not silently
-// shrink the retry ceiling for any future user-driven retry attempts.
-func TestReconcileStale3DSOrders_DoesNotConsumeRetryCap(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_decoupled_cap",
-		time.Now().Add(-1*time.Hour))
-
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatusRequiresPaymentMethod,
-		}, nil
-	}
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	var retryCount int64
-	if err := db.Model(&models.OrderEvent{}).
-		Where("order_id = ? AND type = ?", order.ID, audit.EventOrderRequiresAction).
-		Count(&retryCount).Error; err != nil {
-		t.Fatalf("count retry events: %v", err)
-	}
-	if retryCount != 0 {
-		t.Fatalf("sweep must not emit EventOrderRequiresAction; got %d", retryCount)
-	}
-}
-
-// TestReconcileStale3DSOrders_SkipsTransitioningStatuses covers the
-// processing and requires_capture branches: Stripe still owns the PI's
-// next move, so the sweep must not flip even past the threshold.
-func TestReconcileStale3DSOrders_SkipsTransitioningStatuses(t *testing.T) {
-	cases := []struct {
-		name   string
-		status stripe.PaymentIntentStatus
-	}{
-		{"processing", stripe.PaymentIntentStatusProcessing},
-		{"requires_capture", stripe.PaymentIntentStatusRequiresCapture},
-	}
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			testDB, user := setupCartTestDB(t)
-			defer func() { _ = os.Remove(testDB) }()
-			defer database.ResetForTesting()
-
-			db := database.GetDB()
-			audit.SetDB(db)
-			defer audit.SetDB(nil)
-
-			order := seedRequiresActionOrder(t, user.ID,
-				"pi_transitioning_"+tc.name, time.Now().Add(-1*time.Hour))
-
-			orig := paymentIntentGetFn
-			defer func() { paymentIntentGetFn = orig }()
-			paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-				return &stripe.PaymentIntent{ID: id, Status: tc.status}, nil
-			}
-
-			skip := middleware.Abandoned3DSSweepCounter().WithLabelValues("processing_skip")
-			before := testutil.ToFloat64(skip)
-
-			ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-			var reloaded models.Order
-			if err := db.First(&reloaded, order.ID).Error; err != nil {
-				t.Fatalf("reload: %v", err)
-			}
-			if reloaded.Status != models.OrderStatusRequiresAction {
-				t.Fatalf("%s must stay requires_action; got %q", tc.name, reloaded.Status)
-			}
-			if got := testutil.ToFloat64(skip) - before; got != 1 {
-				t.Fatalf("want 1 processing_skip increment, got %v", got)
-			}
-		})
-	}
-}
-
-// TestReconcileStale3DSOrders_SkipsUnknownStatus covers the switch's default
-// arm: an unrecognized Stripe status logs and skips rather than guessing a
-// transition. Defends against new PI statuses appearing in future SDKs.
-func TestReconcileStale3DSOrders_SkipsUnknownStatus(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_unknown_status",
-		time.Now().Add(-1*time.Hour))
-
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatus("some_new_future_status"),
-		}, nil
-	}
-
-	unknown := middleware.Abandoned3DSSweepCounter().WithLabelValues("unrecognized_status")
-	before := testutil.ToFloat64(unknown)
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusRequiresAction {
-		t.Fatalf("unknown status must not flip; got %q", reloaded.Status)
-	}
-	if got := testutil.ToFloat64(unknown) - before; got != 1 {
-		t.Fatalf("want 1 unrecognized_status increment, got %v", got)
-	}
-}
-
-// TestReconcileStale3DSOrders_SkipsOnStripeError verifies a Stripe Get
-// failure logs and leaves the row alone. Transient network errors must not
-// look like an abandoned 3DS.
-func TestReconcileStale3DSOrders_SkipsOnStripeError(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_stripe_error",
-		time.Now().Add(-1*time.Hour))
-
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(_ string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		return nil, fmt.Errorf("simulated stripe outage")
-	}
-
-	stripeErr := middleware.Abandoned3DSSweepCounter().WithLabelValues("stripe_error")
-	before := testutil.ToFloat64(stripeErr)
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusRequiresAction {
-		t.Fatalf("stripe error must not flip; got %q", reloaded.Status)
-	}
-	if got := testutil.ToFloat64(stripeErr) - before; got != 1 {
-		t.Fatalf("want 1 stripe_error sweep counter increment, got %v", got)
-	}
-}
-
-// TestReconcileStale3DSOrders_SkipsEmptyPaymentIntentID guards the
-// defensive empty-PI short-circuit: even past the threshold, a row missing
-// stripe_payment_id must not reach paymentintent.Get (which would 4xx).
-func TestReconcileStale3DSOrders_SkipsEmptyPaymentIntentID(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	order := seedRequiresActionOrder(t, user.ID, "pi_will_be_blanked",
-		time.Now().Add(-1*time.Hour))
-	if err := db.Model(&order).UpdateColumn("stripe_payment_id", "").Error; err != nil {
-		t.Fatalf("blank PI id: %v", err)
-	}
-
-	called := false
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(_ string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		called = true
-		return &stripe.PaymentIntent{Status: stripe.PaymentIntentStatusRequiresPaymentMethod}, nil
-	}
-
-	missing := middleware.Abandoned3DSSweepCounter().WithLabelValues("missing_pi")
-	before := testutil.ToFloat64(missing)
-
-	ReconcileStale3DSOrders(context.Background(), 30*time.Minute)
-
-	if called {
-		t.Fatalf("stripe Get called for empty-PI row")
-	}
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusRequiresAction {
-		t.Fatalf("empty-PI guard must leave status alone; got %q", reloaded.Status)
-	}
-	if got := testutil.ToFloat64(missing) - before; got != 1 {
-		t.Fatalf("want 1 missing_pi increment, got %v", got)
-	}
-}
-
-// TestReconcileStale3DSOrders_BailsMidLoopOnCancel verifies the per-iteration
-// ctx.Err() check stops the sweep once the supervising context cancels, so a
-// SIGTERM during a large stale-3DS batch does not block the binary past the
-// 30s graceful-shutdown window in api/main.go
-func TestReconcileStale3DSOrders_BailsMidLoopOnCancel(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	audit.SetDB(db)
-	defer audit.SetDB(nil)
-
-	seedRequiresActionOrder(t, user.ID, "pi_first", time.Now().Add(-1*time.Hour))
-	seedRequiresActionOrder(t, user.ID, "pi_second", time.Now().Add(-1*time.Hour))
-
-	ctx, cancel := context.WithCancel(context.Background())
-	defer cancel()
-
-	calls := 0
-	orig := paymentIntentGetFn
-	defer func() { paymentIntentGetFn = orig }()
-	paymentIntentGetFn = func(id string, _ *stripe.PaymentIntentParams) (*stripe.PaymentIntent, error) {
-		calls++
-		if calls == 1 {
-			cancel()
-		}
-		return &stripe.PaymentIntent{
-			ID:     id,
-			Status: stripe.PaymentIntentStatusRequiresPaymentMethod,
-		}, nil
-	}
-	ReconcileStale3DSOrders(ctx, 30*time.Minute)
-
-	if calls != 1 {
-		t.Fatalf("want exactly 1 stripe Get call (loop bails before row 2); got %d", calls)
-	}
-	var stillPending int64
-	if err := db.Model(&models.Order{}).Where("status = ?", models.OrderStatusRequiresAction).Count(&stillPending).Error; err != nil {
-		t.Fatalf("count requires_action rows: %v", err)
-	}
-	if stillPending < 1 {
-		t.Fatalf("want at least 1 row left in requires_action after mid-loop cancel; got %d", stillPending)
-	}
-}
-
-// seedRequiresActionOrder inserts a card + order pair in the requires_action
-// state. updatedAt is forced via UpdateColumn so GORM's auto-stamping of
-// UpdatedAt on Create does not bump the row out of the sweep predicate.
-func seedRequiresActionOrder(t *testing.T, userID uint, piID string, updatedAt time.Time) models.Order {
-	t.Helper()
-	db := database.GetDB()
-	card := models.Card{
-		UserID:          userID,
-		StripePaymentID: "pm_test_" + piID,
-		Last4:           "4242", Brand: "Visa",
-		ExpMonth: 12, ExpYear: 2030,
-	}
-	if err := db.Create(&card).Error; err != nil {
-		t.Fatalf("seed card: %v", err)
-	}
-	order := models.Order{
-		UserID: userID, CardID: card.ID,
-		StripePaymentID: piID,
-		Status:          models.OrderStatusRequiresAction,
-		Subtotal:        500, Total: 500,
-		ShippingName: "Test", ShippingStreet: "1 Main St",
-		ShippingCity: "PDX", ShippingState: "OR",
-		ShippingZip: "97201", ShippingCountry: "US",
-	}
-	if err := db.Create(&order).Error; err != nil {
-		t.Fatalf("seed order: %v", err)
-	}
-	if err := db.Model(&order).UpdateColumn("updated_at", updatedAt).Error; err != nil {
-		t.Fatalf("backdate updated_at: %v", err)
-	}
-	return order
-}
-
-// TestReconcilePayRedirects_DeleteExpiredKeepsLive verifies the predicate
-// boundary: a row past ExpiresAt is hard-deleted while a row whose ExpiresAt
-// is still in the future survives. Seeding both sides through GORM keeps the
-// stored timestamp format identical to the one the sweep binds for time.Now(),
-// so the comparison is exercised exactly as it runs in production.
-func TestReconcilePayRedirects_DeleteExpiredKeepsLive(t *testing.T) {
-	testDB := setupTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-
-	now := time.Now()
-	expired := models.PayRedirect{
-		Token:     "tok_expired",
-		URL:       "https://example.test/expired",
-		Purpose:   models.RedirectPurposeCheckout3DS,
-		CreatedAt: now.Add(-20 * time.Minute),
-		ExpiresAt: now.Add(-10 * time.Minute),
-	}
-
-	live := models.PayRedirect{
-		Token:     "tok_live",
-		URL:       "https://example.test/live",
-		Purpose:   models.RedirectPurposeAddCard,
-		CreatedAt: now,
-		ExpiresAt: now.Add(10 * time.Minute),
-	}
-	if err := db.Create(&expired).Error; err != nil {
-		t.Fatalf("seed expired: %v", err)
-	}
-	if err := db.Create(&live).Error; err != nil {
-		t.Fatalf("seed live: %v", err)
-	}
-
-	ReconcilePayRedirects(context.Background())
-
-	var remaining []models.PayRedirect
-	if err := db.Find(&remaining).Error; err != nil {
-		t.Fatalf("list remaining: %v", err)
-	}
-	if len(remaining) != 1 {
-		t.Fatalf("want 1 row remaining, got %d", len(remaining))
-	}
-	if remaining[0].Token != "tok_live" {
-		t.Fatalf("wrong row survived: want tok_live, got %q", remaining[0].Token)
-	}
-}
-
-func TestReconcilePayRedirects_NoExpiredIsNoOp(t *testing.T) {
-	testDB := setupTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-
-	live := models.PayRedirect{
-		Token:     "tok_live_only",
-		URL:       "https://example.test/live",
-		Purpose:   models.RedirectPurposeCheckout3DS,
-		CreatedAt: time.Now(),
-		ExpiresAt: time.Now().Add(10 * time.Minute),
-	}
-	if err := db.Create(&live).Error; err != nil {
-		t.Fatalf("seed live: %v", err)
-	}
-
-	ReconcilePayRedirects(context.Background())
-
-	var count int64
-	if err := db.Model(&models.PayRedirect{}).Count(&count).Error; err != nil {
-		t.Fatalf("count: %v", err)
-	}
-	if count != 1 {
-		t.Fatalf("want 1 row preserved, got %d", count)
-	}
-}

api/handlers/view.go

@@ -2,7 +2,6 @@ package handlers
 
 import (
 	"net/http"
-	"time"
 
 	"terminalShop/api/middleware"
 	"terminalShop/pkg/database"
@@ -12,7 +11,6 @@ import (
 	"gorm.io/gorm"
 )
 
-// ViewHandler handles bulk TUI bootstrap data
 type ViewHandler struct{}
 
 func NewViewHandler() *ViewHandler {
@@ -39,10 +37,7 @@ func (h *ViewHandler) GetViewInit(w http.ResponseWriter, r *http.Request) {
 	db.Where("user_id = ?", userID).Find(&addresses)
 
 	var cards []models.Card
-	db.Where(
-		"user_id = ? AND (storage_expires_at IS NULL OR storage_expires_at > ?)",
-		userID, time.Now(),
-	).Order("is_default DESC, created_at DESC").Find(&cards)
+	db.Where("user_id = ?", userID).Find(&cards)
 
 	var orders []models.Order
 	db.Where("user_id = ?", userID).
@@ -54,7 +49,7 @@ func (h *ViewHandler) GetViewInit(w http.ResponseWriter, r *http.Request) {
 		db.Where("cart_id = ? AND quantity > 0", cart.ID).Preload("Coffee").Find(&cartItems)
 	}
 
-	utils.RespondSuccess(w, http.StatusOK, map[string]any{
+	utils.RespondSuccess(w, http.StatusOK, map[string]interface{}{
 		"user":      user.ToPublic(),
 		"products":  products,
 		"cart":      cartItems,

api/handlers/view_test.go

@@ -1,70 +0,0 @@
-package handlers
-
-import (
-	"encoding/json"
-	"net/http"
-	"net/http/httptest"
-	"os"
-	"testing"
-	"time"
-
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-)
-
-// TestGetViewInit_FiltersExpiredCardsAndOrders drives the WHERE + ORDER BY
-// clauses in GetViewInit. a column-name typo in either clause (e.g.
-// id_default instead of is_default) surfaces here as a sqlite error
-func TestGetViewInit_FiltersExpiredCardsAndOrders(t *testing.T) {
-	testDB, user := setupCardsExpireTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	db := database.GetDB()
-	now := time.Now()
-	past := now.Add(-1 * time.Hour)
-	future := now.Add((24 * time.Hour))
-
-	expired := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_expired", Last4: "1111",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &past,
-	}
-	freshDefault := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_fresh_d", Last4: "2222",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &future,
-		IsDefault: true,
-	}
-	freshOther := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_fresh_o", Last4: "3333",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &future,
-	}
-	for _, card := range []*models.Card{&expired, &freshDefault, &freshOther} {
-		if err := db.Create(card).Error; err != nil {
-			t.Fatalf("seed card: %v", err)
-		}
-	}
-
-	handler := NewViewHandler()
-	req := authRequest("GET", "/api/v1/view/init", nil, user.ID)
-	w := httptest.NewRecorder()
-	handler.GetViewInit(w, req)
-
-	if w.Code != http.StatusOK {
-		t.Fatalf("GetViewInit status %d, body: %s", w.Code, w.Body.String())
-	}
-
-	var resp struct {
-		Data struct {
-			Cards []models.Card `json:"cards"`
-		} `json:"data"`
-	}
-	if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
-		t.Fatalf("decode: %v", err)
-	}
-	if len(resp.Data.Cards) != 2 {
-		t.Fatalf("want 2 visible cards, got %d", len(resp.Data.Cards))
-	}
-	if resp.Data.Cards[0].ID != freshDefault.ID {
-		t.Fatalf("default card should sort first, got id=%d (want %d)", resp.Data.Cards[0].ID, freshDefault.ID)
-	}
-}

api/handlers/webhook.go

@@ -7,7 +7,6 @@ import (
 	"io"
 	"log/slog"
 	"net/http"
-	"os"
 	"strings"
 	"time"
 
@@ -29,13 +28,13 @@ func webhookLog() *slog.Logger { return slog.With("component", "webhook") }
 // WebhookHandler handles inbound Stripe webhook events.
 type WebhookHandler struct {
 	webhookSecret string
+	stripeKey     string
 	shippoSecret  string
 }
 
-// NewWebhookHandler creates a new webhook handler. Stripe credentials are
-// wired once at startup via stripe.Key in api/main.go.
-func NewWebhookHandler(webhookSecret, shippoSecret string) *WebhookHandler {
-	return &WebhookHandler{webhookSecret: webhookSecret, shippoSecret: shippoSecret}
+// NewWebhookHandler creates a new webhook handler.
+func NewWebhookHandler(webhookSecret, stripeKey, shippoSecret string) *WebhookHandler {
+	return &WebhookHandler{webhookSecret: webhookSecret, stripeKey: stripeKey, shippoSecret: shippoSecret}
 }
 
 // HandleStripe validates the Stripe signature and routes the event.
@@ -53,17 +52,8 @@ func (h *WebhookHandler) HandleStripe(w http.ResponseWriter, r *http.Request) {
 
 	// Verify the Stripe signature. Reject anything that doesn't match.
 	if h.webhookSecret == "" {
-		// Fail closed in production. config.validate() requires STRIPE_WEBHOOK_SECRET
-		// in production, so the server should never boot into this state; this is
-		// defense in depth against a misconfigured deploy. Mirrors the Shippo and
-		// Slack handlers, which already refuse to run without their secret.
-		if os.Getenv("ENVIRONMENT") == "production" {
-			webhookLog().Error("stripe webhook secret not set in production; refusing to process event")
-			utils.RespondError(w, http.StatusServiceUnavailable, "WEBHOOK_NOT_CONFIGURED", "webhook verification not configured", nil)
-			return
-		}
-		// Development only; warn loudly but still process so local testing works.
-		webhookLog().Warn("stripe webhook secret not set; skipping signature verification (development only)")
+		// No secret configured — log a loud warning but still process in dev.
+		webhookLog().Warn("stripe webhook secret not set; skipping signature verification")
 	} else {
 		sig := r.Header.Get("Stripe-Signature")
 		if _, err := webhook.ConstructEventWithOptions(body, sig, h.webhookSecret, webhook.ConstructEventOptions{
@@ -134,22 +124,8 @@ func (h *WebhookHandler) handlePaymentIntentSucceeded(ctx context.Context, event
 		return
 	}
 
-	// Defense in depth: even behind a valid signature, refuse to mark an order
-	// paid unless the PaymentIntent's amount and currency match what we charged.
-	// Under ConvertCart these always match (Amount == order.Total at creation), so
-	// a mismatch means a malformed or unexpected event we should not trust.
-	if pi.Amount != int64(order.Total) {
-		webhookLog().Error("payment intent amount mismatch; refusing to mark paid", "order_id", orderIDStr, "pi", pi.ID, "pi_amount", pi.Amount, "order_total", order.Total)
-		return
-	}
-	if pi.Currency != "" && pi.Currency != stripe.CurrencyUSD {
-		webhookLog().Error("payment intent currency mismatch; refusing to mark paid",
-			"order_id", orderIDStr, "pi", pi.ID, "currency", string(pi.Currency))
-		return
-	}
-
 	txErr := db.Transaction(func(tx *gorm.DB) error {
-		if err := tx.Model(&order).Updates(map[string]any{
+		if err := tx.Model(&order).Updates(map[string]interface{}{
 			"status":            models.OrderStatusPaid,
 			"stripe_payment_id": pi.ID,
 		}).Error; err != nil {
@@ -163,7 +139,7 @@ func (h *WebhookHandler) handlePaymentIntentSucceeded(ctx context.Context, event
 		if err := tx.Where("cart_id = ?", cart.ID).Delete(&models.CartItem{}).Error; err != nil {
 			return fmt.Errorf("failed to delete cart item: %w", err)
 		}
-		return tx.Model(&cart).Updates(map[string]any{
+		return tx.Model(&cart).Updates(map[string]interface{}{
 			"address_id": nil,
 			"card_id":    nil,
 		}).Error
@@ -174,12 +150,6 @@ func (h *WebhookHandler) handlePaymentIntentSucceeded(ctx context.Context, event
 		return
 	}
 
-	if order.CardID != 0 {
-		if err := refreshCardStorageTTL(db, order.CardID, time.Now()); err != nil {
-			webhookLog().Warn("failed to refresh card storage ttl", "card_id", order.CardID, "error", err)
-		}
-	}
-
 	audit.OrderPaid(order.UserID, order.ID, int(pi.Amount), pi.ID)
 	go notify.SlackOrderPaid(&order)
 	webhookLog().Info("order marked paid", "order_id", orderIDStr, "pi", pi.ID)
@@ -197,18 +167,8 @@ func (h *WebhookHandler) handlePaymentIntentFailed(ctx context.Context, event st
 		return
 	}
 
-	// authentication_required is recoverable — the cart handler re-confirms the
-	// PI on-session and the customer completes 3DS via redirect. Marking the
-	// order failed here would race with the recovery path and surface a
-	// momentarily-broken state in the TUI.
-	if pi.LastPaymentError != nil && string(pi.LastPaymentError.Code) == "authentication_required" {
-		webhookLog().Info("ignoring authentication_required payment_failed; handled via 3ds redirect",
-			"order_id", orderIDStr, "pi", pi.ID)
-		return
-	}
-
 	db := database.GetDB().WithContext(ctx)
-	if err := db.Model(&models.Order{}).Where("id = ? AND status IN (?, ?)", orderIDStr, models.OrderStatusPending, models.OrderStatusRequiresAction).
+	if err := db.Model(&models.Order{}).Where("id = ? AND status = ?", orderIDStr, models.OrderStatusPending).
 		Update("status", models.OrderStatusFailed).Error; err != nil {
 		webhookLog().Error("failed to mark order failed", "order_id", orderIDStr, "error", err)
 	}
@@ -236,6 +196,8 @@ func (h *WebhookHandler) handleCheckoutSessionCompleted(ctx context.Context, eve
 		return
 	}
 
+	stripe.Key = h.stripeKey
+
 	si, err := setupintent.Get(sess.SetupIntent.ID, nil)
 	if err != nil {
 		webhookLog().Error("failed to get setup intent", "setup_intent", sess.SetupIntent.ID, "error", err)
@@ -283,14 +245,8 @@ func (h *WebhookHandler) handleCheckoutSessionCompleted(ctx context.Context, eve
 				webhookLog().Warn("failed to detach duplicate pm", "user_id", user.ID, "error", derr)
 			}
 			// Bump UpdatedAt so the TUI poll signal can detect that the webhook
-			// fired even though no new row was inserted. storage_expires_at is
-			// reset because the user just re-added the card; this is a card-add
-			// path, not a payment-success refresh, so last_used_at stays as-is.
-			now := time.Now()
-			if uerr := db.Model(&dup).Updates(map[string]any{
-				"updated_at":         now,
-				"storage_expires_at": models.CardStorageExpiresAt(now),
-			}).Error; uerr != nil {
+			// fired even though no new row was inserted.
+			if uerr := db.Model(&dup).Update("updated_at", time.Now()).Error; uerr != nil {
 				webhookLog().Warn("failed to bump dup card updated_at", "card_id", dup.ID, "error", uerr)
 			}
 			webhookLog().Info("skipped duplicate card via local-db match", "user_id", user.ID, "existing_card_id", dup.ID)
@@ -306,7 +262,6 @@ func (h *WebhookHandler) handleCheckoutSessionCompleted(ctx context.Context, eve
 		ExpMonth:        int(pm.Card.ExpMonth),
 		ExpYear:         int(pm.Card.ExpYear),
 	}
-	card.InitializeStorageTTL(time.Now())
 
 	if err := db.Create(&card).Error; err != nil {
 		webhookLog().Error("failed to save card", "user_id", user.ID, "error", err)

api/handlers/webhook_test.go

@@ -1,259 +0,0 @@
-package handlers
-
-import (
-	"context"
-	"encoding/json"
-	"fmt"
-	"os"
-	"testing"
-
-	"github.com/stripe/stripe-go/v78"
-
-	"terminalShop/pkg/database"
-	"terminalShop/pkg/models"
-)
-
-// buildPaymentFailedEvent constructs a stripe.Event whose Data.Raw decodes to
-// a PaymentIntent referencing the given order via metadata. errCode is set on
-// last_payment_error to drive the authentication_required short-circuit
-// branch in handlePaymentIntentFailed (pass "" to omit the error block).
-func buildPaymentFailedEvent(t *testing.T, piID string, orderID uint, errCode string) stripe.Event {
-	t.Helper()
-	pi := map[string]any{
-		"id":       piID,
-		"metadata": map[string]string{"order_id": fmt.Sprintf("%d", orderID)},
-	}
-	if errCode != "" {
-		pi["last_payment_error"] = map[string]any{"code": errCode}
-	}
-	raw, err := json.Marshal(pi)
-	if err != nil {
-		t.Fatalf("marshal pi: %v", err)
-	}
-	return stripe.Event{
-		Type: "payment_intent.payment_failed",
-		Data: &stripe.EventData{Raw: raw},
-	}
-}
-
-func seedOrderForWebhook(t *testing.T, userID uint, status models.OrderStatus, piID string) models.Order {
-	t.Helper()
-	db := database.GetDB()
-	card := models.Card{
-		UserID:          userID,
-		StripePaymentID: fmt.Sprintf("pm_test_%s", piID),
-		Last4:           "4242", Brand: "Visa", ExpMonth: 12, ExpYear: 2030,
-	}
-	if err := db.Create(&card).Error; err != nil {
-		t.Fatalf("seed card: %v", err)
-	}
-	order := models.Order{
-		UserID: userID, CardID: card.ID,
-		StripePaymentID: piID,
-		Status:          status,
-		Subtotal:        500, Total: 500,
-		ShippingName: "Test", ShippingStreet: "1 Main St",
-		ShippingCity: "PDX", ShippingState: "OR",
-		ShippingZip: "97201", ShippingCountry: "US",
-	}
-	if err := db.Create(&order).Error; err != nil {
-		t.Fatalf("seed order: %v", err)
-	}
-	return order
-}
-
-// TestHandlePaymentIntentFailed_RequiresActionFlipsToFailed verifies the
-// widened predicate (IN (pending, requires_action)) catches a row in the new
-// requires_action state. Without this case, a card_declined webhook arriving
-// after respondRequiresAction wrote requires_action would leave the row
-// stuck forever.
-func TestHandlePaymentIntentFailed_RequiresActionFlipsToFailed(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	order := seedOrderForWebhook(t, user.ID, models.OrderStatusRequiresAction, "pi_test_req_action_failed")
-
-	h := NewWebhookHandler("", "")
-	evt := buildPaymentFailedEvent(t, order.StripePaymentID, order.ID, "card_declined")
-	h.handlePaymentIntentFailed(context.Background(), evt)
-
-	db := database.GetDB()
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload order: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusFailed {
-		t.Fatalf("status: want %q, got %q", models.OrderStatusFailed, reloaded.Status)
-	}
-}
-
-// TestHandlePaymentIntentFailed_RequiresActionAuthRequiredShortCircuits
-// verifies the existing short-circuit (note #3 in sca-psd2-compliance.md)
-// still fires when the row is in requires_action and the error code is
-// authentication_required. Without the short-circuit, the recovery flow
-// would race the webhook and surface a momentarily-failed state to the TUI.
-func TestHandlePaymentIntentFailed_RequiresActionAuthRequiredShortCircuits(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	order := seedOrderForWebhook(t, user.ID, models.OrderStatusRequiresAction, "pi_test_req_action_authreq")
-
-	h := NewWebhookHandler("", "")
-	evt := buildPaymentFailedEvent(t, order.StripePaymentID, order.ID, "authentication_required")
-	h.handlePaymentIntentFailed(context.Background(), evt)
-
-	db := database.GetDB()
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload order: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusRequiresAction {
-		t.Fatalf("auth_required must not flip requires_action; got %q", reloaded.Status)
-	}
-}
-
-// TestHandlePaymentIntentFailed_PendingStillFlips guards the pre-existing
-// pending -> failed transition against a regression where the widened
-// predicate accidentally dropped pending from the source set.
-func TestHandlePaymentIntentFailed_PendingStillFlips(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	order := seedOrderForWebhook(t, user.ID, models.OrderStatusPending, "pi_test_pending_failed")
-
-	h := NewWebhookHandler("", "")
-	evt := buildPaymentFailedEvent(t, order.StripePaymentID, order.ID, "card_declined")
-	h.handlePaymentIntentFailed(context.Background(), evt)
-
-	db := database.GetDB()
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload order: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusFailed {
-		t.Fatalf("status: want %q, got %q", models.OrderStatusFailed, reloaded.Status)
-	}
-}
-
-// TestHandlePaymentIntentFailed_PaidNotTouched locks the upper boundary of
-// the predicate: a paid row must NEVER be flipped to failed by a stale
-// payment_failed webhook. Without this guard, a future maintainer could
-// widen the IN clause to include paid (e.g. for some refund-retry flow)
-// and silently break idempotency.
-func TestHandlePaymentIntentFailed_PaidNotTouched(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	order := seedOrderForWebhook(t, user.ID, models.OrderStatusPaid, "pi_test_paid_untouched")
-
-	h := NewWebhookHandler("", "")
-	evt := buildPaymentFailedEvent(t, order.StripePaymentID, order.ID, "card_declined")
-	h.handlePaymentIntentFailed(context.Background(), evt)
-
-	db := database.GetDB()
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload order: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusPaid {
-		t.Fatalf("paid order was modified by payment_failed webhook: got %q", reloaded.Status)
-	}
-}
-
-// TestHandlePaymentIntentFailed_MissingMetadataNoOp covers the no-order
-// short-circuit so the test file exercises every early-return branch in
-// handlePaymentIntentFailed touched by the predicate work.
-func TestHandlePaymentIntentFailed_MissingMetadataNoOp(t *testing.T) {
-	testDB, _ := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	pi := map[string]any{"id": "pi_test_no_meta"}
-	raw, err := json.Marshal(pi)
-	if err != nil {
-		t.Fatalf("marshal pi: %v", err)
-	}
-	evt := stripe.Event{
-		Type: "payment_intent.payment_failed",
-		Data: &stripe.EventData{Raw: raw},
-	}
-
-	h := NewWebhookHandler("", "")
-	h.handlePaymentIntentFailed(context.Background(), evt) // must not panic
-}
-
-func TestHandlePaymentIntentSucceeded_RequiresActionFlipsToPaid(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	order := seedOrderForWebhook(t, user.ID, models.OrderStatusRequiresAction, "pi_test_req_action_paid")
-
-	pi := map[string]any{
-		"id":       order.StripePaymentID,
-		"amount":   order.Total,
-		"metadata": map[string]string{"order_id": fmt.Sprintf("%d", order.ID)},
-	}
-	raw, err := json.Marshal(pi)
-	if err != nil {
-		t.Fatalf("marshal pi: %v", err)
-	}
-	evt := stripe.Event{
-		Type: "payment_intent.succeeded",
-		Data: &stripe.EventData{Raw: raw},
-	}
-
-	h := NewWebhookHandler("", "")
-	h.handlePaymentIntentSucceeded(context.Background(), evt)
-
-	db := database.GetDB()
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reload order: %v", err)
-	}
-	if reloaded.Status != models.OrderStatusPaid {
-		t.Fatalf("status: want %q, got %q", models.OrderStatusPaid, reloaded.Status)
-	}
-	if reloaded.StripePaymentID != order.StripePaymentID {
-		t.Fatalf("stripe_payment_id: want %q, got %q", order.StripePaymentID, reloaded.StripePaymentID)
-	}
-}
-
-func TestHandlePaymentIntentSucceeded_AmountMismatchDoesNotPay(t *testing.T) {
-	testDB, user := setupCartTestDB(t)
-	defer func() { _ = os.Remove(testDB) }()
-	defer database.ResetForTesting()
-
-	order := seedOrderForWebhook(t, user.ID, models.OrderStatusRequiresAction, "pi_test_amount_mismatch")
-
-	// PI claims 1 cent; seed order.Total is 500.
-	pi := map[string]any{
-		"id":       order.StripePaymentID,
-		"amount":   1,
-		"metadata": map[string]string{"order_id": fmt.Sprintf("%d", order.ID)},
-	}
-	raw, err := json.Marshal(pi)
-	if err != nil {
-		t.Fatalf("marshal pi: %v", err)
-	}
-	evt := stripe.Event{
-		Type: "payment_intent.succeeded",
-		Data: &stripe.EventData{Raw: raw},
-	}
-
-	h := NewWebhookHandler("", "")
-	h.handlePaymentIntentSucceeded(context.Background(), evt)
-
-	db := database.GetDB()
-	var reloaded models.Order
-	if err := db.First(&reloaded, order.ID).Error; err != nil {
-		t.Fatalf("reloaded order: %v", err)
-	}
-	if reloaded.Status == models.OrderStatusPaid {
-		t.Fatalf("order marked paid despite amount mismatch")
-	}
-}

api/main.go

@@ -19,31 +19,10 @@ import (
 	"terminalShop/pkg/database"
 	"terminalShop/pkg/observability"
 	"terminalShop/pkg/stripeclient"
-
-	"github.com/stripe/stripe-go/v78"
 )
 
 const version = "v0.1.0"
 
-// everyTick runs fn on its own goroutine every d until ctx is cancelled.
-// Shared by the reconciler sweeps so the ticker + shutdown plumbing lives in
-// one place. ReconcileUnshipped intentionally does not use it, it needs a
-// staggered warm-up run before its first tick.
-func everyTick(ctx context.Context, d time.Duration, fn func(context.Context)) {
-	go func() {
-		ticker := time.NewTicker(d)
-		defer ticker.Stop()
-		for {
-			select {
-			case <-ticker.C:
-				fn(ctx)
-			case <-ctx.Done():
-				return
-			}
-		}
-	}()
-}
-
 func main() {
 	observability.InitLogger()
 	middleware.SetBuildInfo(version)
@@ -70,12 +49,6 @@ func main() {
 	}
 	audit.SetDB(db)
 
-	// wire the stripe SDK's package-level key once at startup so concurrent
-	// reconcilers and the request path don't race on stripe.Key writes.
-	// NOTE: assumes single-process — if you ever embed both the SSH and API
-	// binaries together, the last writer wins and one of them silently breaks.
-	stripe.Key = cfg.StripeSecretKey
-
 	// Seed database with initial data
 	if err := database.Seed(db); err != nil {
 		log.Fatalf("Failed to seed database: %v", err)
@@ -98,7 +71,7 @@ func main() {
 	jwtManager := auth.NewJWTManager(cfg.JWTSecret, 30*time.Minute)
 
 	// Setup routes
-	router := routes.SetupRoutes(version, cfg.StripeWebhookSecret, jwtManager, cfg.AuthFingerprintKey, cfg.ShippoAPIKey, cfg.BringAPIUID, cfg.BringAPIKey, cfg.BringCustomerNumber, cfg.ShippoWebhookSecret, cfg.AppURL, cfg.SlackSigningSecret, cfg.AdminAPIKey, cfg.APIPort, cfg.MaxOrderCents)
+	router := routes.SetupRoutes(version, cfg.StripeSecretKey, cfg.StripeWebhookSecret, jwtManager, cfg.AuthFingerprintKey, cfg.ShippoAPIKey, cfg.BringAPIUID, cfg.BringAPIKey, cfg.BringCustomerNumber, cfg.ShippoWebhookSecret, cfg.AppURL, cfg.SlackSigningSecret, cfg.AdminAPIKey, cfg.APIPort)
 
 	// Create HTTP server
 	server := &http.Server{
@@ -125,42 +98,35 @@ func main() {
 		}
 	}()
 
-	// Catch orders charged but not recorded due to a crash. Every 5 minutes
-	everyTick(ctx, 5*time.Minute, handlers.ReconcileOrders)
-
+	// Start reconciliation job. runs every 5 minutes to catch any orders
+	// that were charged but not recorded due to a crash.
 	go func() {
-		select {
-		case <-time.After(30 * time.Second):
-		case <-ctx.Done():
-			return
-		}
-		handlers.ReconcileUnshipped(ctx)
-		ticker := time.NewTicker(24 * time.Hour)
+		ticker := time.NewTicker(5 * time.Minute)
 		defer ticker.Stop()
 		for {
 			select {
 			case <-ticker.C:
-				handlers.ReconcileUnshipped(ctx)
+				handlers.ReconcileOrders(cfg.StripeSecretKey)
 			case <-ctx.Done():
 				return
 			}
 		}
 	}()
 
-	// Sweep saved cards whose retention deadline elapsed. Read paths filter
-	// expired rows from query results, so this sweeper only drives the Stripe
-	// detach + audit + physical row delete asynchronously. Hourly.
-	everyTick(ctx, 1*time.Hour, handlers.ReconcileExpiredCards)
-
-	// Flip abandoned 3DS orders to failed. Every 15 minutes.
-	threshold := time.Duration(cfg.Abandoned3DSThresholdMinutes) * time.Minute
-	everyTick(ctx, 15*time.Minute, func(ctx context.Context) {
-		handlers.ReconcileStale3DSOrders(ctx, threshold)
-	})
-
-	// Sweep expired pay_redirects rows so the table stays bounded. Lazy delete
-	// on read is the primary path; this only reclaims tokens nobody follows.
-	everyTick(ctx, 10*time.Minute, handlers.ReconcilePayRedirects)
+	go func() {
+		time.Sleep(30 * time.Second)
+		handlers.ReconcileUnshipped()
+		ticker := time.NewTicker(24 * time.Hour)
+		defer ticker.Stop()
+		for {
+			select {
+			case <-ticker.C:
+				handlers.ReconcileUnshipped()
+			case <-ctx.Done():
+				return
+			}
+		}
+	}()
 
 	log.Println("API server started. Press Ctrl+C to shutdown.")
 
@@ -170,10 +136,10 @@ func main() {
 	log.Println("Server is shutting down...")
 
 	// Graceful shutdown with 30 second timeout
-	shutdownCtx, shutdownCancel := context.WithTimeout(context.Background(), 30*time.Second)
-	defer shutdownCancel()
+	ctx, cancel = context.WithTimeout(context.Background(), 30*time.Second)
+	defer cancel()
 
-	if err := server.Shutdown(shutdownCtx); err != nil {
+	if err := server.Shutdown(ctx); err != nil {
 		log.Fatalf("Server forced to shutdown: %v", err)
 	}
 

api/main_test.go

@@ -1,92 +0,0 @@
-package main
-
-import (
-	"context"
-	"testing"
-	"time"
-)
-
-// TestEveryTick_CallsFnOnTick verifies the helper invokes fn repeatedly on its
-// interval. A non-blocking send keeps the spawned goroutine from ever blocking
-// on a full channel, and the 1s timeout per tick is generous vs the 1ms
-// interval so the test is not timing-flaky.
-func TestEveryTick_CallsFnOnTick(t *testing.T) {
-	ctx := t.Context()
-
-	fired := make(chan struct{}, 1)
-	everyTick(ctx, time.Millisecond, func(context.Context) {
-		select {
-		case fired <- struct{}{}:
-		default:
-		}
-	})
-
-	for i := range 3 {
-		select {
-		case <-fired:
-		case <-time.After(time.Second):
-			t.Fatalf("tick %d did not fire within 1s", i+1)
-		}
-	}
-}
-
-// TestEveryTick_StopsOnContextCancel verifies cancelling ctx stops the loop.
-// After the first tick we cancel inside the inter-tick gap, so everyTick's
-// select sees only ctx.Done ready (ticker.C is cold) and returns
-// deterministically — there is no random pick between two ready cases. We then
-// confirm no further tick arrives within a full interval, which a live loop
-// could not satisfy. This is the shutdown guarantee the reconcilers depend on.
-func TestEveryTick_StopsOnContextCancel(t *testing.T) {
-	ctx, cancel := context.WithCancel(context.Background())
-
-	const interval = 50 * time.Millisecond
-	ticks := make(chan struct{}) // unbuffered: fn blocks until the test receives
-	everyTick(ctx, interval, func(context.Context) {
-		ticks <- struct{}{}
-	})
-
-	// First tick proves the loop is running and leaves the goroutine back in
-	// select with ticker.C cold for the next ~interval.
-	select {
-	case <-ticks:
-	case <-time.After(time.Second):
-		t.Fatal("everyTick never called fn")
-	}
-
-	cancel()
-
-	// Cancel landed in the cold gap, so the loop must have taken ctx.Done and
-	// returned. A live loop would tick again at ~interval; a stopped one never
-	// will.
-	select {
-	case <-ticks:
-		t.Fatal("everyTick ticked again after cancel")
-	case <-time.After(interval + 50*time.Millisecond):
-		// good: silent past a full interval — the loop returned
-	}
-}
-
-func TestEveryTick_PassesContextToFn(t *testing.T) {
-	type ctxKey string
-	const marker ctxKey = "marker"
-	ctx, cancel := context.WithCancel(context.WithValue(context.Background(), marker, "present"))
-	defer cancel()
-
-	got := make(chan string, 1)
-	everyTick(ctx, time.Millisecond, func(c context.Context) {
-		v, _ := c.Value(marker).(string)
-		select {
-		case got <- v:
-		default:
-		}
-	})
-
-	select {
-	case v := <-got:
-		if v != "present" {
-			t.Fatalf("fn received wrong context: value = %q, want %q", v, "present")
-		}
-	case <-time.After(time.Second):
-		t.Fatalf("fn never ran")
-	}
-}

api/middleware/doc.go

@@ -1,4 +0,0 @@
-// Package middleware holds the stuff that runs on every request before a
-// handler ever sees it: auth, CORS, logging, rate limiting, metrics, and a
-// recovery net for panics.
-package middleware

api/middleware/metrics.go

@@ -70,14 +70,6 @@ var (
 		[]string{"outcome"},
 	)
 
-	abandoned3DSSweepTotal = promauto.NewCounterVec(
-		prometheus.CounterOpts{
-			Name: "abandoned_3ds_sweep_total",
-			Help: "ReconcileStale3DSOrders outcomes per row processed (flipped, flip_noop, flip_failed, succeeded_skip, processing_skip, stripe_error, missing_pi, unrecognized_status)",
-		},
-		[]string{"outcome"},
-	)
-
 	orderValueDollars = promauto.NewHistogram(
 		prometheus.HistogramOpts{
 			Name:    "order_value_dollars",
@@ -181,19 +173,6 @@ func ObserveOrderValueCents(cents int) {
 	orderValueDollars.Observe(float64(cents) / 100.0)
 }
 
-// RecordAbandoned3DSSweep records the outcome of one row processed by
-// ReconcileStale3DSOrders. Bounded enumeration documented on the counter's
-// Help string.
-func RecordAbandoned3DSSweep(outcome string) {
-	abandoned3DSSweepTotal.WithLabelValues(outcome).Inc()
-}
-
-// Abandoned3DSSweepCounter exposes the sweep counter so tests can snapshot
-// per-label values via prometheus testutil. Not used in production code.
-func Abandoned3DSSweepCounter() *prometheus.CounterVec {
-	return abandoned3DSSweepTotal
-}
-
 // ObserveStripeRequest records latency of a Stripe API call.
 func ObserveStripeRequest(op, outcome string, durSec float64) {
 	stripeRequestDuration.WithLabelValues(op, outcome).Observe(durSec)

api/routes/doc.go

@@ -1,3 +0,0 @@
-// Package routes is the switchboard: it maps every URL to the handler that
-// knows what to do with it.
-package routes

api/routes/routes.go

@@ -16,6 +16,7 @@ import (
 // SetupRoutes configures all API routes
 func SetupRoutes(
 	version string,
+	stripeSecretKey string,
 	stripeWebhookSecret string,
 	jwtManager *auth.JWTManager,
 	authFingerprintKey string,
@@ -28,7 +29,6 @@ func SetupRoutes(
 	slackSigningSecret string,
 	adminAPIKey string,
 	apiPort string,
-	maxOrderCents int,
 ) *chi.Mux {
 	r := chi.NewRouter()
 
@@ -46,15 +46,13 @@ func SetupRoutes(
 	healthHandler := handlers.NewHealthHandler(version)
 	productHandler := handlers.NewProductHandler()
 	authHandler := handlers.NewAuthHandler(jwtManager, authFingerprintKey)
-	cartHandler := handlers.NewCartHandler(appURL, maxOrderCents)
-	cardHandler := handlers.NewCardHandler(appURL)
-	orderHandler := handlers.NewOrderHandler(bringAPIUID, bringAPIKey, bringCustomerNumber)
+	cartHandler := handlers.NewCartHandler(stripeSecretKey)
+	cardHandler := handlers.NewCardHandler(stripeSecretKey, appURL)
+	orderHandler := handlers.NewOrderHandler(stripeSecretKey, bringAPIUID, bringAPIKey, bringCustomerNumber)
 	addressHandler := handlers.NewAddressHandler(shippoAPIKey, bringAPIUID, bringAPIKey)
 	viewHandler := handlers.NewViewHandler()
-	webhookHandler := handlers.NewWebhookHandler(stripeWebhookSecret, shippoWebhookSecret)
+	webhookHandler := handlers.NewWebhookHandler(stripeWebhookSecret, stripeSecretKey, shippoWebhookSecret)
 	slackHandler := handlers.NewSlackHandler(slackSigningSecret, adminAPIKey, apiPort, shippoWebhookSecret)
-	adminUserHandler := handlers.NewAdminUserHandler()
-	accountHandler := handlers.NewAccountHandler(maxOrderCents)
 
 	// Short payment redirect and success page — no auth required.
 	r.Get("/pay/{token}", handlers.PayRedirect)
@@ -63,10 +61,6 @@ func SetupRoutes(
 		w.Header().Set("Content-Type", "text/html")
 		_, _ = w.Write([]byte(`<!DOCTYPE html><html><body style="font-family:monospace;text-align:center;padding:4rem"><h2>Card added.</h2><p>You can close this tab.</p></body></html>`))
 	})
-	r.Get("/post-3ds", func(w http.ResponseWriter, r *http.Request) {
-		w.Header().Set("Content-Type", "text/html")
-		_, _ = w.Write([]byte(`<!DOCTYPE html><html><body style="font-family:monospace;text-align:center;padding:4rem"><h2>Authentication complete.</h2><p>Return to your terminal.</p></body></html>`))
-	})
 	r.Handle("/metrics", middleware.MetricsHandler())
 
 	r.Route("/api/v1", func(r chi.Router) {
@@ -106,11 +100,6 @@ func SetupRoutes(
 
 			r.Get("/view/init", viewHandler.GetViewInit)
 
-			// Account self-service settings, JWT-authed, edits the callers
-			// own row (user id from context, never a URL param). Distinct from
-			// the admin /users/{id}/order-cap setter in the RequireAdmin group.
-			r.Put("/account/spend-limit", accountHandler.SetSpendLimit)
-
 			// Cart
 			r.Route("/cart", func(r chi.Router) {
 				r.Get("/", cartHandler.GetCart)
@@ -138,7 +127,6 @@ func SetupRoutes(
 			// Orders
 			r.Get("/orders", orderHandler.GetOrders)
 			r.Get("/orders/{id}/status", orderHandler.GetOrderStatus)
-			r.With(middleware.RateLimitByUser(10, time.Minute)).Post("/orders/{id}/retry-auth", cartHandler.RetryAuth)
 			r.Post("/orders/{id}/refund-request", orderHandler.CreateRefundRequest)
 			r.Post("/orders/{id}/refund", orderHandler.RefundOrder)
 
@@ -156,8 +144,6 @@ func SetupRoutes(
 			r.Use(middleware.RequireAdmin)
 			r.Patch("/orders/{id}/tracking", orderHandler.UpdateTracking)
 			r.Post("/orders/{id}/label", orderHandler.PurchaseLabel)
-			// Set or clear a user's per-user order spend-cap override.
-			r.Patch("/users/{id}/order-cap", adminUserHandler.SetUserOrderCap)
 		})
 	})
 

cmd/reconcile-cards/doc.go

@@ -1,3 +0,0 @@
-// Command reconcile-cards hunts down saved cards that Stripe no longer knows
-// about and detaches them. Run it with -dry-run first if you're nervous.
-package main

go.mod

@@ -39,7 +39,6 @@ require (
 	github.com/anmitsu/go-shlex v0.0.0-20200514113438-38f4b401e2be // indirect
 	github.com/atotto/clipboard v0.1.4 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
-	github.com/bitfield/gotestdox v0.2.2 // indirect
 	github.com/catppuccin/go v0.3.0 // indirect
 	github.com/cenkalti/backoff/v5 v5.0.3 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
@@ -57,20 +56,15 @@ require (
 	github.com/clipperhouse/displaywidth v0.11.0 // indirect
 	github.com/clipperhouse/uax29/v2 v2.7.0 // indirect
 	github.com/creack/pty v1.1.24 // indirect
-	github.com/dnephin/pflag v1.0.7 // indirect
 	github.com/dustin/go-humanize v1.0.1 // indirect
-	github.com/fatih/color v1.18.0 // indirect
 	github.com/felixge/httpsnoop v1.0.4 // indirect
-	github.com/fsnotify/fsnotify v1.9.0 // indirect
 	github.com/go-faster/city v1.0.1 // indirect
 	github.com/go-faster/errors v0.7.1 // indirect
 	github.com/go-logfmt/logfmt v0.6.1 // indirect
 	github.com/go-logr/logr v1.4.3 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/go-sql-driver/mysql v1.7.0 // indirect
-	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 // indirect
 	github.com/google/uuid v1.6.0 // indirect
-	github.com/gotesttools/gotestfmt/v2 v2.5.0 // indirect
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0 // indirect
 	github.com/hashicorp/go-version v1.6.0 // indirect
 	github.com/jackc/pgpassfile v1.0.0 // indirect
@@ -81,10 +75,7 @@ require (
 	github.com/jinzhu/now v1.1.5 // indirect
 	github.com/klauspost/compress v1.18.0 // indirect
 	github.com/klauspost/cpuid/v2 v2.2.10 // indirect
-	github.com/kylelemons/godebug v1.1.0 // indirect
 	github.com/lucasb-eyer/go-colorful v1.4.0 // indirect
-	github.com/mattn/go-colorable v0.1.13 // indirect
-	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/mattn/go-runewidth v0.0.23 // indirect
 	github.com/mattn/go-sqlite3 v1.14.34 // indirect
 	github.com/mitchellh/hashstructure/v2 v2.0.2 // indirect
@@ -107,13 +98,10 @@ require (
 	go.opentelemetry.io/proto/otlp v1.10.0 // indirect
 	go.yaml.in/yaml/v2 v2.4.2 // indirect
 	golang.org/x/exp v0.0.0-20251023183803-a4bb9ffd2546 // indirect
-	golang.org/x/mod v0.34.0 // indirect
 	golang.org/x/net v0.52.0 // indirect
 	golang.org/x/sync v0.20.0 // indirect
 	golang.org/x/sys v0.43.0 // indirect
-	golang.org/x/term v0.42.0 // indirect
 	golang.org/x/text v0.36.0 // indirect
-	golang.org/x/tools v0.43.0 // indirect
 	google.golang.org/genproto/googleapis/api v0.0.0-20260401024825-9d38bb4040a9 // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20260401024825-9d38bb4040a9 // indirect
 	google.golang.org/grpc v1.80.0 // indirect
@@ -121,10 +109,4 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	gorm.io/driver/clickhouse v0.7.0 // indirect
 	gorm.io/driver/mysql v1.5.7 // indirect
-	gotest.tools/gotestsum v1.13.0 // indirect
-)
-
-tool (
-	github.com/gotesttools/gotestfmt/v2/cmd/gotestfmt
-	gotest.tools/gotestsum
 )

go.sum

@@ -26,8 +26,6 @@ github.com/aymanbagabas/go-udiff v0.4.1 h1:OEIrQ8maEeDBXQDoGCbbTTXYJMYRCRO1fnodZ
 github.com/aymanbagabas/go-udiff v0.4.1/go.mod h1:0L9PGwj20lrtmEMeyw4WKJ/TMyDtvAoK9bf2u/mNo3w=
 github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
 github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
-github.com/bitfield/gotestdox v0.2.2 h1:x6RcPAbBbErKLnapz1QeAlf3ospg8efBsedU93CDsnE=
-github.com/bitfield/gotestdox v0.2.2/go.mod h1:D+gwtS0urjBrzguAkTM2wodsTQYFHdpx8eqRJ3N+9pY=
 github.com/catppuccin/go v0.3.0 h1:d+0/YicIq+hSTo5oPuRi5kOpqkVA5tAsU6dNhvRu+aY=
 github.com/catppuccin/go v0.3.0/go.mod h1:8IHJuMGaUUjQM82qBrGNBv7LFq6JI3NnQCF6MOlZjpc=
 github.com/cenkalti/backoff/v5 v5.0.3 h1:ZN+IMa753KfX5hd8vVaMixjnqRZ3y8CuJKRKj1xcsSM=
@@ -71,18 +69,12 @@ github.com/creack/pty v1.1.24/go.mod h1:08sCNb52WyoAwi2QDyzUCTgcvVFhUzewun7wtTfv
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
-github.com/dnephin/pflag v1.0.7 h1:oxONGlWxhmUct0YzKTgrpQv9AUA1wtPBn7zuSjJqptk=
-github.com/dnephin/pflag v1.0.7/go.mod h1:uxE91IoWURlOiTUIA8Mq5ZZkAv3dPUfZNaT80Zm7OQE=
 github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkpeCY=
 github.com/dustin/go-humanize v1.0.1/go.mod h1:Mu1zIs6XwVuF/gI1OepvI0qD18qycQx+mFykh5fBlto=
-github.com/fatih/color v1.18.0 h1:S8gINlzdQ840/4pfAwic/ZE0djQEH3wM94VfqLTZcOM=
-github.com/fatih/color v1.18.0/go.mod h1:4FelSpRwEGDpQ12mAdzqdOukCy4u8WUtOY6lkT/6HfU=
 github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2Wg=
 github.com/felixge/httpsnoop v1.0.4/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
 github.com/foize/go.sgr v0.0.0-20140220094842-40bdfc98040c h1:NhHTf8Ewd3NS46DylZB75Zi0UeATvDbDwFEmsO5ZVpQ=
 github.com/foize/go.sgr v0.0.0-20140220094842-40bdfc98040c/go.mod h1:0ghtL4RhKBjyWMkHCWosp2aHSEXShQeQMLQ0qBCytfU=
-github.com/fsnotify/fsnotify v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
-github.com/fsnotify/fsnotify v1.9.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
 github.com/go-chi/chi/v5 v5.2.5 h1:Eg4myHZBjyvJmAFjFvWgrqDTXFyOzjj7YIm3L3mu6Ug=
 github.com/go-chi/chi/v5 v5.2.5/go.mod h1:X7Gx4mteadT3eDOMTsXzmI4/rwUpOwBHLpAfupzFJP0=
 github.com/go-chi/cors v1.2.2 h1:Jmey33TE+b+rB7fT8MUy1u0I4L+NARQlK6LhzKPSyQE=
@@ -113,12 +105,8 @@ github.com/google/go-cmp v0.5.2/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
 github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
 github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
-github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 h1:El6M4kTTCOh6aBiKaUGG7oYTSPP8MxqL4YI3kZKwcP4=
-github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
 github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
 github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
-github.com/gotesttools/gotestfmt/v2 v2.5.0 h1:fSU3MnR+E+fvuXdw1l8xbufKhDxY3Tfjsjx/I1WerB4=
-github.com/gotesttools/gotestfmt/v2 v2.5.0/go.mod h1:oQJg2KZ2aGoqEbMC2PDaAeBYm0tOkocgixK9FzsCdp4=
 github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0 h1:HWRh5R2+9EifMyIHV7ZV+MIZqgz+PMpZ14Jynv3O2Zs=
 github.com/grpc-ecosystem/grpc-gateway/v2 v2.28.0/go.mod h1:JfhWUomR1baixubs02l85lZYYOm7LV6om4ceouMv45c=
 github.com/hashicorp/go-version v1.6.0 h1:feTTfFNnjP967rlCxM/I9g701jU+RN74YKx2mOkIeek=
@@ -155,11 +143,6 @@ github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0
 github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
 github.com/lucasb-eyer/go-colorful v1.4.0 h1:UtrWVfLdarDgc44HcS7pYloGHJUjHV/4FwW4TvVgFr4=
 github.com/lucasb-eyer/go-colorful v1.4.0/go.mod h1:R4dSotOR9KMtayYi1e77YzuveK+i7ruzyGqttikkLy0=
-github.com/mattn/go-colorable v0.1.13 h1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA=
-github.com/mattn/go-colorable v0.1.13/go.mod h1:7S9/ev0klgBDR4GtXTXX8a3vIGJpMovkB8vQcUbaXHg=
-github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM=
-github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY=
-github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
 github.com/mattn/go-runewidth v0.0.23 h1:7ykA0T0jkPpzSvMS5i9uoNn2Xy3R383f9HDx3RybWcw=
 github.com/mattn/go-runewidth v0.0.23/go.mod h1:XBkDxAl56ILZc9knddidhrOlY5R/pDhgLpndooCuJAs=
 github.com/mattn/go-sqlite3 v1.14.34 h1:3NtcvcUnFBPsuRcno8pUtupspG/GM+9nZ88zgJcp6Zk=
@@ -256,8 +239,6 @@ golang.org/x/exp v0.0.0-20251023183803-a4bb9ffd2546 h1:mgKeJMpvi0yx/sU5GsxQ7p6s2
 golang.org/x/exp v0.0.0-20251023183803-a4bb9ffd2546/go.mod h1:j/pmGrbnkbPtQfxEe5D0VQhZC6qKbfKifgD0oM7sR70=
 golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
-golang.org/x/mod v0.34.0 h1:xIHgNUUnW6sYkcM5Jleh05DvLOtwc6RitGHbDk4akRI=
-golang.org/x/mod v0.34.0/go.mod h1:ykgH52iCZe79kzLLMhyCUzhMci+nQj+0XkbXpNYtVjY=
 golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
 golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
 golang.org/x/net v0.0.0-20200226121028-0de0cce0169b/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
@@ -278,8 +259,6 @@ golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f/go.mod h1:h1NjWce9XRLGQEsW7w
 golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.43.0 h1:Rlag2XtaFTxp19wS8MXlJwTvoh8ArU6ezoyFsMyCTNI=
 golang.org/x/sys v0.43.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
@@ -295,8 +274,6 @@ golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGm
 golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
 golang.org/x/tools v0.0.0-20200619180055-7c47624df98f/go.mod h1:EkVYQZoAsY45+roYkvgYkIh4xh/qjgUK9TdY2XT94GE=
 golang.org/x/tools v0.0.0-20210106214847-113979e3529a/go.mod h1:emZCQorbCU4vsT4fOWvOPXz4eW1wZW4PmDk9uLelYpA=
-golang.org/x/tools v0.43.0 h1:12BdW9CeB3Z+J/I/wj34VMl8X+fEXBxVR90JeMX5E7s=
-golang.org/x/tools v0.43.0/go.mod h1:uHkMso649BX2cZK6+RpuIPXS3ho2hZo4FVwfoy1vIk0=
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
@@ -333,9 +310,5 @@ gorm.io/gorm v1.31.1 h1:7CA8FTFz/gRfgqgpeKIBcervUn3xSyPUmr6B2WXJ7kg=
 gorm.io/gorm v1.31.1/go.mod h1:XyQVbO2k6YkOis7C2437jSit3SsDK72s7n7rsSHd+Gs=
 gorm.io/plugin/opentelemetry v0.1.16 h1:Kypj2YYAliJqkIczDZDde6P6sFMhKSlG5IpngMFQGpc=
 gorm.io/plugin/opentelemetry v0.1.16/go.mod h1:P3RmTeZXT+9n0F1ccUqR5uuTvEXDxF8k2UpO7mTIB2Y=
-gotest.tools/gotestsum v1.13.0 h1:+Lh454O9mu9AMG1APV4o0y7oDYKyik/3kBOiCqiEpRo=
-gotest.tools/gotestsum v1.13.0/go.mod h1:7f0NS5hFb0dWr4NtcsAsF0y1kzjEFfAil0HiBQJE03Q=
-gotest.tools/v3 v3.5.2 h1:7koQfIKdy+I8UTetycgUqXWSDwpgv193Ka+qRsmBY8Q=
-gotest.tools/v3 v3.5.2/go.mod h1:LtdLGcnqToBH83WByAAi/wiwSFCArdFIUV/xxN4pcjA=
 rsc.io/qr v0.2.0 h1:6vBLea5/NRMVTz8V66gipeLycZMl/+UlFmk8DvqQ6WY=
 rsc.io/qr v0.2.0/go.mod h1:IF+uZjkb9fqyeF/4tlBoynqmQxUoPfWEKh921coOuXs=

main.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"os/signal"
 	"syscall"
+
 	"time"
 
 	tea "charm.land/bubbletea/v2"
@@ -15,7 +16,6 @@ import (
 	"charm.land/wish/v2/bubbletea"
 	"charm.land/wish/v2/logging"
 	"github.com/charmbracelet/ssh"
-	"github.com/stripe/stripe-go/v78"
 
 	"terminalShop/pkg/auth"
 	"terminalShop/pkg/config"
@@ -32,6 +32,7 @@ func listenHost() string {
 var (
 	apiURL             string
 	authFingerprintKey string
+	stripePublicKey    string
 )
 
 func teaHandler(s ssh.Session) (tea.Model, []tea.ProgramOption) {
@@ -43,7 +44,7 @@ func teaHandler(s ssh.Session) (tea.Model, []tea.ProgramOption) {
 		pubKeyStr = auth.FormatSSHPublicKey(pubKey)
 	}
 
-	m := tui.NewModelWithAuth(fingerprint, pubKeyStr, apiURL, authFingerprintKey)
+	m := tui.NewModelWithAuth(fingerprint, pubKeyStr, apiURL, authFingerprintKey, stripePublicKey)
 	return m, nil
 }
 
@@ -57,15 +58,7 @@ func main() {
 	// Set API URL and auth key from config for TUI connections
 	apiURL = cfg.APIURL
 	authFingerprintKey = cfg.AuthFingerprintKey
-
-	// Wire the publishable key into stripe-go's package-level global once.
-	// TUI uses the legacy Tokens API (stripetoken.New) which accepts the
-	// publishable key; per-session writes would race across concurrent SSH
-	// sessions even though they'd all write the same value.
-	// NOTE: assumes single-process — if you ever embed both the SSH and API
-	// binaries together, the last writer wins and one of them silently breaks.
-	stripe.Key = cfg.StripePublicKey
-
+	stripePublicKey = cfg.StripePublicKey
 	log.Printf("TUI will connect to API at: %s", apiURL)
 
 	// Create SSH server

pkg/api/client.go

@@ -104,16 +104,16 @@ func (c *Client) RefreshToken(fingerprint, clientSecret string) (string, error)
 
 // APIResponse represents the standard API response format
 type APIResponse struct {
-	Success bool           `json:"success"`
-	Data    map[string]any `json:"data"`
-	Error   *APIError      `json:"error,omitempty"`
+	Success bool                   `json:"success"`
+	Data    map[string]interface{} `json:"data"`
+	Error   *APIError              `json:"error,omitempty"`
 }
 
 // APIError represents an error from the API
 type APIError struct {
-	Code    string         `json:"code"`
-	Message string         `json:"message"`
-	Details map[string]any `json:"details,omitempty"`
+	Code    string                 `json:"code"`
+	Message string                 `json:"message"`
+	Details map[string]interface{} `json:"details,omitempty"`
 }
 
 // ProductsResponse represents the products API response
@@ -280,31 +280,14 @@ type CardResponse struct {
 }
 
 // ConvertCartResponse represents the cart conversion (checkout) API response.
-// 200 carries Order populated; 202 (requires_action / 3DS) carries the
-// redirect fields and OrderID instead.
 type ConvertCartResponse struct {
 	Success bool `json:"success"`
 	Data    struct {
-		Order           *models.Order `json:"order,omitempty"`
-		OrderID         uint          `json:"order_id,omitempty"`
-		PaymentIntentID string        `json:"payment_intent_id,omitempty"`
-		Status          string        `json:"status,omitempty"`
-		RedirectToken   string        `json:"redirect_token,omitempty"`
-		RedirectURL     string        `json:"redirect_url,omitempty"`
+		Order models.Order `json:"order"`
 	} `json:"data"`
 	Error *APIError `json:"error,omitempty"`
 }
 
-// CheckoutOutcome is the unified result of ConvertCart. RequiresAction=true
-// means the customer needs to complete 3DS at RedirectURL; poll
-// GetOrderStatus(OrderID) until the webhook flips the order to paid or failed.
-type CheckoutOutcome struct {
-	Order          *models.Order
-	OrderID        uint
-	RequiresAction bool
-	RedirectURL    string
-}
-
 // GetCart fetches the user's current cart.
 func (c *Client) GetCart() (*CartData, error) {
 	url := fmt.Sprintf("%s/api/v1/cart", c.BaseURL)
@@ -339,7 +322,7 @@ func (c *Client) GetCart() (*CartData, error) {
 func (c *Client) SetCartItem(coffeeID uint, quantity int) (*CartData, error) {
 	url := fmt.Sprintf("%s/api/v1/cart/item", c.BaseURL)
 
-	body := map[string]any{
+	body := map[string]interface{}{
 		"coffee_id": coffeeID,
 		"quantity":  quantity,
 	}
@@ -379,7 +362,7 @@ func (c *Client) SetCartItem(coffeeID uint, quantity int) (*CartData, error) {
 func (c *Client) SetCartAddress(addressID uint) error {
 	url := fmt.Sprintf("%s/api/v1/cart/address", c.BaseURL)
 
-	body := map[string]any{
+	body := map[string]interface{}{
 		"address_id": addressID,
 	}
 	jsonData, err := json.Marshal(body)
@@ -418,7 +401,7 @@ func (c *Client) SetCartAddress(addressID uint) error {
 func (c *Client) SetCartCard(cardID uint) error {
 	url := fmt.Sprintf("%s/api/v1/cart/card", c.BaseURL)
 
-	body := map[string]any{
+	body := map[string]interface{}{
 		"card_id": cardID,
 	}
 	jsonData, err := json.Marshal(body)
@@ -453,44 +436,6 @@ func (c *Client) SetCartCard(cardID uint) error {
 	return nil
 }
 
-func (c *Client) SetSpendLimit(cents *int) error {
-	url := fmt.Sprintf("%s/api/v1/account/spend-limit", c.BaseURL)
-
-	body := map[string]any{
-		"self_limit_cents": cents,
-	}
-	jsonData, err := json.Marshal(body)
-	if err != nil {
-		return fmt.Errorf("failed to marshal request: %w", err)
-	}
-
-	req, err := http.NewRequest("PUT", url, bytes.NewBuffer(jsonData))
-	if err != nil {
-		return fmt.Errorf("failed to create request: %w", err)
-	}
-	req.Header.Set("Content-Type", "application/json")
-
-	resp, err := c.doRequest(req)
-	if err != nil {
-		return fmt.Errorf("failed to set spend limit: %w", err)
-	}
-	defer func() { _ = resp.Body.Close() }()
-
-	var result APIResponse
-	if err := json.NewDecoder(resp.Body).Decode(&result); err != nil {
-		return fmt.Errorf("failed to decode response: %w", err)
-	}
-
-	if !result.Success {
-		if result.Error != nil {
-			return fmt.Errorf("%s: %s", result.Error.Code, result.Error.Message)
-		}
-		return fmt.Errorf("failed to set spend limit")
-	}
-
-	return nil
-}
-
 // ClearCart removes all items from the user's cart.
 func (c *Client) ClearCart() error {
 	url := fmt.Sprintf("%s/api/v1/cart", c.BaseURL)
@@ -522,9 +467,7 @@ func (c *Client) ClearCart() error {
 }
 
 // ConvertCart converts the cart into an order, charging the saved card.
-// Returns a CheckoutOutcome that either carries the completed Order or
-// indicates the customer must complete 3DS authentication via RedirectURL.
-func (c *Client) ConvertCart() (*CheckoutOutcome, error) {
+func (c *Client) ConvertCart() (*models.Order, error) {
 	url := fmt.Sprintf("%s/api/v1/cart/convert", c.BaseURL)
 
 	req, err := http.NewRequest("POST", url, nil)
@@ -550,21 +493,7 @@ func (c *Client) ConvertCart() (*CheckoutOutcome, error) {
 		return nil, fmt.Errorf("failed to convert cart")
 	}
 
-	if convertResp.Data.Status == "requires_action" {
-		return &CheckoutOutcome{
-			OrderID:        convertResp.Data.OrderID,
-			RequiresAction: true,
-			RedirectURL:    convertResp.Data.RedirectURL,
-		}, nil
-	}
-
-	if convertResp.Data.Order == nil {
-		return nil, fmt.Errorf("malformed convert response: missing order")
-	}
-	return &CheckoutOutcome{
-		Order:   convertResp.Data.Order,
-		OrderID: convertResp.Data.Order.ID,
-	}, nil
+	return &convertResp.Data.Order, nil
 }
 
 type OrderStatusResponse struct {
@@ -601,58 +530,6 @@ func (c *Client) GetOrderStatus(id uint) (string, error) {
 	return sResp.Data.Status, nil
 }
 
-// RetryAuthOutcome is the result of POST /orders/{id}/retry-auth.
-// status=="requires_action" -> RedirectURL is a fresh QR target; resume polling.
-// Status=="succeeded" -> stripe approved frictionless; keep polling for the
-// webhook to flip status=paid (RedirectURL will be empty)
-type RetryAuthOutcome struct {
-	OrderID     uint
-	Status      string
-	RedirectURL string
-}
-
-type retryAuthResponse struct {
-	Success bool `json:"success"`
-	Data    struct {
-		OrderID     uint   `json:"order_id"`
-		Status      string `json:"status"`
-		RedirectURL string `json:"redirect_url,omitempty"`
-	} `json:"data"`
-	Error *APIError `json:"error,omitempty"`
-}
-
-// RetryAuth asks the server to re-Confirm the existing PaymentIntent for the
-// order, producing a new 3DS challenge URL. Used by the TUI's authFailed
-// screen so the customer can recover without re-entering the checkout flow.
-func (c *Client) RetryAuth(orderID uint) (*RetryAuthOutcome, error) {
-	url := fmt.Sprintf("%s/api/v1/orders/%d/retry-auth", c.BaseURL, orderID)
-	req, err := http.NewRequest("POST", url, nil)
-	if err != nil {
-		return nil, fmt.Errorf("failed to create retry request: %w", err)
-	}
-	resp, err := c.doRequest(req)
-	if err != nil {
-		return nil, fmt.Errorf("failed to send retry request: %w", err)
-	}
-	defer func() { _ = resp.Body.Close() }()
-
-	var rResp retryAuthResponse
-	if err := json.NewDecoder(resp.Body).Decode(&rResp); err != nil {
-		return nil, fmt.Errorf("failed to decode retry response: %w", err)
-	}
-	if !rResp.Success {
-		if rResp.Error != nil {
-			return nil, fmt.Errorf("%s: %s", rResp.Error.Code, rResp.Error.Message)
-		}
-		return nil, fmt.Errorf("failed to retry authentication")
-	}
-	return &RetryAuthOutcome{
-		OrderID:     rResp.Data.OrderID,
-		Status:      rResp.Data.Status,
-		RedirectURL: rResp.Data.RedirectURL,
-	}, nil
-}
-
 // GetCards fetches all saved cards for the user.
 func (c *Client) GetCards() ([]models.Card, error) {
 	url := fmt.Sprintf("%s/api/v1/cards", c.BaseURL)

pkg/api/doc.go

@@ -1,3 +0,0 @@
-// Package api is the client side of the house: it talks to our HTTP backend
-// so other Go code doesn't have to hand-roll requests.
-package api

pkg/audit/audit.go

@@ -13,36 +13,16 @@ import (
 	"gorm.io/gorm"
 )
 
-// EventOrderRequiresAction is the audit event-type string emitted whenever a
-// PaymentIntent is pushed into requires_action. Exposed so cart-flow handler
-// can count retry attempts without hardcoding the string literal.
-const EventOrderRequiresAction = "order_requires_action"
-
-// EventOrder3DSAbandoned is the audit event-type string emitted by the
-// abandoned-3DS sweep when it flips a stale requires_action row to failed.
-// Distinct from EventOrderRequiresAction (caveat #17) so the retry-cap count
-// stays decoupled from sweep activity
-const EventOrder3DSAbandoned = "order_3ds_abandoned"
-
-// EventCartRejected is the audit event-type string emitted when the per-order
-// spend cap blocks a checkout BEFORE an order row is created. The event lives
-// in slog only, persist() no-ops on zero order id, which is the correct shape
-// here (cap rejection is upstream of order state). See caveat #13.
-const EventCartRejected = "cart_rejected"
-
 type eventType string
 
 const (
 	eventCardAdded              eventType = "card_added"
 	eventCardDeleted            eventType = "card_deleted"
-	eventCardExpired            eventType = "card_expired"
 	eventOrderCreated           eventType = "order_created"
 	eventOrderPaid              eventType = "order_paid"
 	eventOrderShipped           eventType = "order_shipped"
 	eventOrderFailed            eventType = "order_failed"
-	eventOrderRequiresAction    eventType = EventOrderRequiresAction
-	eventOrder3DSAbandoned      eventType = EventOrder3DSAbandoned
-	eventCartRejected           eventType = EventCartRejected
+	eventOrderRequiresAction    eventType = "order_requires_action"
 	eventOrderRefunded          eventType = "order_refunded"
 	eventPaymentCritical        eventType = "payment_critical"
 	eventLabelPurchased         eventType = "label_purchased"
@@ -50,26 +30,22 @@ const (
 	eventTrackingUpdated        eventType = "tracking_updated"
 	eventOrderDelivered         eventType = "order_delivered"
 	eventTrackingMarkedManually eventType = "tracking_marked_manually"
-	eventUserOrderCapSet        eventType = "user_order_cap_set"
-	eventUserSelfLimitSet       eventType = "user_self_limit_set"
 )
 
 type event struct {
-	Event      eventType
-	UserID     uint
-	OrderID    uint
-	CardID     uint
-	Amount     int
-	StripeID   string
-	CardLast4  string
-	CardBrand  string
-	Carrier    string
-	Tracking   string
-	Status     string
-	Error      string
-	Actor      string
-	TotalCents int
-	CapCents   int
+	Event     eventType
+	UserID    uint
+	OrderID   uint
+	CardID    uint
+	Amount    int
+	StripeID  string
+	CardLast4 string
+	CardBrand string
+	Carrier   string
+	Tracking  string
+	Status    string
+	Error     string
+	Actor     string
 }
 
 func (e event) attrs() []any {
@@ -110,12 +86,6 @@ func (e event) attrs() []any {
 	if e.Actor != "" {
 		a = append(a, "actor", e.Actor)
 	}
-	if e.TotalCents != 0 {
-		a = append(a, "total_cents", e.TotalCents)
-	}
-	if e.CapCents != 0 {
-		a = append(a, "cap_cents", e.CapCents)
-	}
 	return a
 }
 
@@ -143,17 +113,6 @@ func CardDeleted(userID, cardID uint) {
 	persist(0, eventCardDeleted, e)
 }
 
-// CardExpired records that a saved payment method expired from inactivity
-func CardExpired(userID, cardID uint) {
-	e := event{
-		Event:  eventCardExpired,
-		UserID: userID,
-		CardID: cardID,
-	}
-	slog.Info("audit", e.attrs()...)
-	persist(0, eventCardExpired, e)
-}
-
 // OrderCreated records that an order record was created (before payment).
 func OrderCreated(userID, orderID uint, amountCents int) {
 	e := event{
@@ -342,6 +301,7 @@ func attrsToMap(a []any) map[string]any {
 	return m
 }
 
+//nolint:unused // called from ConvertCart in the next update
 func OrderRequiresAction(userID, orderID uint, paymentIntentID string) {
 	e := event{
 		Event:    eventOrderRequiresAction,
@@ -352,76 +312,3 @@ func OrderRequiresAction(userID, orderID uint, paymentIntentID string) {
 	slog.Info("audit", e.attrs()...)
 	persist(orderID, eventOrderRequiresAction, e)
 }
-
-// Order3DSAbandoned records the abandoned-3DS sweep flipping a stale
-// requires_action row to failed because Stripe still reports the underlying
-// PaymentIntent as outstanding past the sweep threshold.
-func Order3DSAbandoned(userID, orderID uint, paymentIntentID string) {
-	e := event{
-		Event:    eventOrder3DSAbandoned,
-		UserID:   userID,
-		OrderID:  orderID,
-		StripeID: paymentIntentID,
-	}
-	slog.Info("audit", e.attrs()...)
-	persist(orderID, eventOrder3DSAbandoned, e)
-}
-
-// CartRejected records the per-order cap blocking a checkout BEFORE an
-// order row is created. Slog-only by design: cap rejection runs upstream
-// of order creation so there is no order id to scope a persistent
-// OrderEvent row. persist() is intentionally not called - future refactors
-// of the persist() zero-id guard must not silently start writing rows here.
-// Counterpart to the validation_over_limit Prometheus counter.
-func CartRejected(userID uint, totalCents, capCents int) {
-	e := event{
-		Event:      eventCartRejected,
-		UserID:     userID,
-		TotalCents: totalCents,
-		CapCents:   capCents,
-	}
-	slog.Info("audit", e.attrs()...)
-}
-
-// UserOrderCapSet records an operator changing a user's per-user order-spend
-// cap override (User.MaxOrderCents), an admin-gated action. A nil capCents means
-// the override was cleared and the user reverts to the global MAX_ORDER_CENTS;
-// Status distinguishes "set" from "cleared" so a cap set to 0 (off-switch, which
-// attrs() omits because cap_cents == 0) is still legible in the log.
-func UserOrderCapSet(actor string, userID uint, capCents *int) {
-	e := event{
-		Event:  eventUserOrderCapSet,
-		Actor:  actor,
-		UserID: userID,
-	}
-	if capCents == nil {
-		e.Status = "cleared"
-	} else {
-		e.Status = "set"
-		e.CapCents = *capCents
-	}
-	slog.Info("audit", e.attrs()...)
-}
-
-// UserSelfLimitSet records a customer changing their own self-service spend
-// limit (User.SelfLimitCents) via the JWT-authed account endpoint. Kept
-// deliberately distinct from UserOrderCapSet (the operator's admin-gated
-// override) so the customer action and the operator action are never conflated
-// in the audit trail. A nil capCents means the self-limit was cleared (the user
-// reverts to the admin/global cap). Unlike the admin cap, an explicit 0 here is
-// a real "block everything" ceiling, not an off-switch, so Status distinguishes
-// "set" from "cleared" and a cap of 0 (which attrs() omits) stays legible.
-func UserSelfLimitSet(userID uint, capCents *int) {
-	e := event{
-		Event:  eventUserSelfLimitSet,
-		Actor:  "self",
-		UserID: userID,
-	}
-	if capCents == nil {
-		e.Status = "cleared"
-	} else {
-		e.Status = "set"
-		e.CapCents = *capCents
-	}
-	slog.Info("audit", e.attrs()...)
-}

pkg/audit/audit_test.go

@@ -1,41 +0,0 @@
-package audit
-
-import (
-	"bytes"
-	"encoding/json"
-	"log/slog"
-	"strings"
-	"testing"
-)
-
-func TestCartRejected(t *testing.T) {
-	var buf bytes.Buffer
-	prev := slog.Default()
-	slog.SetDefault(slog.New(slog.NewJSONHandler(&buf, nil)))
-	t.Cleanup(func() { slog.SetDefault(prev) })
-
-	CartRejected(42, 25000, 20000)
-
-	raw := strings.TrimSpace(buf.String())
-	if raw == "" {
-		t.Fatalf("CartRejected: no slog output captured")
-	}
-
-	var rec map[string]any
-	if err := json.Unmarshal([]byte(raw), &rec); err != nil {
-		t.Fatalf("decode slog record: %v\nraw: %s", err, raw)
-	}
-
-	if got, want := rec["event"], "cart_rejected"; got != want {
-		t.Errorf("event: want %q, got %v", want, got)
-	}
-	if n, _ := rec["user_id"].(float64); int(n) != 42 {
-		t.Errorf("user_id want 42, got %v", rec["user_id"])
-	}
-	if n, _ := rec["total_cents"].(float64); int(n) != 25000 {
-		t.Errorf("total_cents: want 25000, got %v", rec["total_cents"])
-	}
-	if n, _ := rec["cap_cents"].(float64); int(n) != 20000 {
-		t.Errorf("cap_cents: want 20000, got %v", rec["cap_cents"])
-	}
-}

pkg/auth/doc.go

@@ -1,3 +0,0 @@
-// Package auth sorts out who you are: logging in with an SSH key and minting
-// the JWT you carry around afterwards.
-package auth

pkg/auth/jwt.go

@@ -53,7 +53,7 @@ func (m *JWTManager) GenerateToken(userID uint, email, username string) (string,
 
 // ValidateToken validates a JWT token and returns the claims
 func (m *JWTManager) ValidateToken(tokenString string) (*Claims, error) {
-	token, err := jwt.ParseWithClaims(tokenString, &Claims{}, func(token *jwt.Token) (any, error) {
+	token, err := jwt.ParseWithClaims(tokenString, &Claims{}, func(token *jwt.Token) (interface{}, error) {
 		// Verify signing method
 		if _, ok := token.Method.(*jwt.SigningMethodHMAC); !ok {
 			return nil, fmt.Errorf("unexpected signing method: %v", token.Header["alg"])

pkg/bring/doc.go

@@ -1,3 +0,0 @@
-// Package bring talks to Bring, the Norwegian postal service, for booking
-// shipments and printing labels.
-package bring

pkg/config/config.go

@@ -3,10 +3,8 @@ package config
 import (
 	"errors"
 	"fmt"
-	"log/slog"
 	"net/url"
 	"os"
-	"strconv"
 	"strings"
 
 	"github.com/joho/godotenv"
@@ -14,26 +12,24 @@ import (
 
 // Config holds all application configuration
 type Config struct {
-	APIPort                      string
-	APIURL                       string
-	AppURL                       string
-	SSHPort                      string
-	Environment                  string
-	DatabaseURL                  string
-	JWTSecret                    string
-	StripeSecretKey              string
-	StripePublicKey              string
-	StripeWebhookSecret          string
-	ShippoAPIKey                 string
-	AuthFingerprintKey           string
-	BringAPIUID                  string
-	BringAPIKey                  string
-	BringCustomerNumber          string
-	ShippoWebhookSecret          string
-	SlackSigningSecret           string
-	AdminAPIKey                  string
-	MaxOrderCents                int
-	Abandoned3DSThresholdMinutes int
+	APIPort             string
+	APIURL              string
+	AppURL              string
+	SSHPort             string
+	Environment         string
+	DatabaseURL         string
+	JWTSecret           string
+	StripeSecretKey     string
+	StripePublicKey     string
+	StripeWebhookSecret string
+	ShippoAPIKey        string
+	AuthFingerprintKey  string
+	BringAPIUID         string
+	BringAPIKey         string
+	BringCustomerNumber string
+	ShippoWebhookSecret string
+	SlackSigningSecret  string
+	AdminAPIKey         string
 }
 
 // Load reads configuration from environment variables and validates required secrets.
@@ -52,26 +48,24 @@ func Load() (*Config, error) {
 	apiPort := getEnvOrDefault("API_PORT", "8080")
 	apiURL := getEnvOrDefault("API_URL", fmt.Sprintf("http://localhost:%s", apiPort))
 	cfg := &Config{
-		APIPort:                      apiPort,
-		APIURL:                       apiURL,
-		AppURL:                       getEnvOrDefault("APP_URL", apiURL),
-		SSHPort:                      getEnvOrDefault("SSH_PORT", "23457"),
-		Environment:                  getEnvOrDefault("ENVIRONMENT", "development"),
-		DatabaseURL:                  getEnvOrDefault("DATABASE_URL", "terminalshop.db"),
-		JWTSecret:                    os.Getenv("JWT_SECRET"),
-		StripeSecretKey:              os.Getenv("STRIPE_SECRET_KEY"),
-		StripePublicKey:              os.Getenv("STRIPE_PUBLIC_KEY"),
-		StripeWebhookSecret:          os.Getenv("STRIPE_WEBHOOK_SECRET"),
-		ShippoAPIKey:                 os.Getenv("SHIPPO_API_KEY"),
-		AuthFingerprintKey:           os.Getenv("AUTH_FINGERPRINT_KEY"),
-		BringAPIUID:                  os.Getenv("BRING_API_UID"),
-		BringAPIKey:                  os.Getenv("BRING_API_KEY"),
-		BringCustomerNumber:          os.Getenv("BRING_CUSTOMER_NUMBER"),
-		ShippoWebhookSecret:          os.Getenv("SHIPPO_WEBHOOK_SECRET"),
-		SlackSigningSecret:           os.Getenv("SLACK_SIGNING_SECRET"),
-		AdminAPIKey:                  os.Getenv("ADMIN_API_KEY"),
-		MaxOrderCents:                loadMaxOrderCents(),
-		Abandoned3DSThresholdMinutes: loadAbandoned3DSThresholdMinutes(),
+		APIPort:             apiPort,
+		APIURL:              apiURL,
+		AppURL:              getEnvOrDefault("APP_URL", apiURL),
+		SSHPort:             getEnvOrDefault("SSH_PORT", "23457"),
+		Environment:         getEnvOrDefault("ENVIRONMENT", "development"),
+		DatabaseURL:         getEnvOrDefault("DATABASE_URL", "terminalshop.db"),
+		JWTSecret:           os.Getenv("JWT_SECRET"),
+		StripeSecretKey:     os.Getenv("STRIPE_SECRET_KEY"),
+		StripePublicKey:     os.Getenv("STRIPE_PUBLIC_KEY"),
+		StripeWebhookSecret: os.Getenv("STRIPE_WEBHOOK_SECRET"),
+		ShippoAPIKey:        os.Getenv("SHIPPO_API_KEY"),
+		AuthFingerprintKey:  os.Getenv("AUTH_FINGERPRINT_KEY"),
+		BringAPIUID:         os.Getenv("BRING_API_UID"),
+		BringAPIKey:         os.Getenv("BRING_API_KEY"),
+		BringCustomerNumber: os.Getenv("BRING_CUSTOMER_NUMBER"),
+		ShippoWebhookSecret: os.Getenv("SHIPPO_WEBHOOK_SECRET"),
+		SlackSigningSecret:  os.Getenv("SLACK_SIGNING_SECRET"),
+		AdminAPIKey:         os.Getenv("ADMIN_API_KEY"),
 	}
 
 	if err := cfg.validate(); err != nil {
@@ -92,7 +86,6 @@ func (c *Config) validate() error {
 		{"JWT_SECRET", c.JWTSecret},
 		{"STRIPE_SECRET_KEY", c.StripeSecretKey},
 		{"AUTH_FINGERPRINT_KEY", c.AuthFingerprintKey},
-		{"STRIPE_WEBHOOK_SECRET", c.StripeWebhookSecret},
 	}
 
 	var missing []string
@@ -137,48 +130,3 @@ func getEnvOrDefault(key, defaultValue string) string {
 	}
 	return defaultValue
 }
-
-// loadMaxOrderCents reads MAX_ORDER_CENTS. Default $500 — roughly tracks the
-// PSD2 TRA exemption ceiling of €500 (≈ $540, FX-dependent), above which Stripe
-// always requests SCA, so the cap is only meaningful below it. We charge in USD
-// and the regulatory ceiling is in EUR, so this is an approximate anchor, not an
-// exact equivalence — $500 trips slightly below the true ceiling, which is the
-// safe direction. Explicit 0 disables the cap. Garbage or negative values fall
-// back to the default with a warning so an operator typo cannot silently disable
-// a fraud control.
-func loadMaxOrderCents() int {
-	const defaultCap = 50000
-	raw := os.Getenv("MAX_ORDER_CENTS")
-	if raw == "" {
-		return defaultCap
-	}
-	n, err := strconv.Atoi(raw)
-	if err != nil || n < 0 {
-		fmt.Printf("WARNING: MAX_ORDER_CENTS=%q invalid, falling back to default %d\n", raw, defaultCap)
-		return defaultCap
-	}
-	return n
-}
-
-// loadAbandoned3DSThresholdMinutes read ABANDONED_3DS_THRESHOLD_MINUTES.
-// The abandoned-3DS sweep only flips requires_action rows whose updated_at iconfigs
-// older than this many minutes. Default 30 min. Values below 1 fall back to
-// the default so a typo cannot collapse the grace window the TUI polls inside.
-func loadAbandoned3DSThresholdMinutes() int {
-	const defaultMinutes = 30
-	raw := os.Getenv("ABANDONED_3DS_THRESHOLD_MINUTES")
-	if raw == "" {
-		return defaultMinutes
-	}
-	n, err := strconv.Atoi(raw)
-	if err != nil || n < 1 {
-		slog.Warn("invalid ABANDONED_3DS_THRESHOLD_MINUTES, falling back",
-			"raw", raw, "default", defaultMinutes)
-		return defaultMinutes
-	}
-	if n < 10 {
-		slog.Warn("ABANDONED_3DS_THRESHOLD_MINUTES below 10 may race in-flight 3ds challenges",
-			"value", n)
-	}
-	return n
-}

pkg/config/config_test.go

@@ -1,78 +0,0 @@
-package config
-
-import (
-	"io"
-	"log/slog"
-	"os"
-	"testing"
-)
-
-// TestMain silences the package's slog warnings so the negative/garbage
-// env-var cases plus the sub-10 valid-minimum case don't spam test output.
-// The actual fall-back behavior is still asserted via the case tables.
-func TestMain(m *testing.M) {
-	prev := slog.Default()
-	slog.SetDefault(slog.New(slog.NewTextHandler(io.Discard, nil)))
-	code := m.Run()
-	slog.SetDefault(prev)
-	os.Exit(code)
-}
-
-func TestLoadMaxOrderCents(t *testing.T) {
-	cases := []struct {
-		name string
-		env  string // "" means unset
-		want int
-	}{
-		{"empty falls back to default", "", 50000},
-		{"explicit zero disables", "0", 0},
-		{"valid override", "30000", 30000},
-		{"negative falls back to default", "-1", 50000},
-		{"garbage falls back to default", "two hundred", 50000},
-		{"empty after trim falls back to default", "", 50000},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			if tc.env == "" {
-				t.Setenv("MAX_ORDER_CENTS", "")
-			} else {
-				t.Setenv("MAX_ORDER_CENTS", tc.env)
-			}
-			got := loadMaxOrderCents()
-			if got != tc.want {
-				t.Errorf("loadMaxOrderCents() = %d, want %d", got, tc.want)
-			}
-		})
-	}
-}
-
-// TestLoadAbandoned3DSThresholdMinutes covers the env-parsing surface for
-// the sweep threshold. Zero and negative fall back to the default (unlike
-// MaxOrderCents where zero is a deliberate off-switch) because a zero
-// threshold would sweep every requires_action row on the first tick and
-// race the customer's in-progress challenge.
-func TestLoadAbandoned3DSThresholdMinutes(t *testing.T) {
-	cases := []struct {
-		name string
-		env  string // "" means unset
-		want int
-	}{
-		{"empty falls back to default", "", 30},
-		{"valid override", "45", 45},
-		{"zero falls back to default", "0", 30},
-		{"negative falls back to default", "-5", 30},
-		{"garbage falls back to default", "half an hour", 30},
-		{"valid minimum (warns)", "1", 1},
-	}
-
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			t.Setenv("ABANDONED_3DS_THRESHOLD_MINUTES", tc.env)
-			got := loadAbandoned3DSThresholdMinutes()
-			if got != tc.want {
-				t.Errorf("loadAbandoned3DSThresholdMinutes() = %d, want %d", got, tc.want)
-			}
-		})
-	}
-}

pkg/config/doc.go

@@ -1,3 +0,0 @@
-// Package config reads everything out of the environment so secrets and
-// settings stay out of the source code.
-package config

pkg/database/doc.go

@@ -1,3 +0,0 @@
-// Package database opens the SQLite connection, runs the migrations, and
-// drops in some seed data so the shop isn't empty on a fresh boot.
-package database

pkg/database/migrate.go

@@ -3,8 +3,6 @@ package database
 import (
 	"fmt"
 	"log"
-	"time"
-
 	"terminalShop/pkg/models"
 
 	"gorm.io/gorm"
@@ -26,23 +24,10 @@ func Migrate(db *gorm.DB) error {
 		&models.OrderItem{}, // Line items within orders
 		&models.Address{},   // Saved addresses
 		&models.OrderEvent{},
-		&models.PayRedirect{}, // short-token -> stripe url store (10 min TTL)
 	); err != nil {
 		return fmt.Errorf("migration failed: %w", err)
 	}
 
-	if err := backfillCardStorageExpiration(db); err != nil {
-		return err
-	}
-
 	log.Println("Database migrations completed successfully")
 	return nil
 }
-
-func backfillCardStorageExpiration(db *gorm.DB) error {
-	expiresAt := models.CardStorageExpiresAt(time.Now())
-	if err := db.Model(&models.Card{}).Where("storage_expires_at IS NULL").Update("storage_expires_at", expiresAt).Error; err != nil {
-		return fmt.Errorf("card storage ttl backfill failed: %w", err)
-	}
-	return nil
-}

pkg/database/migrate_test.go

@@ -1,67 +0,0 @@
-package database
-
-import (
-	"os"
-	"testing"
-	"time"
-
-	"terminalShop/pkg/models"
-)
-
-func TestBackfillCardStorageExpiration_FillsNullRowsOnly(t *testing.T) {
-	testDB := "test_backfill.db"
-	defer func() { _ = os.Remove(testDB) }()
-	defer ResetForTesting()
-
-	db, err := Connect(testDB)
-	if err != nil {
-		t.Fatalf("connect: %v", err)
-	}
-	if err := Migrate(db); err != nil {
-		t.Fatalf("migrate: %v", err)
-	}
-
-	user := models.User{
-		SSHKeyFingerprint: "SHA256:backfill",
-		SSHPublicKey:      "ssh-ed25519 AAAA backfill",
-		Name:              "Backfill",
-		Email:             "backfill@example.com",
-	}
-	if err := db.Create(&user).Error; err != nil {
-		t.Fatalf("seed user: %v", err)
-	}
-
-	legacy := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_legacy", Last4: "0000",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030,
-	}
-	if err := db.Create(&legacy).Error; err != nil {
-		t.Fatalf("seed legacy: %v", err)
-	}
-
-	fixed := time.Date(2030, 1, 1, 0, 0, 0, 0, time.UTC)
-	preset := models.Card{
-		UserID: user.ID, StripePaymentID: "pm_preset", Last4: "9999",
-		Brand: "Visa", ExpMonth: 1, ExpYear: 2030, StorageExpiresAt: &fixed,
-	}
-	if err := db.Create(&preset).Error; err != nil {
-		t.Fatalf("ssed preset: %v", err)
-	}
-	if err := backfillCardStorageExpiration(db); err != nil {
-		t.Fatalf("seed preset: %v", err)
-	}
-
-	var reloadedLegacy, reloadedPreset models.Card
-	if err := db.First(&reloadedLegacy, legacy.ID).Error; err != nil {
-		t.Fatalf("reload legacy: %v", err)
-	}
-	if err := db.First(&reloadedPreset, preset.ID).Error; err != nil {
-		t.Fatalf("reload preset: %v", err)
-	}
-	if reloadedLegacy.StorageExpiresAt == nil {
-		t.Fatalf("legacy card storage_expires_at still NULL after backfill")
-	}
-	if reloadedPreset.StorageExpiresAt == nil || !reloadedPreset.StorageExpiresAt.Equal(fixed) {
-		t.Fatalf("preset card storage_expires_at was overwritten: %v", reloadedPreset.StorageExpiresAt)
-	}
-}

pkg/database/seed.go

@@ -4,9 +4,8 @@ import (
 	"fmt"
 	"log"
 
-	"terminalShop/pkg/models"
-
 	"gorm.io/gorm"
+	"terminalShop/pkg/models"
 )
 
 // Seed populates the database with initial data
@@ -26,60 +25,54 @@ func Seed(db *gorm.DB) error {
 		{
 			Name:        "Espresso",
 			RoastType:   "Dark Roast",
-			RoastLevel:  5,
 			Ounces:      2,
 			BeanType:    "Arabica",
-			Price:       1800, // $18.00
+			Price:       350, // $3.50
 			Color:       "#8B4513",
 			Description: "Bold and intense coffee with a rich crema",
 		},
 		{
 			Name:        "Americano",
 			RoastType:   "Medium Roast",
-			RoastLevel:  3,
 			Ounces:      8,
 			BeanType:    "Arabica",
-			Price:       2200, // $22.00
+			Price:       400, // $4.00
 			Color:       "#A0522D",
 			Description: "Smooth and balanced espresso diluted with hot water",
 		},
 		{
 			Name:        "Cappuccino",
 			RoastType:   "Medium Roast",
-			RoastLevel:  3,
 			Ounces:      6,
 			BeanType:    "Arabica",
-			Price:       2200, // $22.00
+			Price:       450, // $4.50
 			Color:       "#C4A574",
 			Description: "Espresso with steamed milk and a thick layer of foam",
 		},
 		{
 			Name:        "Latte",
 			RoastType:   "Medium Roast",
-			RoastLevel:  2,
 			Ounces:      12,
 			BeanType:    "Arabica",
-			Price:       2500, // $25.00
+			Price:       500, // $5.00
 			Color:       "#D2B48C",
 			Description: "Creamy espresso with plenty of steamed milk and a touch of foam",
 		},
 		{
 			Name:        "Mocha",
 			RoastType:   "Dark Roast",
-			RoastLevel:  4,
 			Ounces:      12,
 			BeanType:    "Arabica",
-			Price:       3000, // $30.00
+			Price:       550, // $5.50
 			Color:       "#8B4513",
 			Description: "Chocolate and espresso combined with steamed milk. Sweet and indulgent.",
 		},
 		{
 			Name:        "Macchiato",
 			RoastType:   "Dark Roast",
-			RoastLevel:  4,
 			Ounces:      3,
 			BeanType:    "Robusta Blend",
-			Price:       1800, // $18.00
+			Price:       425, // $4.25
 			Color:       "#DAA520",
 			Description: "Espresso 'marked' with a dollop of foamed milk. Small but mighty, like a tiny caffeinated warrior.",
 		},

pkg/models/card.go

@@ -6,25 +6,21 @@ import (
 	"gorm.io/gorm"
 )
 
-const cardStorageTTL = 180 * 24 * time.Hour
-
 // Card represents a saved payment method linked to a Stripe token.
 // The actual card details live on Stripe's servers — we only store
 // a reference and display info (last 4 digits, brand).
 type Card struct {
-	ID               uint           `gorm:"primaryKey" json:"id"`
-	UserID           uint           `gorm:"not null;index" json:"user_id"`
-	StripePaymentID  string         `gorm:"size:255;not null" json:"-"`   // Stripe payment method or token ID
-	Last4            string         `gorm:"size:4;not null" json:"last4"` // Last 4 digits for display
-	Brand            string         `gorm:"size:50" json:"brand"`         // Visa, Mastercard, etc.
-	ExpMonth         int            `gorm:"not null" json:"exp_month"`
-	ExpYear          int            `gorm:"not null" json:"exp_year"`
-	IsDefault        bool           `gorm:"default:false" json:"is_default"` // User's preferred card
-	CreatedAt        time.Time      `json:"created_at"`
-	UpdatedAt        time.Time      `json:"updated_at"`
-	DeletedAt        gorm.DeletedAt `gorm:"index" json:"-"`
-	LastUsedAt       *time.Time     `json:"last_used_at,omitempty"`
-	StorageExpiresAt *time.Time     `gorm:"index" json:"storage_expires_at,omitempty"`
+	ID              uint           `gorm:"primaryKey" json:"id"`
+	UserID          uint           `gorm:"not null;index" json:"user_id"`
+	StripePaymentID string         `gorm:"size:255;not null" json:"-"`   // Stripe payment method or token ID
+	Last4           string         `gorm:"size:4;not null" json:"last4"` // Last 4 digits for display
+	Brand           string         `gorm:"size:50" json:"brand"`         // Visa, Mastercard, etc.
+	ExpMonth        int            `gorm:"not null" json:"exp_month"`
+	ExpYear         int            `gorm:"not null" json:"exp_year"`
+	IsDefault       bool           `gorm:"default:false" json:"is_default"` // User's preferred card
+	CreatedAt       time.Time      `json:"created_at"`
+	UpdatedAt       time.Time      `json:"updated_at"`
+	DeletedAt       gorm.DeletedAt `gorm:"index" json:"-"`
 
 	// Associations
 	User User `gorm:"foreignKey:UserID" json:"-"`
@@ -34,20 +30,3 @@ type Card struct {
 func (Card) TableName() string {
 	return "cards"
 }
-
-// CardStorageExpiresAt returns the inactivity expiration for a saved card
-func CardStorageExpiresAt(now time.Time) *time.Time {
-	expiresAt := now.Add(cardStorageTTL)
-	return &expiresAt
-}
-
-// InitializeStorageTTL sets the initial retention deadline without marking
-// the card as used for payment
-func (c *Card) InitializeStorageTTL(now time.Time) {
-	c.StorageExpiresAt = CardStorageExpiresAt(now)
-}
-
-// IsStorageExpired reports whether the saved card retention deadline elapsed
-func (c *Card) IsStorageExpired(now time.Time) bool {
-	return c.StorageExpiresAt != nil && !c.StorageExpiresAt.After(now)
-}

pkg/models/card_test.go

@@ -1,26 +0,0 @@
-package models
-
-import (
-	"testing"
-	"time"
-)
-
-func TestCardStorageTTL(t *testing.T) {
-	now := time.Date(2026, 6, 2, 12, 0, 0, 0, time.UTC)
-
-	var card Card
-	card.InitializeStorageTTL(now)
-
-	if card.LastUsedAt != nil {
-		t.Fatalf("InitializeStorageTTL should not mark card as used")
-	}
-	if card.StorageExpiresAt == nil || !card.StorageExpiresAt.Equal(now.Add(cardStorageTTL)) {
-		t.Fatalf("unexpected initial expiration: %v", card.StorageExpiresAt)
-	}
-	if card.IsStorageExpired(now.Add(cardStorageTTL - time.Second)) {
-		t.Fatalf("card expired before ttl elapsed")
-	}
-	if !card.IsStorageExpired(now.Add(cardStorageTTL)) {
-		t.Fatalf("card should expire at ttl boundary")
-	}
-}

pkg/models/coffee.go

@@ -11,7 +11,6 @@ type Coffee struct {
 	ID          uint           `gorm:"primaryKey" json:"id"`
 	Name        string         `gorm:"size:255;not null" json:"name"`
 	RoastType   string         `gorm:"size:100" json:"roast_type"`
-	RoastLevel  int            `json:"roast_level"` // 1-5 roast-intensity
 	Ounces      int            `json:"ounces"`
 	BeanType    string         `gorm:"size:100" json:"bean_type"`
 	Price       int            `gorm:"not null" json:"price"`
@@ -33,7 +32,6 @@ var AccountMenuItems = []string{
 	"order history",
 	"addresses",
 	"cards",
-	"spend limit",
 	"faq",
 	"about",
 }

pkg/models/doc.go

@@ -1,3 +0,0 @@
-// Package models is the shared vocabulary of the app: coffee, carts, orders,
-// addresses, cards, users, and the other nouns everything passes around.
-package models

pkg/models/order.go

@@ -10,14 +10,13 @@ import (
 type OrderStatus string
 
 const (
-	OrderStatusPending        OrderStatus = "pending"
-	OrderStatusRequiresAction OrderStatus = "requires_action"
-	OrderStatusPaid           OrderStatus = "paid"
-	OrderStatusShipped        OrderStatus = "shipped"
-	OrderStatusDelivered      OrderStatus = "delivered"
-	OrderStatusCancelled      OrderStatus = "cancelled"
-	OrderStatusRefunded       OrderStatus = "refunded"
-	OrderStatusFailed         OrderStatus = "failed"
+	OrderStatusPending   OrderStatus = "pending"
+	OrderStatusPaid      OrderStatus = "paid"
+	OrderStatusShipped   OrderStatus = "shipped"
+	OrderStatusDelivered OrderStatus = "delivered"
+	OrderStatusCancelled OrderStatus = "cancelled"
+	OrderStatusRefunded  OrderStatus = "refunded"
+	OrderStatusFailed    OrderStatus = "failed"
 )
 
 type TrackingStatus string

pkg/models/order_display.go

@@ -35,8 +35,6 @@ func (order *Order) DisplayState() string {
 	switch order.Status {
 	case OrderStatusPending:
 		return "Awaiting payment"
-	case OrderStatusRequiresAction:
-		return "Awaiting authentication"
 	case OrderStatusPaid:
 		if order.TrackingNumber == "" {
 			return "Paid * awaiting label"
@@ -79,8 +77,6 @@ func (order *Order) DisplayKind() DisplayKind {
 	switch order.Status {
 	case OrderStatusPending:
 		return DisplayKindNeutral
-	case OrderStatusRequiresAction:
-		return DisplayKindNeutral
 	case OrderStatusPaid:
 		return DisplayKindAccent
 	case OrderStatusShipped:

pkg/models/order_display_test.go

@@ -14,7 +14,6 @@ func TestOrderDisplayState(t *testing.T) {
 		kind  DisplayKind
 	}{
 		{"pending", Order{Status: OrderStatusPending}, "Awaiting payment", DisplayKindNeutral},
-		{"requires_action", Order{Status: OrderStatusRequiresAction}, "Awaiting authentication", DisplayKindNeutral},
 		{"paid no tracking", Order{Status: OrderStatusPaid}, "Paid * awaiting label", DisplayKindAccent},
 		{"paid with tracking, no event", Order{Status: OrderStatusPaid, TrackingNumber: "12999"}, "Paid", DisplayKindAccent},
 		{"Paid pre-transit", Order{Status: OrderStatusPaid, TrackingNumber: "12999", TrackingStatus: TrackingStatusPreTransit}, "Paid * ready to ship", DisplayKindAccent},

pkg/models/pay_redirect.go

@@ -1,23 +0,0 @@
-package models
-
-import "time"
-
-// PayRedirect maps a short token to a stripe hosted url with a TTL.
-// survives api restarts so a customer mid-3Ds authentication still
-// lands on the bank-hosted challenge page after a deploy or crash
-type PayRedirect struct {
-	Token     string    `gorm:"primaryKey;size:64" json:"token"`
-	URL       string    `gorm:"type:text;not null" json:"url"`
-	Purpose   string    `gorm:"size:32;not null" json:"purpose"`
-	CreatedAt time.Time `json:"created_at"`
-	ExpiresAt time.Time `gorm:"index" json:"expires_at"`
-}
-
-const (
-	RedirectPurposeCheckout3DS = "checkout_3ds"
-	RedirectPurposeAddCard     = "add_card"
-)
-
-func (PayRedirect) TableName() string {
-	return "pay_redirects"
-}

pkg/models/user.go

@@ -9,25 +9,16 @@ import (
 // User represents a user authenticated via SSH public key
 // No passwords - SSH key is the ONLY authentication method (matches terminal.shop exactly)
 type User struct {
-	ID                uint   `gorm:"primaryKey" json:"id"`
-	SSHKeyFingerprint string `gorm:"uniqueIndex;size:100;not null" json:"ssh_key_fingerprint"` // SHA256 fingerprint - PRIMARY identifier
-	SSHPublicKey      string `gorm:"uniqueIndex;type:text;not null" json:"-"`                  // Full SSH public key
-	Name              string `gorm:"size:255" json:"name,omitempty"`                           // Real name (for shipping labels)
-	Email             string `gorm:"size:255" json:"email,omitempty"`                          // Email (for receipts)
-	Anonymous         bool   `gorm:"default:false" json:"anonymous"`                           // True if connected without SSH key
-	StripeCustomerID  string `gorm:"size:255" json:"-"`
-	// MaxOrderCents is an optional per-user override of the global MAX_ORDER_CENTS
-	// spend cap. It may raise OR lower the global cap — both directions are
-	// intentional (e.g. a vetted corporate buyer gets a higher ceiling; a flagged
-	// account gets a lower one). States: nil = inherit the global; explicit 0 =
-	// per-user off-switch (same semantics as the global); >0 = custom ceiling. A
-	// negative value is treated as "no override" (falls back to global) with a
-	// warning — see ConvertCart. Operator-set out-of-band; kept out of API payloads.
-	MaxOrderCents  *int           `json:"-"`
-	SelfLimitCents *int           `json:"self_limit_cents,omitempty"`
-	CreatedAt      time.Time      `json:"created_at"`
-	UpdatedAt      time.Time      `json:"updated_at"`
-	DeletedAt      gorm.DeletedAt `gorm:"index" json:"-"`
+	ID                uint           `gorm:"primaryKey" json:"id"`
+	SSHKeyFingerprint string         `gorm:"uniqueIndex;size:100;not null" json:"ssh_key_fingerprint"` // SHA256 fingerprint - PRIMARY identifier
+	SSHPublicKey      string         `gorm:"uniqueIndex;type:text;not null" json:"-"`                  // Full SSH public key
+	Name              string         `gorm:"size:255" json:"name,omitempty"`                           // Real name (for shipping labels)
+	Email             string         `gorm:"size:255" json:"email,omitempty"`                          // Email (for receipts)
+	Anonymous         bool           `gorm:"default:false" json:"anonymous"`                           // True if connected without SSH key
+	StripeCustomerID  string         `gorm:"size:255" json:"-"`
+	CreatedAt         time.Time      `json:"created_at"`
+	UpdatedAt         time.Time      `json:"updated_at"`
+	DeletedAt         gorm.DeletedAt `gorm:"index" json:"-"`
 }
 
 // TableName specifies the table name for the User model
@@ -41,7 +32,6 @@ type PublicUser struct {
 	SSHKeyFingerprint string    `json:"ssh_key_fingerprint"`
 	Name              string    `json:"name,omitempty"`
 	Email             string    `json:"email,omitempty"`
-	SelfLimitCents    *int      `json:"self_limit_cents,omitempty"`
 	CreatedAt         time.Time `json:"created_at"`
 }
 
@@ -52,7 +42,6 @@ func (u *User) ToPublic() PublicUser {
 		SSHKeyFingerprint: u.SSHKeyFingerprint,
 		Name:              u.Name,
 		Email:             u.Email,
-		SelfLimitCents:    u.SelfLimitCents,
 		CreatedAt:         u.CreatedAt,
 	}
 }

pkg/observability/doc.go

@@ -1,3 +0,0 @@
-// Package observability sets up tracing and structured logs so that when
-// something breaks at 3am you stand a chance of figuring out why.
-package observability

pkg/shipping/doc.go

@@ -1,3 +0,0 @@
-// Package shipping holds the plain shipping types that the rest of the app
-// passes back and forth.
-package shipping

pkg/shippo/doc.go

@@ -1,2 +0,0 @@
-// Package shippo talks to the Shippo API for shipping rates and labels.
-package shippo

pkg/stripeclient/doc.go

@@ -1,3 +0,0 @@
-// Package stripeclient wires up the Stripe SDK once at startup (with tracing
-// baked in) so everyone else can just make calls.
-package stripeclient

pkg/tui/account.go

@@ -1,11 +1,6 @@
 package tui
 
 import (
-	"fmt"
-	"strconv"
-	"strings"
-
-	"charm.land/bubbles/v2/textinput"
 	"charm.land/bubbles/v2/viewport"
 	tea "charm.land/bubbletea/v2"
 	"charm.land/lipgloss/v2"
@@ -13,52 +8,36 @@ import (
 	"terminalShop/pkg/models"
 )
 
-// accountBodyHeight returns the inner content height of the account body
-// panels. The body is quantized to whole order cards so the menu panel's
-// bottom border lines up exactly with the last visible card; the two gap
-// rows around the body host the up/down scroll arrows.
-func (m Model) accountBodyHeight() int {
+// updateAccountViewport initializes or resizes the detail viewport for the account page.
+// Follows the reference pattern: each page owns its own viewport(s).
+func (m Model) updateAccountViewport() Model {
+	// Match the reference: only subtract header + footer, no extra margins
+	// (account is a viewport page — views.go renders it without margin padding)
 	headerHeight := lipgloss.Height(m.BuildHeader())
 	footerHeight := lipgloss.Height(m.BuildFooter())
-	budget := m.heightContainer - headerHeight - footerHeight - 2
-	cards := budget / orderCardHeight
-	cards = max(cards, 1)
-	return cards*orderCardHeight - 2
-}
+	verticalMarginHeight := headerHeight + footerHeight
 
-// accountDetailWidth returns the width of the unboxed detail area: the chrome
-// width minus the menu panel and the gap. The detail side has no outer panel
-// (its content draws its own boxes), so it reclaims the border + padding.
-func (m Model) accountDetailWidth() int {
-	contentW, menuW, _, _ := m.shopLayout()
+	availableHeight := m.heightContainer - verticalMarginHeight
+
+	leftWidth := 18
+	rightWidth := m.widthContent - leftWidth - 2
+	detailWidth := rightWidth
 	if m.size < large {
-		return contentW
+		detailWidth = m.widthContent
+		// In stacked mode, reduce available height by the left panel
+		leftPanelHeight := len(models.AccountMenuItems) + 1
+		availableHeight -= leftPanelHeight
 	}
-	return contentW - (menuW + 4) - 1
-}
-
-// updateAccountViewport initializes or resizes the detail viewport for the account page.
-// The viewport spans the unboxed detail area to the right of the menu panel.
-func (m Model) updateAccountViewport() Model {
-	detailW := m.accountDetailWidth()
-	// +2: no panel on the detail side, so the viewport spans the same rows
-	// as the menu panel including its border rows — tops and bottoms align.
-	availableHeight := m.accountBodyHeight() + 2
-	if m.size < large {
-		// Stacked: the menu panel sits above the detail area
-		menuPanelHeight := len(models.AccountMenuItems) + 2
-		availableHeight -= menuPanelHeight
-		if availableHeight < 3 {
-			availableHeight = 3
-		}
+	if availableHeight < 3 {
+		availableHeight = 3
 	}
 
 	if !m.account.viewportReady {
-		m.account.detailViewport = viewport.New(viewport.WithWidth(detailW), viewport.WithHeight(availableHeight))
+		m.account.detailViewport = viewport.New(viewport.WithWidth(detailWidth), viewport.WithHeight(availableHeight))
 		m.account.detailViewport.KeyMap = modifiedKeyMap
 		m.account.viewportReady = true
 	} else {
-		m.account.detailViewport.SetWidth(detailW)
+		m.account.detailViewport.SetWidth(detailWidth)
 		m.account.detailViewport.SetHeight(availableHeight)
 	}
 
@@ -67,7 +46,12 @@ func (m Model) updateAccountViewport() Model {
 
 // getAccountDetailContent generates the content string for the current detail panel.
 func (m Model) getAccountDetailContent() string {
-	detailContentWidth := m.accountDetailWidth()
+	leftWidth := 18
+	rightWidth := m.widthContent - leftWidth - 2
+	detailContentWidth := rightWidth - 2
+	if m.size < large {
+		detailContentWidth = m.widthContent - 2
+	}
 
 	if m.account.cursor < 0 || m.account.cursor >= len(models.AccountMenuItems) {
 		return ""
@@ -83,9 +67,8 @@ func (m Model) getAccountDetailContent() string {
 		return m.AddressesView(detailContentWidth)
 	case "cards":
 		return m.CardsView(detailContentWidth)
-	case "spend limit":
-		return m.SpendLimitView(detailContentWidth)
 	case "faq":
+		titleStyle := m.theme.TextAccent().Bold(true).MarginBottom(2)
 		questionStyle := m.theme.TextHighlight().Bold(true)
 		contentStyle := m.theme.TextBody().Width(detailContentWidth)
 		faqContent := ""
@@ -96,7 +79,7 @@ func (m Model) getAccountDetailContent() string {
 				faqContent += "\n\n"
 			}
 		}
-		detailView := faqContent
+		detailView := titleStyle.Render("FAQ") + "\n\n" + faqContent
 		if !m.account.faqFocused {
 			hintStyle := m.theme.TextDim()
 			detailView += "\n\n" + hintStyle.Render("enter: scroll faq")
@@ -120,25 +103,19 @@ func (m Model) scrollToAccountDetailItem() Model {
 
 	switch {
 	case m.account.orderViewState == 1:
-		// Order list uses whole-card windowing instead of viewport scroll:
-		// shift the window just enough to keep the cursor's card visible.
-		page := m.orderListPageSize()
-		if m.account.orderCursor < m.account.orderWindowStart {
-			m.account.orderWindowStart = m.account.orderCursor
-		}
-		if m.account.orderCursor >= m.account.orderWindowStart+page {
-			m.account.orderWindowStart = m.account.orderCursor - page + 1
-		}
-		m.account.detailViewport.GotoTop()
-		return m
-	case m.account.addressListFocused:
-		// Titles were removed from the detail views, lists start at the top
+		// No title in list mode, cards joined with JoinVertical (no gaps)
+		// Card: border(2) + content(2) + PaddingLeft only = 4 lines
 		headerOffset = 0
+		itemHeight = 4
+		itemCount = len(m.currentOrderList())
+		selectedIndex = m.account.orderCursor
+	case m.account.addressListFocused:
+		headerOffset = 3
 		itemHeight = 5
 		itemCount = len(m.SavedAddresses)
 		selectedIndex = m.account.addressCursor
 	case m.account.cardListFocused:
-		headerOffset = 0
+		headerOffset = 3
 		itemHeight = 4
 		itemCount = len(m.SavedCards)
 		selectedIndex = m.account.cardCursor
@@ -166,30 +143,23 @@ func (m Model) scrollToAccountDetailItem() Model {
 	return m
 }
 
-func (m Model) BuildAccountView() string {
-	_, menuW, _, _ := m.shopLayout()
+func (m Model) BuildAccountView(availableHeight int) string {
+	leftWidth := 18
 
-	// Left panel: menu items. The highlight is blue while the user navigates
-	// the menu, and falls back to the gray pill when focus has moved into the
-	// detail area (browsing orders, managing addresses/cards, scrolling faq).
-	focusedInside := m.account.orderViewState > 0 || m.account.addressListFocused ||
-		m.account.cardListFocused || m.account.faqFocused || m.account.spendLimitFocused
-	pillBg := m.theme.Highlight()
-	if focusedInside {
-		pillBg = cPill
-	}
-	var menu []string
+	// Build the left panel (menu items)
+	leftPanel := ""
 	for i, item := range models.AccountMenuItems {
 		if m.account.cursor == i {
-			menu = append(menu, lipgloss.NewStyle().Width(menuW).
-				Background(pillBg).Foreground(cWhite).Bold(true).
-				Render(" "+item))
+			style := m.theme.Base().Background(m.theme.Highlight()).Foreground(m.theme.Accent()).Padding(0, 1).Width(leftWidth - 2).Align(lipgloss.Left)
+			leftPanel += style.Render(item) + "\n"
 		} else {
-			menu = append(menu, lipgloss.NewStyle().Width(menuW).
-				Render(" "+pBody.Render(item)))
+			style := m.theme.TextBody().Padding(0, 1).Width(leftWidth - 2).Align(lipgloss.Left)
+			leftPanel += style.Render(item) + "\n"
 		}
 	}
-	menuContent := lipgloss.JoinVertical(lipgloss.Left, menu...)
+
+	leftContainer := m.theme.Base().
+		Width(leftWidth)
 
 	// Generate detail content and set it on the viewport
 	detailContent := m.getAccountDetailContent()
@@ -198,43 +168,25 @@ func (m Model) BuildAccountView() string {
 	// Viewport handles scrolling/clipping — no manual line-slicing needed
 	detailRendered := m.account.detailViewport.View()
 
-	// Responsive layout: menu panel beside the unboxed detail area on large,
-	// stacked on small/medium. The detail side draws its own item boxes.
-	var body string
+	// Responsive layout: side-by-side on large, stacked on small/medium
 	if m.size < large {
-		body = lipgloss.JoinVertical(
+		return lipgloss.JoinVertical(
 			lipgloss.Left,
-			panel(menuW, 0, menuContent),
-			detailRendered,
-		)
-	} else {
-		bodyH := m.accountBodyHeight()
-		body = lipgloss.JoinHorizontal(
-			lipgloss.Top,
-			panel(menuW, bodyH, menuContent),
-			" ",
+			leftContainer.Render(leftPanel),
 			detailRendered,
 		)
 	}
 
-	// Blank rows separate the body from the header and footer boxes. When the
-	// windowed order list has hidden items, the arrows occupy those gap rows,
-	// centered over the card column, so the cards themselves always span
-	// exactly the menu panel's rows — top and bottom borders aligned.
-	topGap := ""
-	if above := m.orderHiddenAbove(); above > 0 && m.size >= large {
-		topGap = strings.Repeat(" ", menuW+5) +
-			orderScrollIndicator("↑", above, m.accountDetailWidth())
-	}
-	bottomGap := ""
-	if below := m.orderHiddenBelow(); below > 0 && m.size >= large {
-		bottomGap = strings.Repeat(" ", menuW+5) +
-			orderScrollIndicator("↓", below, m.accountDetailWidth())
-	}
-	return topGap + "\n" + body + "\n" + bottomGap
+	return lipgloss.JoinHorizontal(
+		lipgloss.Top,
+		leftContainer.Render(leftPanel),
+		"  ",
+		detailRendered,
+	)
 }
 
 func (m Model) AboutView(width int) string {
+	titleStyle := m.theme.TextAccent().Bold(true).MarginBottom(2)
 	contentStyle := m.theme.TextBody().Width(width)
 	// USE this if wanting to add a corp name later
 	// accentStyle := m.theme.TextHighlight().Bold(true)
@@ -256,29 +208,10 @@ func (m Model) AboutView(width int) string {
 		width,
 	)) + "\n"
 
-	return aboutContent
+	return titleStyle.Render("About") + "\n\n" + aboutContent
 }
 
 func (m Model) AccountUpdate(msg tea.Msg) (Model, tea.Cmd) {
-	// Async result of a spend-limit save (delivered here because the account
-	// page is active when the command resolves).
-	if saved, ok := msg.(spendLimitSavedMsg); ok {
-		m.account.spendLimitSaving = false
-		if saved.Err != nil {
-			m.account.spendLimitErr = friendlySpendLimitError(saved.Err)
-			return m, nil
-		}
-		if m.User != nil {
-			m.User.SelfLimitCents = saved.Cents
-		}
-		m.account.spendLimitFocused = false
-		m.account.spendLimitInput.Blur()
-		m.account.spendLimitErr = ""
-		m.footer = defaultAccountFooter()
-		m.notice = &VisibleNotice{message: "Spend limit updated"}
-		return m, nil
-	}
-
 	keyMsg, ok := msg.(tea.KeyMsg)
 	if !ok {
 		// Pass non-key messages to viewport (e.g. window resize)
@@ -287,24 +220,6 @@ func (m Model) AccountUpdate(msg tea.Msg) (Model, tea.Cmd) {
 		return m, cmd
 	}
 
-	// While the spend-limit input is focused it owns the keyboard: enter saves,
-	// esc cancels, everything else edits the field.
-	if m.account.spendLimitFocused {
-		switch keyMsg.String() {
-		case "esc":
-			m.account.spendLimitFocused = false
-			m.account.spendLimitInput.Blur()
-			m.account.spendLimitErr = ""
-			m.footer = defaultAccountFooter()
-			return m, nil
-		case "enter":
-			return m.submitSpendLimit()
-		}
-		var cmd tea.Cmd
-		m.account.spendLimitInput, cmd = m.account.spendLimitInput.Update(msg)
-		return m, cmd
-	}
-
 	selectedItem := ""
 	if m.account.cursor < len(models.AccountMenuItems) {
 		selectedItem = models.AccountMenuItems[m.account.cursor]
@@ -420,7 +335,6 @@ func (m Model) AccountUpdate(msg tea.Msg) (Model, tea.Cmd) {
 				case 0:
 					m.account.orderViewState = 1
 					m.account.orderCursor = 0
-					m.account.orderWindowStart = 0
 					m.account.detailViewport.GotoTop()
 					m.footer = []footerCommand{
 						{key: "j/k", value: "orders"},
@@ -463,26 +377,6 @@ func (m Model) AccountUpdate(msg tea.Msg) (Model, tea.Cmd) {
 					{key: "esc", value: "back"},
 				}
 			}
-		case "spend limit":
-			if !m.account.spendLimitFocused {
-				ti := textinput.New()
-				ti.Prompt = "$"
-				ti.Placeholder = "dollars (blank = no limit)"
-				ti.CharLimit = 12
-				// Prefill with the current limit so the user edits rather than retypes.
-				if m.User != nil && m.User.SelfLimitCents != nil {
-					ti.SetValue(formatCentsDollars(*m.User.SelfLimitCents))
-				}
-				cmd := ti.Focus()
-				m.account.spendLimitInput = ti
-				m.account.spendLimitFocused = true
-				m.account.spendLimitErr = ""
-				m.footer = []footerCommand{
-					{key: "enter", value: "save"},
-					{key: "esc", value: "cancel"},
-				}
-				return m, cmd
-			}
 		case "faq":
 			if !m.account.faqFocused {
 				m.account.faqFocused = true
@@ -498,7 +392,14 @@ func (m Model) AccountUpdate(msg tea.Msg) (Model, tea.Cmd) {
 		}
 
 	case "esc":
-		accountDefaultFooter := defaultAccountFooter()
+		accountDefaultFooter := []footerCommand{
+			{key: "j/k", value: "navigate"},
+			{key: "enter", value: "select"},
+			{key: "s", value: "shop"},
+			{key: "c", value: "cart"},
+			{key: "?", value: "help"},
+			{key: "q", value: "quit"},
+		}
 		if m.account.addressDeleting != nil {
 			m.account.addressDeleting = nil
 		} else if m.account.addressListFocused {
@@ -538,158 +439,3 @@ func (m Model) AccountUpdate(msg tea.Msg) (Model, tea.Cmd) {
 	}
 	return m, nil
 }
-
-// spendLimitSavedMsg carries the result of an async SetSpendLimit call back to
-// AccountUpdate. Cents is the value that was sent (echoed so the view can update
-// without a refetch); Err is non-nil when the save failed.
-type spendLimitSavedMsg struct {
-	Cents *int
-	Err   error
-}
-
-// SpendLimitView renders the self-service spend-limit panel: the current limit,
-// and — when focused — the editable input. Layout follows the label/box idiom
-// used by the refund composer (pkg/tui/refund.go).
-func (m Model) SpendLimitView(width int) string {
-	labelStyle := m.theme.TextLabel()
-	bodyStyle := m.theme.TextBody().Width(width)
-	hintStyle := m.theme.TextDim()
-
-	current := "no limit set"
-	if m.User != nil && m.User.SelfLimitCents != nil {
-		current = "$" + formatCentsDollars(*m.User.SelfLimitCents)
-	}
-
-	out := bodyStyle.Render(wordWrap(
-		"Set your own spending limit. It can only lower the cap on your account, never raise it. Leave blank to remove your limit; 0 blocks all orders.",
-		width,
-	)) + "\n\n"
-	out += labelStyle.Render("Current limit") + "\n"
-	out += m.theme.TextAccent().Render(current) + "\n\n"
-
-	if !m.account.spendLimitFocused {
-		return out + hintStyle.Render("enter: edit limit")
-	}
-
-	box := lipgloss.NewStyle().
-		Border(lipgloss.RoundedBorder()).
-		BorderForeground(m.theme.Highlight()).
-		Width(max(1, width-2))
-	m.account.spendLimitInput.SetWidth(max(1, width-3))
-	out += labelStyle.Render("New limit (dollars)") + "\n"
-	out += box.Render(m.account.spendLimitInput.View())
-	switch {
-	case m.account.spendLimitSaving:
-		out += "\n" + m.theme.TextAccent().Render("saving...")
-	case m.account.spendLimitErr != "":
-		out += "\n" + m.theme.TextError().Render(m.account.spendLimitErr)
-	}
-	out += "\n" + hintStyle.Render("enter: save · esc: cancel")
-	return out
-}
-
-// submitSpendLimit validates the input and, if valid, fires the save command.
-// Validation mirrors the server's write-boundary rules so the user gets instant
-// feedback for the negative/non-numeric cases before any round-trip.
-func (m Model) submitSpendLimit() (Model, tea.Cmd) {
-	cents, err := parseSpendLimitInput(m.account.spendLimitInput.Value())
-	if err != nil {
-		m.account.spendLimitErr = err.Error()
-		return m, nil
-	}
-	m.account.spendLimitErr = ""
-	m.account.spendLimitSaving = true
-	return m, m.setSpendLimitCmd(cents)
-}
-
-// setSpendLimitCmd calls the API off the UI thread and reports back via
-// spendLimitSavedMsg. Mirrors the command shape of createRefundRequestCmd.
-func (m Model) setSpendLimitCmd(cents *int) tea.Cmd {
-	return func() tea.Msg {
-		if m.APIClient == nil || m.User == nil {
-			return spendLimitSavedMsg{Err: fmt.Errorf("not authenticated")}
-		}
-		err := m.APIClient.SetSpendLimit(cents)
-		return spendLimitSavedMsg{Cents: cents, Err: err}
-	}
-}
-
-// parseSpendLimitInput maps the raw dollar input to a *int of cents. Blank
-// clears the limit (nil -> revert to admin/global). "0" is a real "block
-// everything" ceiling, NOT a clear. Negative, non-numeric, or more-than-2-
-// decimal input is rejected. Parsed as integer cents (dollars*100 + cents) with
-// no float multiply, so an amount like 50.01 never loses a cent to binary
-// rounding. The server still stores cents (api/handlers/account.go).
-func parseSpendLimitInput(s string) (*int, error) {
-	s = strings.TrimSpace(s)
-	s = strings.TrimSpace(strings.TrimPrefix(s, "$"))
-	if s == "" {
-		return nil, nil
-	}
-	if strings.HasPrefix(s, "-") {
-		return nil, fmt.Errorf("limit cannot be negative")
-	}
-
-	whole, frac, hasDot := strings.Cut(s, ".")
-	if whole == "" {
-		whole = "0" // allow ".50"
-	}
-	dollars, err := strconv.Atoi(whole)
-	if err != nil {
-		return nil, fmt.Errorf("enter a dollar amount, e.g 25 or 25.50, or blank to clear")
-	}
-
-	cents := 0
-	if hasDot {
-		switch len(frac) {
-		case 0:
-			// trailing dot, e.g "25." -> treat as .00
-		case 1:
-			frac += "0" // "5" -> 50 cents
-			fallthrough
-		case 2:
-			cents, err = strconv.Atoi(frac)
-			if err != nil {
-				return nil, fmt.Errorf("enter a dollar amount, e.g 25 or 25.00, or blank to clear")
-			}
-		default:
-			return nil, fmt.Errorf("use at most two decimal places, e.g 25.00")
-		}
-	}
-
-	total := dollars*100 + cents
-	return &total, nil
-}
-
-// formatCentsDollars renders an integer cents value as a plain dollar string
-// (no leading "$"), e.g. 2500 -> "25.00", 50 -> "0.50". Used for the input
-// prefill and the current-limit display.
-func formatCentsDollars(cents int) string {
-	return fmt.Sprintf("%d.%02d", cents/100, cents%100)
-}
-
-// defaultAccountFooter is the account-menu footer shown when no sub-view owns
-// the keyboard. Extracted so the spend-limit save/cancel paths can restore it
-// without duplicating the slice.
-func defaultAccountFooter() []footerCommand {
-	return []footerCommand{
-		{key: "j/k", value: "navigate"},
-		{key: "enter", value: "select"},
-		{key: "s", value: "shop"},
-		{key: "c", value: "cart"},
-		{key: "?", value: "help"},
-		{key: "q", value: "quit"},
-	}
-}
-
-// friendlySpendLimitError turns a raw API error into one line of TUI copy.
-// SELF_LIMIT_ABOVE_CAP is the one case worth calling out specifically.
-func friendlySpendLimitError(err error) string {
-	if err == nil {
-		return ""
-	}
-	if strings.Contains(err.Error(), "SELF_LIMIT_ABOVE_CAP") {
-		return "limit can't exceed your account cap"
-	}
-	return "failed to save limit"
-}

pkg/tui/account_addresses.go

@@ -1,9 +1,10 @@
 package tui
 
 func (m Model) AddressesView(width int) string {
+	titleStyle := m.theme.TextAccent().Bold(true).MarginBottom(2)
 	contentStyle := m.theme.TextBody().Width(width)
 
-	lines := ""
+	lines := titleStyle.Render("Address") + "\n\n"
 	if len(m.SavedAddresses) == 0 {
 		lines += contentStyle.Render("No saved addresses")
 	} else {

pkg/tui/account_cards.go

@@ -5,9 +5,10 @@ import (
 )
 
 func (m Model) CardsView(width int) string {
+	titleSTyle := m.theme.TextAccent().Bold(true).MarginBottom(2)
 	contentStyle := m.theme.TextBody().Width(width)
 
-	lines := ""
+	lines := titleSTyle.Render("Cards") + "\n\n"
 	if m.SavedCardsIsEmpty() {
 		lines += contentStyle.Render("No saved cards")
 	} else {

pkg/tui/account_orders.go

@@ -10,11 +10,11 @@ import (
 )
 
 func (m Model) OrdersView(width int) string {
-	return m.orderListView(m.HistoryOrders(), width)
+	return m.orderListView("Order History", m.HistoryOrders(), width)
 }
 
 func (m Model) ActiveOrdersView(width int) string {
-	return m.orderListView(m.ActiveOrders(), width)
+	return m.orderListView("Active Orders", m.ActiveOrders(), width)
 }
 
 func (m Model) ActiveOrders() []models.Order {
@@ -65,95 +65,41 @@ func (m Model) currentOrderList() []models.Order {
 	return nil
 }
 
-// orderCardHeight is the rendered height of one order card:
-// border (2) + content lines (2), no vertical padding.
-const orderCardHeight = 4
-
-// orderListPageSize returns how many whole order cards fit in the detail
-// area. Both scroll arrows render outside the list, in the gap rows above
-// and below the body, so the cards use the full viewport height.
-func (m Model) orderListPageSize() int {
-	n := m.account.detailViewport.Height() / orderCardHeight
-	if n < 1 {
-		n = 1
-	}
-	return n
-}
-
-// orderHiddenAbove returns how many order cards are scrolled off above the
-// windowed list, or 0 when the windowed order list isn't showing.
-func (m Model) orderHiddenAbove() int {
-	if m.account.orderViewState != 1 || !m.OrdersLoaded {
-		return 0
-	}
-	orders := m.currentOrderList()
-	if len(orders) == 0 {
-		return 0
-	}
-	page := m.orderListPageSize()
-	start := m.account.orderWindowStart
-	if start > len(orders)-page {
-		start = len(orders) - page
-	}
-	if start < 0 {
-		start = 0
-	}
-	return start
-}
-
-// orderHiddenBelow returns how many order cards are scrolled off below the
-// windowed list, or 0 when the windowed order list isn't showing.
-func (m Model) orderHiddenBelow() int {
-	if m.account.orderViewState == 2 || !m.OrdersLoaded {
-		return 0
-	}
-	orders := m.currentOrderList()
-	if len(orders) == 0 {
-		return 0
-	}
-	below := len(orders) - (m.orderHiddenAbove() + m.orderListPageSize())
-	if below < 0 {
-		below = 0
-	}
-	return below
-}
-
-// orderScrollIndicator renders the dim "more items" arrow row, centered
-// across the card width.
-func orderScrollIndicator(arrow string, count, width int) string {
-	return pDim.Width(width).Align(lipgloss.Center).
-		Render(fmt.Sprintf("%s %d more", arrow, count))
-}
-
-func (m Model) orderListView(orders []models.Order, width int) string {
+func (m Model) orderListView(title string, orders []models.Order, width int) string {
+	titleStyle := m.theme.TextAccent().Bold(true).MarginBottom(1)
 	contentStyle := m.theme.TextBody().Width(width)
 
 	if !m.OrdersLoaded {
-		return contentStyle.Render("Loading orders...")
+		return titleStyle.Render(title) + "\n" + contentStyle.Render("Loading orders...")
 	}
 	if len(orders) == 0 {
-		return contentStyle.Render("No orders yet")
+		return titleStyle.Render(title) + "\n" + contentStyle.Render("No orders yet")
 	}
 	if m.account.orderViewState == 2 {
 		return m.buildOrderDetailView(orders[m.account.orderCursor], width)
 	}
 
-	// Whole-card windowing: render only fully-visible cards, never clipping a
-	// card mid-border. Both scroll arrows render in BuildAccountView's gap
-	// rows, so the cards span exactly the menu panel's rows.
-	page := m.orderListPageSize()
-	start := m.orderHiddenAbove()
-	end := start + page
-	if end > len(orders) {
-		end = len(orders)
+	boxWidth := width - 2
+
+	// Build cards and join vertically — no manual "\n" gaps means fixed spacing
+	var cards []string
+	for i, order := range orders {
+		isSelected := m.account.orderViewState == 1 && i == m.account.orderCursor
+		cards = append(cards, m.buildOrderCard(order, boxWidth, isSelected))
+	}
+	cardList := lipgloss.JoinVertical(lipgloss.Left, cards...)
+
+	// In preview mode (viewState 0), show title + hint
+	if m.account.orderViewState == 0 {
+		hintStyle := m.theme.TextDim()
+		return titleStyle.Render(title) + "\n" +
+			cardList + "\n" +
+			hintStyle.Render("enter: browse orders")
 	}
 
-	var rows []string
-	for i := start; i < end; i++ {
-		isSelected := m.account.orderViewState == 1 && i == m.account.orderCursor
-		rows = append(rows, m.buildOrderCard(orders[i], width, isSelected))
-	}
-	return lipgloss.JoinVertical(lipgloss.Left, rows...)
+	// In list browsing mode (viewState 1), just show cards — no title
+	// (the left panel menu already shows "order history" as selected)
+	return cardList
 }
 
 // buildOrderCard renders a single order as a bordered box with fixed height.

pkg/tui/account_test.go

@@ -1,119 +0,0 @@
-package tui
-
-import (
-	"testing"
-
-	tea "charm.land/bubbletea/v2"
-
-	"terminalShop/pkg/models"
-)
-
-func TestParseSpendLimitInput(t *testing.T) {
-	cases := []struct {
-		in      string
-		want    int
-		wantNil bool
-		wantErr bool
-	}{
-		{"", 0, true, false},             // blank clears
-		{"0", 0, false, false},           // $0 is block-all, NOT a clear
-		{"25", 2500, false, false},       // whole dollars
-		{"25.50", 2550, false, false},    // dollars + cents
-		{"25.5", 2550, false, false},     // one decimal => tenths
-		{"0.05", 5, false, false},        // sub-dollar
-		{" $25.00 ", 2500, false, false}, // strips $ and whitespace
-		{".50", 50, false, false},        // leading dot
-		{"-5", 0, false, true},           // negative rejected
-		{"abc", 0, false, true},          // non-numeric rejected
-		{"25.999", 0, false, true},       // too many decimals rejected
-	}
-	for _, tc := range cases {
-		got, err := parseSpendLimitInput(tc.in)
-		if tc.wantErr {
-			if err == nil {
-				t.Errorf("%q: want error, got value %v", tc.in, got)
-			}
-			continue
-		}
-		if err != nil {
-			t.Errorf("%q: unexpected error: %v", tc.in, err)
-			continue
-		}
-		if tc.wantNil {
-			if got != nil {
-				t.Errorf("%q: want nil, got %d", tc.in, *got)
-			}
-			continue
-		}
-		if got == nil || *got != tc.want {
-			t.Errorf("%q: want %d, got %v", tc.in, tc.want, got)
-		}
-	}
-}
-
-func TestSetSpendLimitCmd_NilClient(t *testing.T) {
-	m := NewModel("test")
-	m.APIClient = nil
-	cmd := m.setSpendLimitCmd(nil)
-	if cmd == nil {
-		t.Fatal("setSpendLimitCmd returned nil cmd")
-	}
-	saved, ok := cmd().(spendLimitSavedMsg)
-	if !ok {
-		t.Fatalf("expected spendLimitSavedMsg, got %T", cmd())
-	}
-	if saved.Err == nil {
-		t.Error("expected error when API client is nil")
-	}
-}
-
-// TestSpendLimitFocusFlow: enter focuses the input and prefills from the user's
-// current limit; esc cancels without mutating the stored limit.
-func TestSpendLimitFocusFlow(t *testing.T) {
-	m := NewModel("test")
-	m = m.updateLayout(100, 40)
-	m, _ = m.AccountSwitch()
-	m.User = &models.User{ID: 1, SelfLimitCents: intp(2500)}
-	for i, item := range models.AccountMenuItems {
-		if item == "spend limit" {
-			m.account.cursor = i
-		}
-	}
-
-	m, _ = m.AccountUpdate(tea.KeyPressMsg{Code: tea.KeyEnter})
-	if !m.account.spendLimitFocused {
-		t.Fatal("enter did not focus the spend-limit input")
-	}
-	if got := m.account.spendLimitInput.Value(); got != "25.00" {
-		t.Errorf("prefill: want \"25.00\", got %q", got)
-	}
-
-	m, _ = m.AccountUpdate(tea.KeyPressMsg{Code: tea.KeyEsc})
-	if m.account.spendLimitFocused {
-		t.Error("esc did not blur the spend-limit input")
-	}
-	if m.User.SelfLimitCents == nil || *m.User.SelfLimitCents != 2500 {
-		t.Error("esc must not change the stored limit")
-	}
-}
-
-// TestSpendLimitSavedMsg: the async-result handler updates the local user and
-// clears focus on success.
-func TestSpendLimitSavedMsg(t *testing.T) {
-	m := NewModel("test")
-	m = m.updateLayout(100, 40)
-	m, _ = m.AccountSwitch()
-	m.User = &models.User{ID: 1}
-	m.account.spendLimitFocused = true
-	m.account.spendLimitSaving = true
-
-	m, _ = m.AccountUpdate(spendLimitSavedMsg{Cents: intp(750)})
-	if m.account.spendLimitFocused {
-		t.Error("successful save should blur the input")
-	}
-	if m.User.SelfLimitCents == nil || *m.User.SelfLimitCents != 750 {
-		t.Errorf("save should update local user limit to 750, got %v", m.User.SelfLimitCents)
-	}
-}
-
-func intp(i int) *int { return &i }

pkg/tui/cart.go

@@ -9,42 +9,36 @@ import (
 )
 
 func (m Model) updateCartViewport() Model {
-	contentW, _, _, _ := m.shopLayout()
 	headerH := lipgloss.Height(m.BuildHeader())
 	breadH := lipgloss.Height(m.BuildBreadcrumbs())
 	footerH := lipgloss.Height(m.BuildFooter())
-	// 2 = blank gap rows around the cart list
-	availH := m.heightContainer - headerH - footerH - breadH - 2
+	availH := m.heightContainer - headerH - footerH - breadH
 	if availH < 1 {
 		availH = 1
 	}
 	if !m.cart.viewportReady {
-		m.cart.viewport = viewport.New(viewport.WithWidth(contentW), viewport.WithHeight(availH))
+		m.cart.viewport = viewport.New(viewport.WithWidth(m.widthContent), viewport.WithHeight(availH))
 		m.cart.viewport.KeyMap = viewport.KeyMap{}
 		m.cart.viewportReady = true
 	} else {
-		m.cart.viewport.SetWidth(contentW)
+		m.cart.viewport.SetWidth(m.widthContent)
 		m.cart.viewport.SetHeight(availH)
 	}
 	return m
 }
 
 func (m Model) generateCartContent() string {
-	contentW, _, _, _ := m.shopLayout()
-
 	if m.IsCartEmpty() {
 		emptyStyle := m.theme.TextDim().
 			Align(lipgloss.Center).
-			Width(contentW).
+			Width(m.widthContent).
 			Padding(2, 0)
 		render := emptyStyle.Render("Your cart is empty\n\nPress s to go back to shop")
 		return render
 	}
 
 	cartItems := ""
-	// Cart cards span the full chrome width so they line up with the
-	// header and footer boxes.
-	boxWidth := contentW
+	boxWidth := m.widthContent - 4
 	itemSlice := m.GetCartItemsSlice()
 
 	boxPadding := 0
@@ -100,7 +94,7 @@ func (m Model) generateCartContent() string {
 			boxContent = m.theme.TextAccent().Render(boxContent)
 		}
 		box := m.createBoxInner(boxContent, isSelected, lipgloss.Left, 2, boxPadding, boxWidth)
-		cartItems += box
+		cartItems += m.theme.Base().Width(m.widthContent).Align(lipgloss.Center).Render(box)
 
 		if idx < len(itemSlice)-1 {
 			cartItems += "\n"
@@ -129,9 +123,12 @@ func (m Model) CartView() string {
 			m.cart.viewport.SetYOffset(targetY - m.cart.viewport.Height() + itemHeight)
 		}
 	}
-	// Blank rows separate the list from the chrome; no Place wrapper so the
-	// cards stay left-aligned with the header and footer boxes.
-	return "\n" + m.cart.viewport.View() + "\n"
+	return lipgloss.Place(
+		m.widthContainer,
+		lipgloss.Height(m.cart.viewport.View()),
+		lipgloss.Center, lipgloss.Center,
+		m.cart.viewport.View(),
+	)
 }
 
 func (m Model) CartUpdate(msg tea.Msg) (Model, tea.Cmd) {

pkg/tui/confirmation.go

@@ -5,7 +5,6 @@ import (
 	"strings"
 
 	"terminalShop/pkg/models"
-	"terminalShop/pkg/tui/qrfefe"
 
 	"charm.land/bubbles/v2/viewport"
 	tea "charm.land/bubbletea/v2"
@@ -170,30 +169,6 @@ func (m Model) ReviewView() string {
 	if m.CheckingOut {
 		return m.theme.TextAccent().Bold(true).Padding(1).Render("  submitting order...")
 	}
-	if m.review.retrying {
-		return m.theme.TextAccent().Bold(true).Padding(1).Render("  retrying authentication...")
-	}
-	if m.review.retryExhausted {
-		content := m.theme.TextError().Bold(true).Padding(1).Render("too many authentication attempts") + "\n" + m.theme.TextLabel().Padding(0, 1).Render("press esc to start a new order")
-		return lipgloss.Place(
-			m.widthContainer,
-			lipgloss.Height(content),
-			lipgloss.Center, lipgloss.Center,
-			content,
-		)
-	}
-	if m.review.authFailed {
-		content := m.theme.TextError().Bold(true).Padding(1).Render("authentication failed — press r to retry, esc to go back")
-		return lipgloss.Place(
-			m.widthContainer,
-			lipgloss.Height(content),
-			lipgloss.Center, lipgloss.Center,
-			content,
-		)
-	}
-	if m.review.requiresAction {
-		return m.renderRequiresActionView()
-	}
 	if m.review.success {
 		content := m.theme.TextSuccess().Bold(true).Padding(1).Render("order placed successfully!")
 		return lipgloss.Place(
@@ -212,50 +187,17 @@ func (m Model) ReviewView() string {
 	)
 }
 
-// renderRequiresActionView shows a QR for the 3DS challenge URL while the TUI
-// polls the order status. Mirrors the add-card QR layout in payment_form.go.
-func (m Model) renderRequiresActionView() string {
-	base := m.theme.TextLabel()
-	accent := m.theme.TextHighlight()
-	header := m.theme.TextAccent().Bold(true).Render("your bank wants to verify this charge")
-
-	if m.review.redirectURL == "" {
-		return base.Render("  verifying with your bank...")
-	}
-
-	qr, qrSize, err := qrfefe.Generate(m.review.redirectURL)
-	if err != nil || qrSize > m.widthContent {
-		body := header + "\n\n" +
-			base.Render("open this url on your phone to authenticate:") + "\n\n" +
-			accent.Render(m.review.redirectURL) + "\n\n" +
-			base.Render("waiting for completion...")
-		return lipgloss.Place(m.widthContainer, lipgloss.Height(body), lipgloss.Center, lipgloss.Center, body)
-	}
-
-	// Same gotcha as payment_form.go: lipgloss layout helpers corrupt qrfefe ANSI.
-	return qr +
-		header + "\n" +
-		base.Render("scan or visit to complete authentication") + "\n" +
-		accent.Render(m.review.redirectURL) + "\n\n" +
-		base.Render("waiting for completion...")
-}
-
 func (m Model) ReviewUpdate(msg tea.Msg) (Model, tea.Cmd) {
 	switch msg := msg.(type) {
 	case CheckoutResultMsg:
 		m.CheckingOut = false
 		if msg.Err != nil {
-			var cmd tea.Cmd
-			m, cmd = m.switchForCheckoutError(msg.Err)
+			m = m.SwitchPage(paymentPage)
 			m.error = &VisibleError{message: friendlyCheckoutError(msg.Err)}
 			m.review.cardJustAdded = false
-			return m, cmd
-		}
-		if msg.RequiresAction {
-			m.review.requiresAction = true
-			m.review.redirectURL = msg.RedirectURL
-			m.review.orderID = msg.OrderID
-			return m, m.schedulePollOrderStatus(msg.OrderID)
+			m.payment.view = 0
+			m.payment.form = nil
+			return m, nil
 		}
 		m.Cart = make(map[uint]*models.CartItem)
 		m.cart.cursor = 0
@@ -264,116 +206,10 @@ func (m Model) ReviewUpdate(msg tea.Msg) (Model, tea.Cmd) {
 		m.review.success = true
 		return m, nil
 
-	case OrderStatusMsg:
-		if !m.review.requiresAction || msg.OrderID != m.review.orderID {
-			return m, nil
-		}
-		if msg.Err != nil {
-			// Transient — keep polling.
-			return m, m.schedulePollOrderStatus(msg.OrderID)
-		}
-		switch msg.Status {
-		case "paid", "shipped", "delivered":
-			m.Cart = make(map[uint]*models.CartItem)
-			m.cart.cursor = 0
-			m.ShippingInfo = nil
-			m.OrdersLoaded = false
-			m.review.requiresAction = false
-			m.review.redirectURL = ""
-			m.review.success = true
-			return m, nil
-		case "failed", "cancelled":
-			m.review.requiresAction = false
-			m.review.redirectURL = ""
-			m.review.authFailed = true
-			m.footer = []footerCommand{{key: "r", value: "retry"}, {key: "esc", value: "back"}}
-			return m, nil
-		default:
-			return m, m.schedulePollOrderStatus(msg.OrderID)
-		}
-
-	case RetryAuthResultMsg:
-		if m.review.orderID != 0 && msg.OrderID != m.review.orderID {
-			return m, nil
-		}
-		m.review.retrying = false
-		if msg.Err != nil {
-			s := msg.Err.Error()
-			switch {
-			case strings.Contains(s, "RETRY_LIMIT"):
-				m.review.authFailed = false
-				m.review.retryExhausted = true
-				m.footer = []footerCommand{{key: "esc", value: "back"}}
-				return m, nil
-			case strings.Contains(s, "CARD_NO_LONGER_AVAILABLE"):
-				m.review.authFailed = false
-				m.review.requiresAction = false
-				m.review.redirectURL = ""
-				m.review.orderID = 0
-				m = m.SwitchPage(paymentPage)
-				m.payment.view = 0
-				m.payment.form = nil
-				m.error = &VisibleError{message: "saved card is no longer available. add it again to try."}
-				return m, nil
-			default:
-				m.error = &VisibleError{message: friendlyCheckoutError(msg.Err)}
-				return m, nil
-			}
-		}
-		m.review.authFailed = false
-		m.review.retryExhausted = false
-		m.review.requiresAction = true
-		m.review.redirectURL = msg.RedirectURL
-		m.review.orderID = msg.OrderID
-		m.footer = []footerCommand{{key: "esc", value: "cancel"}}
-		return m, m.schedulePollOrderStatus(msg.OrderID)
-
 	case tea.KeyMsg:
 		if m.CheckingOut {
 			return m, nil
 		}
-		if m.review.retrying {
-			return m, nil
-		}
-		if m.review.authFailed {
-			switch msg.String() {
-			case "r":
-				if m.review.orderID == 0 {
-					return m, nil
-				}
-				m.review.retrying = true
-				m.error = nil
-				return m, m.retryAuthCmd(m.review.orderID)
-			case "esc":
-				m.review.authFailed = false
-				m = m.SwitchPage(paymentPage)
-				m.payment.view = 0
-				m.payment.form = nil
-				return m, nil
-			}
-			return m, nil
-		}
-		if m.review.retryExhausted {
-			if msg.String() == "esc" {
-				m.review.retryExhausted = false
-				m.review.orderID = 0
-				m = m.SwitchPage(paymentPage)
-				m.payment.view = 0
-				m.payment.form = nil
-				return m, nil
-			}
-			return m, nil
-		}
-		if m.review.requiresAction {
-			if msg.String() == "esc" {
-				m.review.requiresAction = false
-				m.review.redirectURL = ""
-				m = m.SwitchPage(paymentPage)
-				m.payment.view = 0
-				return m, nil
-			}
-			return m, nil
-		}
 		if m.review.success {
 			m.review.success = false
 			m.review.cardJustAdded = false
@@ -400,29 +236,13 @@ func (m Model) ReviewUpdate(msg tea.Msg) (Model, tea.Cmd) {
 	return m, nil
 }
 
-func (m Model) switchForCheckoutError(err error) (Model, tea.Cmd) {
-	switch {
-	case strings.Contains(err.Error(), "CART_OVER_LIMIT"):
-		return m.CartSwitch()
-	default:
-		m = m.SwitchPage(paymentPage)
-		m.payment.view = 0
-		m.payment.form = nil
-		return m, nil
-	}
-}
-
 func friendlyCheckoutError(raw error) string {
 	s := raw.Error()
 	switch {
-	case strings.Contains(s, "CART_OVER_LIMIT"):
-		return "order total is over the per-order limit. remove items and try again."
 	case strings.Contains(s, "AUTHENTICATION_REQUIRED"):
 		return "your bank wants to verify this charge, authentication step coming soon."
 	case strings.Contains(s, "AUTHENTICATION_NOT_SUPPORTED"):
 		return "this card doesn't support online authentication. Try another card"
-	case strings.Contains(s, "CARD_STORAGE_EXPIRED"):
-		return "saved card expired. Add it again to verify the card is still yours"
 	case strings.Contains(s, "CARD_EXPIRED"):
 		return "card expired. Add a new card and try again"
 	case strings.Contains(s, "CARD_CVC_FAILED"):

pkg/tui/confirmation_retry_test.go

@@ -1,394 +0,0 @@
-package tui
-
-import (
-	"errors"
-	"strings"
-	"testing"
-
-	tea "charm.land/bubbletea/v2"
-)
-
-// newReviewModel returns a Model sitting on the review page with the default
-// layout already applied. Use as the starting point for every retry-auth
-// state machine test so transitions assert from a realistic baseline.
-func newReviewModel(t *testing.T) Model {
-	t.Helper()
-	m := NewModel("test")
-	m.currentPage = reviewPage
-	return m
-}
-
-// keyR / keyEsc / keyJ build the bubbletea v2 key events Update expects.
-// KeyMsg is an interface; KeyPressMsg satisfies it. Key.String() returns
-// Text when non-empty, otherwise the keystroke (which is why esc relies on
-// Code: tea.KeyEsc rather than Text).
-func keyR() tea.KeyMsg   { return tea.KeyPressMsg{Text: "r", Code: 'r'} }
-func keyEsc() tea.KeyMsg { return tea.KeyPressMsg{Code: tea.KeyEsc} }
-func keyJ() tea.KeyMsg   { return tea.KeyPressMsg{Text: "j", Code: 'j'} }
-
-func TestRetryAuthCmd_NilClient(t *testing.T) {
-	m := NewModel("test")
-	m.APIClient = nil
-	cmd := m.retryAuthCmd(42)
-	if cmd == nil {
-		t.Fatal("retryAuthCmd returned nil cmd")
-	}
-	msg := cmd()
-	rm, ok := msg.(RetryAuthResultMsg)
-	if !ok {
-		t.Fatalf("expected RetryAuthResultMsg, got %T", msg)
-	}
-	if rm.OrderID != 42 {
-		t.Errorf("OrderID = %d, want 42", rm.OrderID)
-	}
-	if rm.Err == nil || !strings.Contains(rm.Err.Error(), "api client unavailable") {
-		t.Errorf("expected api-client-unavailable err, got %v", rm.Err)
-	}
-}
-
-func TestReviewView_RetryingShowsCopy(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	out := m.ReviewView()
-	if !strings.Contains(out, "retrying authentication") {
-		t.Fatalf("missing retrying copy in: %q", out)
-	}
-}
-
-func TestReviewView_RetryExhaustedShowsCopy(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retryExhausted = true
-	out := m.ReviewView()
-	if !strings.Contains(out, "too many authentication attempts") {
-		t.Fatalf("missing retry-exhausted copy in: %q", out)
-	}
-	if !strings.Contains(out, "press esc to start a new order") {
-		t.Fatalf("missing recovery hint in: %q", out)
-	}
-}
-
-func TestReviewView_AuthFailedAdvertisesRetry(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.authFailed = true
-	out := m.ReviewView()
-	if !strings.Contains(out, "press r to retry") {
-		t.Fatalf("authFailed copy must advertise r: %q", out)
-	}
-	if !strings.Contains(out, "esc to go back") {
-		t.Fatalf("authFailed copy must advertise esc: %q", out)
-	}
-}
-
-func TestRenderRequiresActionView_FrictionlessShowsVerifying(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.requiresAction = true
-	m.review.redirectURL = ""
-	out := m.renderRequiresActionView()
-	if !strings.Contains(out, "verifying with your bank") {
-		t.Fatalf("frictionless retry-success path must show verifying copy: %q", out)
-	}
-}
-
-func TestReviewUpdate_AuthFailed_PressR_StartsRetry(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.authFailed = true
-	m.review.orderID = 7
-	m.error = &VisibleError{message: "leftover banner"}
-
-	out, cmd := m.ReviewUpdate(keyR())
-	if !out.review.retrying {
-		t.Fatal("expected retrying=true after r press")
-	}
-	if out.error != nil {
-		t.Fatal("stale banner should be cleared when retry starts")
-	}
-	if cmd == nil {
-		t.Fatal("expected non-nil cmd to call retryAuth")
-	}
-}
-
-func TestReviewUpdate_AuthFailed_PressR_ZeroOrderID_NoOp(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.authFailed = true
-	m.review.orderID = 0
-
-	out, cmd := m.ReviewUpdate(keyR())
-	if out.review.retrying {
-		t.Fatal("retry must not start without an order id")
-	}
-	if cmd != nil {
-		t.Fatal("expected nil cmd when orderID=0")
-	}
-}
-
-func TestReviewUpdate_AuthFailed_PressEsc_BouncesToPayment(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, _ := m.ReviewUpdate(keyEsc())
-	if out.review.authFailed {
-		t.Fatal("authFailed must clear on esc")
-	}
-	if out.currentPage != paymentPage {
-		t.Fatalf("currentPage = %v, want paymentPage", out.currentPage)
-	}
-}
-
-func TestReviewUpdate_AuthFailed_OtherKey_NoOp(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, cmd := m.ReviewUpdate(keyJ())
-	if !out.review.authFailed {
-		t.Fatal("unrelated key must not clear authFailed")
-	}
-	if out.review.retrying {
-		t.Fatal("unrelated key must not start retry")
-	}
-	if cmd != nil {
-		t.Fatal("unrelated key must not produce a cmd")
-	}
-}
-
-func TestReviewUpdate_Retrying_BlocksKeys(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, cmd := m.ReviewUpdate(keyR())
-	if !out.review.retrying {
-		t.Fatal("retrying flag should persist while a retry is in flight")
-	}
-	if cmd != nil {
-		t.Fatal("r press while retrying must not spawn a second cmd")
-	}
-
-	out, cmd = m.ReviewUpdate(keyEsc())
-	if out.currentPage != reviewPage {
-		t.Fatalf("currentPage changed while retrying: %v", out.currentPage)
-	}
-	if cmd != nil {
-		t.Fatal("esc while retrying must not navigate away")
-	}
-}
-
-func TestReviewUpdate_RetryAuthResult_RequiresAction(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, cmd := m.ReviewUpdate(RetryAuthResultMsg{
-		OrderID:     7,
-		Status:      "requires_action",
-		RedirectURL: "https://stripe/auth/abc",
-	})
-
-	if out.review.retrying {
-		t.Fatal("retrying must clear when the result arrives")
-	}
-	if out.review.authFailed {
-		t.Fatal("authFailed must clear on retry success")
-	}
-	if !out.review.requiresAction {
-		t.Fatal("expected requiresAction=true so the QR view renders")
-	}
-	if out.review.redirectURL != "https://stripe/auth/abc" {
-		t.Fatalf("redirectURL = %q", out.review.redirectURL)
-	}
-	if cmd == nil {
-		t.Fatal("expected schedulePollOrderStatus cmd")
-	}
-	if len(out.footer) != 1 || out.footer[0].key != "esc" || out.footer[0].value != "cancel" {
-		t.Fatalf("footer = %+v, want only esc=cancel", out.footer)
-	}
-}
-
-func TestReviewUpdate_RetryAuthResult_FrictionlessSuccess(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	m.review.authFailed = true
-	m.review.orderID = 9
-
-	out, cmd := m.ReviewUpdate(RetryAuthResultMsg{
-		OrderID: 9,
-		Status:  "succeeded",
-	})
-
-	if !out.review.requiresAction {
-		t.Fatal("frictionless retry must set requiresAction=true to render the verifying view")
-	}
-	if out.review.redirectURL != "" {
-		t.Fatalf("redirectURL must stay empty for frictionless retry, got %q", out.review.redirectURL)
-	}
-	if cmd == nil {
-		t.Fatal("expected poll cmd to wait for the webhook")
-	}
-}
-
-func TestReviewUpdate_RetryAuthResult_RetryLimit(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, cmd := m.ReviewUpdate(RetryAuthResultMsg{
-		OrderID: 7,
-		Err:     errors.New("RETRY_LIMIT: too many authentication attempts, please use a different card"),
-	})
-
-	if out.review.retrying {
-		t.Fatal("retrying must clear after a result")
-	}
-	if !out.review.retryExhausted {
-		t.Fatal("expected retryExhausted=true on RETRY_LIMIT")
-	}
-	if out.review.authFailed {
-		t.Fatal("authFailed must clear when retryExhausted takes over")
-	}
-	if cmd != nil {
-		t.Fatal("RETRY_LIMIT is terminal — no follow-up cmd")
-	}
-	if len(out.footer) != 1 || out.footer[0].key != "esc" {
-		t.Fatalf("footer = %+v, want only esc=back", out.footer)
-	}
-}
-
-func TestReviewUpdate_RetryAuthResult_CardGone(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, _ := m.ReviewUpdate(RetryAuthResultMsg{
-		OrderID: 7,
-		Err:     errors.New("CARD_NO_LONGER_AVAILABLE: saved card is no longer available, add it again to retry"),
-	})
-
-	if out.currentPage != paymentPage {
-		t.Fatalf("currentPage = %v, want paymentPage", out.currentPage)
-	}
-	if out.review.authFailed || out.review.requiresAction {
-		t.Fatal("auth state must reset when bouncing to payment")
-	}
-	if out.review.orderID != 0 {
-		t.Fatalf("orderID should reset to 0, got %d", out.review.orderID)
-	}
-	if out.error == nil || !strings.Contains(out.error.message, "saved card is no longer available") {
-		t.Fatalf("error banner missing or wrong copy: %+v", out.error)
-	}
-}
-
-func TestReviewUpdate_RetryAuthResult_Transient(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, cmd := m.ReviewUpdate(RetryAuthResultMsg{
-		OrderID: 7,
-		Err:     errors.New("CARD_DECLINED: card declined"),
-	})
-
-	if out.review.retrying {
-		t.Fatal("retrying must clear after a result")
-	}
-	if !out.review.authFailed {
-		t.Fatal("authFailed must persist so the user can retry again")
-	}
-	if out.review.retryExhausted {
-		t.Fatal("transient errors must not flip retryExhausted")
-	}
-	if out.error == nil {
-		t.Fatal("expected friendly banner for transient error")
-	}
-	if cmd != nil {
-		t.Fatal("transient error must not start a poll")
-	}
-}
-
-func TestReviewUpdate_RetryAuthResult_OrderIDMismatch(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retrying = true
-	m.review.authFailed = true
-	m.review.orderID = 7
-
-	out, cmd := m.ReviewUpdate(RetryAuthResultMsg{
-		OrderID:     99,
-		Status:      "requires_action",
-		RedirectURL: "https://wrong",
-	})
-
-	if !out.review.retrying {
-		t.Fatal("mismatched orderID must leave retrying unchanged")
-	}
-	if out.review.requiresAction {
-		t.Fatal("mismatched orderID must not flip requiresAction")
-	}
-	if out.review.redirectURL == "https://wrong" {
-		t.Fatal("mismatched orderID must not adopt the foreign URL")
-	}
-	if cmd != nil {
-		t.Fatal("mismatched orderID must not start a poll")
-	}
-}
-
-func TestReviewUpdate_RetryExhausted_PressEsc_BouncesToPayment(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retryExhausted = true
-	m.review.orderID = 7
-
-	out, _ := m.ReviewUpdate(keyEsc())
-	if out.review.retryExhausted {
-		t.Fatal("retryExhausted must clear on esc")
-	}
-	if out.review.orderID != 0 {
-		t.Fatalf("orderID should reset to 0, got %d", out.review.orderID)
-	}
-	if out.currentPage != paymentPage {
-		t.Fatalf("currentPage = %v, want paymentPage", out.currentPage)
-	}
-}
-
-func TestReviewUpdate_RetryExhausted_OtherKey_NoOp(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.retryExhausted = true
-
-	out, cmd := m.ReviewUpdate(keyR())
-	if !out.review.retryExhausted {
-		t.Fatal("unrelated key must not clear retryExhausted")
-	}
-	if cmd != nil {
-		t.Fatal("unrelated key must not produce a cmd")
-	}
-}
-
-func TestReviewUpdate_OrderStatusFailed_SetsRetryFooter(t *testing.T) {
-	m := newReviewModel(t)
-	m.review.requiresAction = true
-	m.review.orderID = 7
-
-	out, _ := m.ReviewUpdate(OrderStatusMsg{OrderID: 7, Status: "failed"})
-
-	if !out.review.authFailed {
-		t.Fatal("expected authFailed=true after failed status")
-	}
-	if out.review.requiresAction {
-		t.Fatal("requiresAction must clear when poll resolves to failed")
-	}
-	hasR, hasEsc := false, false
-	for _, c := range out.footer {
-		if c.key == "r" && c.value == "retry" {
-			hasR = true
-		}
-		if c.key == "esc" && c.value == "back" {
-			hasEsc = true
-		}
-	}
-	if !hasR || !hasEsc {
-		t.Fatalf("footer missing r/esc retry hints: %+v", out.footer)
-	}
-}

pkg/tui/confirmation_test.go

@@ -1,24 +0,0 @@
-package tui
-
-import (
-	"errors"
-	"strings"
-	"testing"
-)
-
-func TestFriendlyCheckoutError_CardStorageExpired(t *testing.T) {
-	got := friendlyCheckoutError(errors.New("CARD_STORAGE_EXPIRED: saved card epired, add it again"))
-	if !strings.Contains(got, "saved card expired") {
-		t.Fatalf("want saved-card-expired copy, got %q", got)
-	}
-	if strings.Contains(got, "card expired. Add a new card") {
-		t.Fatalf("CARD_STORAGE_EXPIRED was matched by the CARD_EXPIRED branch: %q", got)
-	}
-}
-
-func TestFriendlyCheckoutError_CardExpiredStillReachable(t *testing.T) {
-	got := friendlyCheckoutError(errors.New("CARD_EXPIRED: card expired"))
-	if !strings.Contains(got, "card expired. Add a new card") {
-		t.Fatalf("want plain card-expired copy, got %q", got)
-	}
-}

pkg/tui/doc.go

@@ -1,3 +0,0 @@
-// Package tui is the terminal UI you see over SSH: the shop, the cart, your
-// account, and the checkout flow, all drawn with Bubbletea.
-package tui

pkg/tui/footer.go

@@ -6,26 +6,20 @@ import (
 	"charm.land/lipgloss/v2"
 )
 
-// BuildFooter renders the bottom chrome bar with the current page keybinds.
-// Layout ported from the design prototype at ~/programming/test/shop.go.
 func (m Model) BuildFooter() string {
-	_, _, _, wideW := m.shopLayout()
+	keybindStyle := m.theme.TextDim().Bold(true)
+	descStyle := m.theme.TextDim()
 
-	item := func(k, v string) string {
-		return pBody.Render(k) + " " + pDim.Render(v)
-	}
-
-	var keys string
 	if m.size == small {
-		keys = item("m", "menu")
-	} else {
-		parts := make([]string, 0, len(m.footer))
-		for _, cmd := range m.footer {
-			parts = append(parts, item(cmd.key, cmd.value))
-		}
-		keys = strings.Join(parts, pDim.Render(" · "))
+		footerText := keybindStyle.Render("m") + " " + descStyle.Render("menu")
+		return lipgloss.NewStyle().Align(lipgloss.Center).Width(m.widthContainer).Render(footerText)
 	}
 
-	row := lipgloss.NewStyle().Width(wideW).Align(lipgloss.Center).Render(keys)
-	return panel(wideW, 0, row)
+	parts := []string{}
+	for _, cmd := range m.footer {
+		parts = append(parts, keybindStyle.Render(cmd.key)+" "+descStyle.Render(cmd.value))
+	}
+	footerText := strings.Join(parts, "    ")
+
+	return lipgloss.NewStyle().Align(lipgloss.Center).Width(m.widthContainer).Render(footerText)
 }

pkg/tui/header.go

@@ -2,72 +2,57 @@ package tui
 
 import (
 	"fmt"
-	"image/color"
-	"strings"
 
 	"charm.land/lipgloss/v2"
+	"charm.land/lipgloss/v2/table"
 )
 
-// cartBlendColor mixes the colors of all cart items, weighted by quantity,
-// so the header price tints toward whatever dominates the cart.
-func (m Model) cartBlendColor() color.Color {
-	var rSum, gSum, bSum, n int
-	for _, item := range m.Cart {
-		r, g, b, ok := parseHexColor(item.Coffee.Color)
-		if !ok {
-			continue
-		}
-		rSum += r * item.Quantity
-		gSum += g * item.Quantity
-		bSum += b * item.Quantity
-		n += item.Quantity
-	}
-	if n == 0 {
-		return cWhite
-	}
-	return lipgloss.Color(fmt.Sprintf("#%02X%02X%02X", rSum/n, gSum/n, bSum/n))
-}
-
-// BuildHeader renders the top chrome bar: brand, tab pills, and cart summary.
-// Layout ported from the design prototype at ~/programming/test/shop.go.
 func (m Model) BuildHeader() string {
-	_, _, _, wideW := m.shopLayout()
+	bold := m.theme.TextAccent().Bold(true).Render
+	accent := m.theme.TextAccent().Render
+	base := m.theme.Base().Render
+	cursor := m.theme.Base().Background(m.theme.Brand()).Render(" ")
 
-	brand := pWht.Bold(true).Render("terminal")
+	mark := bold("t") + cursor
+	logo := bold("terminal")
+	menu := bold("m") + base(" ☰")
 
-	pill := lipgloss.NewStyle().Background(cPill).Foreground(cWhite).Bold(true).Padding(0, 1)
-	tab := func(key, label string, active bool) string {
+	tab := func(key, name string, active bool) string {
 		if active {
-			return pill.Render(label)
+			return accent(key + " " + name)
 		}
-		return pDim.Render(key+" ") + pBody.Render(label)
+		return accent(key) + base(" "+name)
 	}
+	shop := tab("s", "shop", m.currentPage == shopPage)
+	account := tab("a", "account", m.currentPage == accountPage)
 
-	var left string
-	if m.size == small {
-		left = brand
-	} else {
-		left = strings.Join([]string{
-			brand,
-			tab("s", "shop", m.currentPage == shopPage),
-			tab("a", "account", m.currentPage == accountPage),
-		}, "   ")
-	}
-
-	cartLabel := pDim.Render("cart  ")
+	priceStr := fmt.Sprintf(" $%2v", m.CalculateSubtotal()/100)
+	countStr := fmt.Sprintf(" [%d]", m.CartItemCount())
+	cartLabel := base(" cart")
 	if m.inCartFlow() {
-		cartLabel = pWht.Bold(true).Render("cart  ")
+		cartLabel = accent(" cart")
 	}
-	cart := cartLabel +
-		lipgloss.NewStyle().Foreground(m.cartBlendColor()).Bold(true).
-			Render(fmt.Sprintf("$%d", m.CalculateSubtotal()/100)) +
-		pDim.Render(fmt.Sprintf("  ·  %d", m.CartItemCount()))
+	cart := accent("c") + cartLabel + accent(priceStr) + base(countStr)
 
-	gap := wideW - lipgloss.Width(left) - lipgloss.Width(cart)
-	if gap < 1 {
-		gap = 1
+	var tabs []string
+	switch m.size {
+	case small:
+		tabs = []string{mark, cart}
+	case medium:
+		tabs = []string{menu, logo, cart}
+	default:
+		tabs = []string{logo, shop, account, cart}
 	}
-	row := left + strings.Repeat(" ", gap) + cart
 
-	return panel(wideW, 0, row)
+	tbl := table.New().Border(lipgloss.NormalBorder()).BorderStyle(lipgloss.NewStyle().Foreground(m.theme.Border())).Row(tabs...).Width(m.widthContent).StyleFunc(func(row, col int) lipgloss.Style {
+		return m.theme.Base().Padding(0, 1).AlignHorizontal(lipgloss.Center)
+	}).Render()
+
+	return lipgloss.Place(
+		m.widthContainer,
+		lipgloss.Height(tbl),
+		lipgloss.Center,
+		lipgloss.Center,
+		tbl,
+	)
 }

pkg/tui/model.go

@@ -8,7 +8,6 @@ import (
 	"time"
 
 	"charm.land/bubbles/v2/key"
-	"charm.land/bubbles/v2/textinput"
 	"charm.land/bubbles/v2/viewport"
 	tea "charm.land/bubbletea/v2"
 	"github.com/stripe/stripe-go/v78"
@@ -76,6 +75,7 @@ type Model struct {
 	Fingerprint        string
 	AccessToken        string
 	AuthFingerprintKey string // shared secret for /auth/token refresh
+	StripePublicKey    string
 
 	// One-shop auth command - capture pubKeyStr in closure, not stored on Model
 	authCmd tea.Cmd
@@ -143,7 +143,10 @@ type Model struct {
 }
 
 type shopState struct {
-	selected int
+	selected       int
+	menuViewport   viewport.Model
+	detailViewport viewport.Model
+	viewportsReady bool
 }
 
 type splashState struct {
@@ -183,7 +186,6 @@ type accountState struct {
 	cursor             int
 	orderViewState     int
 	orderCursor        int
-	orderWindowStart   int // first fully-visible card in the windowed order list
 	orderYOffset       int // saved scroll pos when entering order detail
 	faqFocused         bool
 	addressListFocused bool
@@ -192,10 +194,6 @@ type accountState struct {
 	cardCursor         int
 	addressDeleting    *int
 	cardDeleting       *int
-	spendLimitFocused  bool
-	spendLimitInput    textinput.Model
-	spendLimitSaving   bool
-	spendLimitErr      string
 	detailViewport     viewport.Model
 	viewportReady      bool
 }
@@ -204,17 +202,6 @@ type reviewState struct {
 	cardJustAdded    bool
 	cardWasDuplicate bool
 	success          bool
-
-	// 3DS / SCA flow: when the backend returns 202 requires_action,
-	// requiresAction is true and redirectURL is the Stripe-hosted challenge
-	// page. The TUI shows a QR and polls GetOrderStatus(orderID) until the
-	// order flips to paid or failed.
-	requiresAction bool
-	redirectURL    string
-	orderID        uint
-	authFailed     bool
-	retrying       bool
-	retryExhausted bool
 }
 
 type confirmState struct {
@@ -243,6 +230,7 @@ func (m Model) SwitchPage(p page) Model {
 
 func (m Model) ShopSwitch() (Model, tea.Cmd) {
 	m = m.SwitchPage(shopPage)
+	m = m.updateShopViewports()
 	m.footer = []footerCommand{
 		{key: "j/k", value: "products"},
 		{key: "+/-", value: "qty"},
@@ -267,12 +255,13 @@ func (m Model) CartSwitch() (Model, tea.Cmd) {
 			{key: "q", value: "quit"},
 		}
 	} else {
-		// Keep this list short enough to fit on one footer line.
 		m.footer = []footerCommand{
 			{key: "j/k", value: "items"},
 			{key: "+/-", value: "qty"},
-			{key: "enter", value: "checkout"},
+			{key: "p/enter", value: "checkout"},
 			{key: "s", value: "shop"},
+			{key: "a", value: "account"},
+			{key: "pgup/pgdn", value: "scroll"},
 			{key: "?", value: "help"},
 			{key: "q", value: "quit"},
 		}
@@ -429,33 +418,11 @@ func (m Model) Init() tea.Cmd {
 }
 
 type CheckoutResultMsg struct {
-	OrderID        uint
-	Total          int
-	RequiresAction bool
-	RedirectURL    string
-	Err            error
-}
-
-// OrderStatusMsg carries the result of a poll against /orders/{id}/status.
-// Emitted on the 2s tick while waiting for 3DS authentication to complete.
-type OrderStatusMsg struct {
 	OrderID uint
-	Status  string
+	Total   int
 	Err     error
 }
 
-// RetryAuthResultMsg carries the outcome of POST /orders/{id}/retry-auth.
-// Status "requires_action" -> RedirectURL is a fresh challenge URL; resume
-// the QR + poll loop. Status "succeeded" -> frictionless retry approved;
-// server's APIError string ("RETRY_LIMIT" / "CARD_NO_LONGER_AVAILABLE" /
-// transient) - the Update branch matches on substring.
-type RetryAuthResultMsg struct {
-	OrderID     uint
-	Status      string
-	RedirectURL string
-	Err         error
-}
-
 // CartSyncedMsg is recieved when the server responds to a cart item update
 type CartSyncedMsg struct {
 	UpdateID int64
@@ -664,52 +631,12 @@ func (m Model) checkoutWithSavedCard() tea.Cmd {
 		}
 
 		// 3. Convert the cart to an order
-		outcome, err := m.APIClient.ConvertCart()
+		order, err := m.APIClient.ConvertCart()
 		if err != nil {
 			return CheckoutResultMsg{Err: err}
 		}
 
-		if outcome.RequiresAction {
-			return CheckoutResultMsg{
-				OrderID:        outcome.OrderID,
-				RequiresAction: true,
-				RedirectURL:    outcome.RedirectURL,
-			}
-		}
-
-		return CheckoutResultMsg{OrderID: outcome.Order.ID, Total: outcome.Order.Total}
-	}
-}
-
-// schedulePollOrderStatus sleeps 2s then polls /orders/{id}/status. Used while
-// waiting for the customer to complete 3DS authentication.
-func (m Model) schedulePollOrderStatus(orderID uint) tea.Cmd {
-	return tea.Tick(2*time.Second, func(time.Time) tea.Msg {
-		if m.APIClient == nil {
-			return OrderStatusMsg{OrderID: orderID, Err: fmt.Errorf("api client unavailable")}
-		}
-		status, err := m.APIClient.GetOrderStatus(orderID)
-		if err != nil {
-			return OrderStatusMsg{OrderID: orderID, Err: err}
-		}
-		return OrderStatusMsg{OrderID: orderID, Status: status}
-	})
-}
-
-func (m Model) retryAuthCmd(orderID uint) tea.Cmd {
-	return func() tea.Msg {
-		if m.APIClient == nil {
-			return RetryAuthResultMsg{OrderID: orderID, Err: fmt.Errorf("api client unavailable")}
-		}
-		outcome, err := m.APIClient.RetryAuth(orderID)
-		if err != nil {
-			return RetryAuthResultMsg{OrderID: orderID, Err: err}
-		}
-		return RetryAuthResultMsg{
-			OrderID:     orderID,
-			Status:      outcome.Status,
-			RedirectURL: outcome.RedirectURL,
-		}
+		return CheckoutResultMsg{OrderID: order.ID, Total: order.Total}
 	}
 }
 
@@ -736,6 +663,7 @@ func (m Model) saveCardOnlyCmd(form PaymentFormCompleteMsg) tea.Cmd {
 		if m.APIClient == nil {
 			return CardSavedForReviewMsg{Err: fmt.Errorf("API client not available")}
 		}
+		stripe.Key = m.StripePublicKey
 		tok, err := stripetoken.New(&stripe.TokenParams{
 			Card: &stripe.CardParams{
 				Name:       stripe.String(form.CardName),
@@ -842,7 +770,6 @@ func NewModel(username string) Model {
 			{
 				Name:        "Espresso",
 				RoastType:   "Dark Roast",
-				RoastLevel:  5,
 				Ounces:      2,
 				BeanType:    "Arabica",
 				Price:       350, // $3.50
@@ -852,7 +779,6 @@ func NewModel(username string) Model {
 			{
 				Name:        "Latte",
 				RoastType:   "Medium Roast",
-				RoastLevel:  2,
 				Ounces:      12,
 				BeanType:    "Arabica Blend",
 				Price:       500, // $5.00
@@ -862,7 +788,6 @@ func NewModel(username string) Model {
 			{
 				Name:        "Cappuccino",
 				RoastType:   "Medium Roast",
-				RoastLevel:  3,
 				Ounces:      8,
 				BeanType:    "Italian Blend",
 				Price:       450, // $4.50
@@ -872,7 +797,6 @@ func NewModel(username string) Model {
 			{
 				Name:        "Americano",
 				RoastType:   "Dark Roast",
-				RoastLevel:  4,
 				Ounces:      16,
 				BeanType:    "Arabica",
 				Price:       400, // $4.00
@@ -882,7 +806,6 @@ func NewModel(username string) Model {
 			{
 				Name:        "Mocha",
 				RoastType:   "Medium Roast",
-				RoastLevel:  3,
 				Ounces:      16,
 				BeanType:    "Colombian",
 				Price:       550, // $5.50
@@ -892,7 +815,6 @@ func NewModel(username string) Model {
 			{
 				Name:        "Macchiato",
 				RoastType:   "Dark Roast",
-				RoastLevel:  4,
 				Ounces:      3,
 				BeanType:    "Robusta Blend",
 				Price:       425, // $4.25
@@ -910,12 +832,11 @@ func NewModel(username string) Model {
 }
 
 // NewModelWithAuth creates a new model with user authentication context.
-// The publishable Stripe key is wired into stripe.Key once at startup in
-// the SSH binary's main, so it is not threaded through here.
-func NewModelWithAuth(fingerprint string, pubKeyStr string, apiURL string, clientSecret string) Model {
+func NewModelWithAuth(fingerprint string, pubKeyStr string, apiURL string, clientSecret string, stripePublicKey string) Model {
 	m := NewModel("")
 	m.Fingerprint = fingerprint
 	m.AuthFingerprintKey = clientSecret
+	m.StripePublicKey = stripePublicKey
 	m.currentPage = splashPage
 	if apiURL != "" {
 		m.APIClient = api.NewClient(apiURL, "")
@@ -937,6 +858,10 @@ func NewModelWithAuth(fingerprint string, pubKeyStr string, apiURL string, clien
 	return m
 }
 
+func newViewport(w, h int) viewport.Model {
+	return viewport.New(viewport.WithWidth(w), viewport.WithHeight(h))
+}
+
 func (m Model) collectCardCmd() tea.Cmd {
 	return func() tea.Msg {
 		if m.APIClient == nil {

pkg/tui/palette.go

@@ -1,70 +0,0 @@
-package tui
-
-import (
-	"image/color"
-	"strconv"
-	"strings"
-
-	"charm.land/lipgloss/v2"
-)
-
-// Palette and base styles for the boxed shop chrome.
-// Ported from the design prototype at ~/programming/test/shop.go.
-var (
-	cWhite = lipgloss.Color("#EAEAEA")
-	cBody  = lipgloss.Color("#9A9A9A")
-	cDim   = lipgloss.Color("#5A5A5A")
-	cLine  = lipgloss.Color("#3A3A3A")
-	cInk   = lipgloss.Color("#161616") // text on a light colored block
-	cGreen = lipgloss.Color("#4FB477")
-	cRed   = lipgloss.Color("#E06C6C")
-	cGold  = lipgloss.Color("#D0962E") // single accent
-	cPill  = lipgloss.Color("#2E2E2E") // active-tab pill bg
-
-	pBody = lipgloss.NewStyle().Foreground(cBody)
-	pDim  = lipgloss.NewStyle().Foreground(cDim)
-	pWht  = lipgloss.NewStyle().Foreground(cWhite)
-)
-
-// parseHexColor splits a "#RRGGBB" string into its channel values.
-func parseHexColor(s string) (r, g, b int, ok bool) {
-	s = strings.TrimPrefix(s, "#")
-	if len(s) != 6 {
-		return 0, 0, 0, false
-	}
-	v, err := strconv.ParseUint(s, 16, 32)
-	if err != nil {
-		return 0, 0, 0, false
-	}
-	return int(v >> 16), int((v >> 8) & 0xFF), int(v & 0xFF), true
-}
-
-// contrastColor returns ink for light backgrounds and white for dark ones,
-// using perceived luminance so text stays readable on any product color.
-func contrastColor(hex string) color.Color {
-	r, g, b, ok := parseHexColor(hex)
-	if !ok {
-		return cWhite
-	}
-	lum := (299*r + 587*g + 114*b) / 1000
-	if lum > 140 {
-		return cInk
-	}
-	return cWhite
-}
-
-// panel wraps content in a rounded box. textW is the inner text width and
-// innerH the inner content height; the total render size is textW+4 by
-// innerH+2. Ported from the design prototype at ~/programming/test/shop.go,
-// adjusted for lipgloss v2 where Width/Height include the border.
-func panel(textW, innerH int, content string) string {
-	s := lipgloss.NewStyle().
-		Border(lipgloss.RoundedBorder()).
-		BorderForeground(cLine).
-		Padding(0, 1).
-		Width(textW + 4)
-	if innerH > 0 {
-		s = s.Height(innerH + 2)
-	}
-	return s.Render(content)
-}

pkg/tui/payment_form.go

@@ -276,7 +276,9 @@ func (m Model) updatePaymentViewport() Model {
 	breadH := lipgloss.Height(m.BuildBreadcrumbs())
 	footerH := lipgloss.Height(m.BuildFooter())
 	availH := m.heightContainer - headerH - footerH - breadH
-	availH = max(availH, 1)
+	if availH < 1 {
+		availH = 1
+	}
 	if !m.payment.viewportReady {
 		m.payment.viewport = viewport.New(viewport.WithWidth(m.widthContent), viewport.WithHeight(availH))
 		m.payment.viewport.KeyMap = viewport.KeyMap{}
@@ -301,7 +303,7 @@ func (m Model) PaymentPageView() string {
 			m.widthContainer,
 			m.payment.viewport.Height(),
 			lipgloss.Center, lipgloss.Center,
-			m.renderPaymentHTTPSView(),
+			m.renderPaymentHttpsView(),
 		)
 	} else if m.payment.view == 0 && m.payment.form == nil {
 		content = m.RenderCardList()
@@ -353,16 +355,11 @@ func (m Model) RenderCardList() string {
 		boxes = append(boxes, box)
 	}
 
-	// SSH inline card-add is dormant until i have a norwegian org
-	// number wired to stripe, something i dont have since its $300+. Keep the row visible so the option is
-	// discoverable, but render it dimmed and exclude it from cursor space
-	// (handled in PaymentUpdate below) so it can not be picked
-	dim := m.theme.TextDim().Render
-	sshLabel := dim("+ add card via ssh") + "  " + dim("(WIP)")
-	sshBox := m.CreateBox(m.formatListItem(sshLabel, false), false)
+	sshFocused := m.payment.cardCursor == len(m.SavedCards)
+	sshBox := m.CreateBox(m.formatListItem("+ add card via ssh", sshFocused), sshFocused)
 	boxes = append(boxes, sshBox)
 
-	httpsFocused := m.payment.cardCursor == len(m.SavedCards)
+	httpsFocused := m.payment.cardCursor == len(m.SavedCards)+1
 	httpsBox := m.CreateBox(m.formatListItem("+ add payment via browser", httpsFocused), httpsFocused)
 	boxes = append(boxes, httpsBox)
 
@@ -372,7 +369,7 @@ func (m Model) RenderCardList() string {
 	return lipgloss.JoinVertical(lipgloss.Left, parts...)
 }
 
-func (m Model) renderPaymentHTTPSView() string {
+func (m Model) renderPaymentHttpsView() string {
 	baseStyle := m.theme.TextLabel()
 	accentStyle := m.theme.TextHighlight()
 
@@ -504,7 +501,7 @@ func (m Model) PaymentUpdate(msg tea.Msg) (Model, tea.Cmd) {
 				m.payment.cardCursor--
 			}
 		case "down", "j":
-			if m.payment.cardCursor < len(m.SavedCards) {
+			if m.payment.cardCursor < len(m.SavedCards)+1 {
 				m.payment.cardCursor++
 			}
 
@@ -514,8 +511,17 @@ func (m Model) PaymentUpdate(msg tea.Msg) (Model, tea.Cmd) {
 				m.SelectedCard = &selected
 				return m.ReviewSwitch()
 			}
-			// Browser flow, the only reachable add-card path while the SSH
-			// inline form is dormant (see RenderCardList)
+			if m.payment.cardCursor == len(m.SavedCards) {
+				m.payment.view = 1
+				m.payment.form = m.InitPaymentForm()
+				m.footer = []footerCommand{
+					{key: "tab", value: "next"},
+					{key: "enter", value: "submit"},
+					{key: "esc", value: "back"},
+				}
+				return m, m.payment.form.form.Init()
+			}
+			// Browser payment
 			m.payment.view = 2
 			m.payment.collectURL = nil
 			m.payment.collectTimeOut = false
@@ -540,6 +546,16 @@ func (m Model) PaymentUpdate(msg tea.Msg) (Model, tea.Cmd) {
 				if m.payment.cardCursor >= len(m.SavedCards) && m.payment.cardCursor > 0 {
 					m.payment.cardCursor--
 				}
+				if len(m.SavedCards) == 0 {
+					m.payment.view = 1
+					m.payment.form = m.InitPaymentForm()
+					m.footer = []footerCommand{
+						{key: "tab", value: "next"},
+						{key: "enter", value: "submit"},
+						{key: "esc", value: "back"},
+					}
+					return m, tea.Batch(m.payment.form.form.Init(), m.deleteCardCmd(card.ID))
+				}
 				return m, m.deleteCardCmd(card.ID)
 			}
 		}

pkg/tui/payment_form_test.go

@@ -1,91 +0,0 @@
-package tui
-
-import (
-	"strings"
-	"testing"
-
-	"terminalShop/pkg/models"
-
-	tea "charm.land/bubbletea/v2"
-)
-
-// newPaymentCardListModel parks a Model on the payment page card-list view
-// with n synthetic saved cards. Baseline for assertint that the dormant
-// "+ add card via ssh" row is dimmed and unreachable by cursor navigation.
-func newPaymentCardListModel(t *testing.T, n int) Model {
-	t.Helper()
-	m := NewModel("test")
-	m = m.updateLayout(120, 40)
-	m.currentPage = paymentPage
-	m.payment.view = 0
-	m.payment.form = nil
-	m.payment.cardCursor = 0
-	for i := range n {
-		m.SavedCards = append(m.SavedCards, models.Card{
-			ID:       uint(i + 1),
-			Brand:    "visa",
-			Last4:    "4242",
-			ExpMonth: 12,
-			ExpYear:  2030,
-		})
-	}
-	return m
-}
-
-func keyEnter() tea.KeyMsg { return tea.KeyPressMsg{Code: tea.KeyEnter} }
-
-func TestRenderCardList_SshOptionComingSoon(t *testing.T) {
-	m := newPaymentCardListModel(t, 1)
-	out := m.RenderCardList()
-	if !strings.Contains(out, "add card via ssh") {
-		t.Fatalf("ssh option missing from card list output:\n%s", out)
-	}
-	if !strings.Contains(out, "WIP") {
-		t.Fatalf("want 'WIP' marked on ssh option:\n%s", out)
-	}
-}
-
-func TestPaymentUpdate_DownNavigationStopsAtBrowserSlot(t *testing.T) {
-	m := newPaymentCardListModel(t, 2)
-	for range 10 {
-		var cmd tea.Cmd
-		m, cmd = m.PaymentUpdate(keyJ())
-		_ = cmd
-	}
-	want := len(m.SavedCards) // browser slot; ssh slot in unreachable
-	if m.payment.cardCursor != want {
-		t.Fatalf("cursor stopped at %d, want %d (browser slot)", m.payment.cardCursor, want)
-	}
-}
-
-func TestPaymentUpdate_EnterOnBrowserSlotLaunchesBrowserFlow(t *testing.T) {
-	m := newPaymentCardListModel(t, 1)
-	m.payment.cardCursor = len(m.SavedCards) // browser slot
-	newM, cmd := m.PaymentUpdate(keyEnter())
-	if newM.payment.view != 2 {
-		t.Fatalf("payment.view = %d, want 2 (browser flow)", newM.payment.view)
-	}
-	if newM.payment.form != nil {
-		t.Fatalf("payment.form must be nil after enter; ssh inline form is dormant")
-	}
-	if cmd == nil {
-		t.Fatalf("expected collectCardCmd, got nil")
-	}
-}
-
-func TestPaymentUpdate_EnterWithZeroCardsLaunchesBrowserFlow(t *testing.T) {
-	m := newPaymentCardListModel(t, 0)
-	if m.payment.cardCursor != 0 {
-		t.Fatalf("default cursor = %d, want 0 ", m.payment.cardCursor)
-	}
-	newM, cmd := m.PaymentUpdate(keyEnter())
-	if newM.payment.view != 2 {
-		t.Fatalf("payment.view = %d, want 2 (browser flow)", newM.payment.view)
-	}
-	if newM.payment.form != nil {
-		t.Fatalf("payment.form must be nil; ssh inline form is dormant")
-	}
-	if cmd == nil {
-		t.Fatalf("expected collectCardCmd, got nil")
-	}
-}

pkg/tui/qrfefe/doc.go

@@ -1,3 +0,0 @@
-// Package qrfefe turns text into a QR code drawn with terminal block
-// characters, handy for showing links you can scan right off the screen.
-package qrfefe

pkg/tui/refund.go

@@ -129,7 +129,7 @@ func (m Model) RefundUpdate(msg tea.Msg) (Model, tea.Cmd) {
 			state.form = f
 		}
 		if state.form.State == huh.StateCompleted {
-			state.reason = state.form.GetString("reason")
+			state.form = m.buildRefundForm(state)
 			return m, m.setRefundFocus(state, refundFocusMessage)
 		}
 		return m, cmd
@@ -335,7 +335,7 @@ func (m Model) renderRefundTextarea(state *refundState) string {
 	}
 
 	wrapper := lipgloss.NewStyle().
-		Border(lipgloss.RoundedBorder()).
+		Border(lipgloss.ThickBorder()).
 		BorderForeground(border)
 
 	contentWidth := m.refundContentWidth()

pkg/tui/render_smoke_test.go

@@ -1,194 +0,0 @@
-package tui
-
-import (
-	"regexp"
-	"strings"
-	"testing"
-
-	"terminalShop/pkg/models"
-)
-
-var ansiRE = regexp.MustCompile("\x1b\\[[0-9;]*m")
-
-// TestRenderShopSmoke prints the rendered shop frame so chrome alignment can
-// be inspected, and asserts that the header, body, and footer boxes share the
-// same left and right edges.
-func TestRenderShopSmoke(t *testing.T) {
-	m := NewModel("smoke")
-	m.Loading = false
-	m.Cart[m.Coffees[0].ID] = &models.CartItem{CoffeeID: m.Coffees[0].ID, Coffee: m.Coffees[0], Quantity: 4}
-	m = m.updateLayout(100, 40)
-	m, _ = m.ShopSwitch()
-
-	out := m.renderString()
-	plain := ansiRE.ReplaceAllString(out, "")
-	t.Log("\n" + plain)
-
-	// Collect left/right border columns of every box-drawing row.
-	var lefts, rights []int
-	for _, line := range strings.Split(plain, "\n") {
-		runes := []rune(line)
-		first, last := -1, -1
-		for i, r := range runes {
-			if strings.ContainsRune("╭╮╰╯│", r) {
-				if first == -1 {
-					first = i
-				}
-				last = i
-			}
-		}
-		if first != -1 {
-			lefts = append(lefts, first)
-			rights = append(rights, last)
-		}
-	}
-	if len(lefts) == 0 {
-		t.Fatal("no box-drawing rows found")
-	}
-	for i := range lefts {
-		if lefts[i] != lefts[0] {
-			t.Errorf("left edge misaligned: row %d at col %d, expected %d", i, lefts[i], lefts[0])
-			break
-		}
-		if rights[i] != rights[0] {
-			t.Errorf("right edge misaligned: row %d at col %d, expected %d", i, rights[i], rights[0])
-			break
-		}
-	}
-}
-
-// TestRenderAccountSmoke verifies the account page boxes stay within the
-// header/footer chrome bounds. The detail area is unboxed, so inner boxes may
-// be narrower than the chrome but must never poke outside it.
-func TestRenderAccountSmoke(t *testing.T) {
-	m := NewModel("smoke")
-	m.Loading = false
-	m = m.updateLayout(100, 40)
-	m, _ = m.AccountSwitch()
-
-	plain := ansiRE.ReplaceAllString(m.renderString(), "")
-	t.Log("\n" + plain)
-
-	var lefts, rights []int
-	for _, line := range strings.Split(plain, "\n") {
-		runes := []rune(line)
-		first, last := -1, -1
-		for i, r := range runes {
-			if strings.ContainsRune("╭╮╰╯│", r) {
-				if first == -1 {
-					first = i
-				}
-				last = i
-			}
-		}
-		if first != -1 {
-			lefts = append(lefts, first)
-			rights = append(rights, last)
-		}
-	}
-	if len(lefts) == 0 {
-		t.Fatal("no box-drawing rows found")
-	}
-	// Row 0 is the header box: it defines the chrome bounds.
-	for i := range lefts {
-		if lefts[i] < lefts[0] || rights[i] > rights[0] {
-			t.Errorf("box outside chrome: row %d spans %d-%d, chrome is %d-%d",
-				i, lefts[i], rights[i], lefts[0], rights[0])
-			break
-		}
-	}
-}
-
-// TestRenderOrderWindowing verifies the windowed order list: whole cards
-// only, with ↑/↓ arrow rows marking hidden items.
-func TestRenderOrderWindowing(t *testing.T) {
-	m := NewModel("smoke")
-	m.Loading = false
-	m.OrdersLoaded = true
-	for i := 1; i <= 9; i++ {
-		m.Orders = append(m.Orders, models.Order{
-			ID:     uint(9000 + i),
-			Status: models.OrderStatusPaid,
-			Total:  1000 + i*100,
-		})
-	}
-	m = m.updateLayout(100, 40)
-	m, _ = m.AccountSwitch()
-
-	// Preview mode: window starts at the top, arrow only below.
-	plain := ansiRE.ReplaceAllString(m.renderString(), "")
-	t.Log("\n" + plain)
-	if !strings.Contains(plain, "↓ 4 more") {
-		t.Errorf("preview mode: expected '↓ 4 more' indicator")
-	}
-	if strings.Contains(plain, "↑") {
-		t.Errorf("preview mode: unexpected up arrow")
-	}
-
-	// Browse mode scrolled to the middle: arrows on both ends.
-	m.account.orderViewState = 1
-	m.account.orderCursor = 6
-	m = m.scrollToAccountDetailItem()
-	plain = ansiRE.ReplaceAllString(m.renderString(), "")
-	t.Log("\n" + plain)
-	if !strings.Contains(plain, "↑ 2 more") || !strings.Contains(plain, "↓ 2 more") {
-		t.Errorf("browse mode: expected '↑ 2 more' and '↓ 2 more' indicators")
-	}
-}
-
-// TestRenderCartSmoke verifies the cart page cards line up with the chrome.
-func TestRenderCartSmoke(t *testing.T) {
-	m := NewModel("smoke")
-	m.Loading = false
-	// Seed coffees carry no IDs, so assign them for distinct cart keys
-	for i := range m.Coffees {
-		m.Coffees[i].ID = uint(i + 1)
-	}
-	m.Cart[m.Coffees[0].ID] = &models.CartItem{CoffeeID: m.Coffees[0].ID, Coffee: m.Coffees[0], Quantity: 2}
-	m.Cart[m.Coffees[1].ID] = &models.CartItem{CoffeeID: m.Coffees[1].ID, Coffee: m.Coffees[1], Quantity: 1}
-	m = m.updateLayout(100, 40)
-	m, _ = m.CartSwitch()
-
-	plain := ansiRE.ReplaceAllString(m.renderString(), "")
-	t.Log("\n" + plain)
-
-	var lefts, rights []int
-	for _, line := range strings.Split(plain, "\n") {
-		runes := []rune(line)
-		first, last := -1, -1
-		for i, r := range runes {
-			if strings.ContainsRune("╭╮╰╯│", r) {
-				if first == -1 {
-					first = i
-				}
-				last = i
-			}
-		}
-		if first != -1 {
-			lefts = append(lefts, first)
-			rights = append(rights, last)
-		}
-	}
-	if len(lefts) == 0 {
-		t.Fatal("no box-drawing rows found")
-	}
-	// Every box row (header, cards, footer) must share the chrome edges.
-	for i := range lefts {
-		if lefts[i] != lefts[0] || rights[i] != rights[0] {
-			t.Errorf("box edge misaligned: row %d spans %d-%d, expected %d-%d",
-				i, lefts[i], rights[i], lefts[0], rights[0])
-			break
-		}
-	}
-}
-
-// TestRenderShopSmokeStacked prints the stacked (medium/small) layouts.
-func TestRenderShopSmokeStacked(t *testing.T) {
-	for _, size := range [][2]int{{60, 32}, {45, 30}} {
-		m := NewModel("smoke")
-		m.Loading = false
-		m = m.updateLayout(size[0], size[1])
-		m, _ = m.ShopSwitch()
-		t.Logf("--- %dx%d ---\n%s", size[0], size[1], ansiRE.ReplaceAllString(m.renderString(), ""))
-	}
-}

pkg/tui/shop.go

@@ -4,173 +4,163 @@ import (
 	"fmt"
 	"strings"
 
+	"charm.land/bubbles/v2/viewport"
 	tea "charm.land/bubbletea/v2"
 	"charm.land/lipgloss/v2"
 
 	"terminalShop/pkg/models"
 )
 
-const (
-	// shopBodyInnerHeight fixes the inner height of the shop body panels so
-	// the detail box never resizes with the description.
-	shopBodyInnerHeight = 13
-	// shopDescLines pins the description region to an exact line count.
-	shopDescLines = 3
-)
-
-// shopLayout returns the shared chrome widths, all derived from one content
-// width so the header, body panels, and footer line up exactly.
-// Math ported from the design prototype at ~/programming/test/shop.go:
-// menu(menuW+4) + gap(1) + detail(detailW+4) = contentW = wideW + 4.
-func (m Model) shopLayout() (contentW, menuW, detailW, wideW int) {
-	contentW = m.widthContent
-	contentW = min(contentW, 74)
-	wideW = contentW - 4
+func (m Model) calculateShopWidths() (int, int) {
+	menuWidth := 14
+	if len(m.Coffees) == 0 {
+		if m.size < large {
+			return m.widthContent, m.widthContent
+		}
+		return menuWidth, m.widthContent - menuWidth
+	}
+	for _, c := range m.Coffees {
+		if w := lipgloss.Width(c.Name); w > menuWidth {
+			menuWidth = w
+		}
+	}
+	if menuWidth > 0 {
+		menuWidth += 4
+	}
 	if m.size < large {
-		// Stacked layout: both panels span the full content width.
-		return contentW, wideW, wideW, wideW
+		menuWidth = m.widthContent
 	}
-	menuW = 16
-	detailW = contentW - 25
-	return contentW, menuW, detailW, wideW
+	detailWidth := m.widthContent - menuWidth
+	if m.size < large {
+		detailWidth = m.widthContent
+	}
+	return menuWidth, detailWidth
 }
 
-// roastLevel maps a roast type to a 1-5 intensity for the roast meter.
-// It is the fallback for products stored before the roast_level column existed.
-func roastLevel(roastType string) int {
-	rt := strings.ToLower(roastType)
-	switch {
-	case strings.Contains(rt, "dark"):
-		return 5
-	case strings.Contains(rt, "light"):
-		return 2
-	default:
-		return 3
+func (m Model) updateShopViewports() Model {
+	headerHeight := lipgloss.Height(m.BuildHeader())
+	footerHeight := lipgloss.Height(m.BuildFooter())
+	availableHeight := m.heightContainer - headerHeight - footerHeight
+
+	if len(m.Coffees) == 0 {
+		return m
 	}
+
+	menuWidth, detailWidth := m.calculateShopWidths()
+
+	if !m.shop.viewportsReady {
+		m.shop.menuViewport = newViewport(menuWidth, availableHeight)
+		m.shop.menuViewport.KeyMap = viewport.KeyMap{} // menu nav is manual
+		m.shop.detailViewport = newViewport(detailWidth, availableHeight)
+		m.shop.detailViewport.KeyMap = modifiedKeyMap
+		m.shop.viewportsReady = true
+	} else {
+		m.shop.menuViewport.SetWidth(menuWidth)
+		m.shop.menuViewport.SetHeight(availableHeight)
+		m.shop.detailViewport.SetWidth(detailWidth)
+		m.shop.detailViewport.SetHeight(availableHeight)
+	}
+	return m
 }
 
-// clampLines pads or truncates rendered text to exactly n lines so regions
-// like the description never change the panel height.
-func clampLines(s string, n int) string {
-	lines := strings.Split(s, "\n")
-	if len(lines) > n {
-		lines = lines[:n]
-	}
-	for len(lines) < n {
-		lines = append(lines, "")
-	}
-	return strings.Join(lines, "\n")
-}
+func (m Model) getShopMenuContent() string {
+	menuWidth, _ := m.calculateShopWidths()
 
-// roastMeter renders the strength dots, e.g. ● ● ● ○ ○
-func roastMeter(n int) string {
-	n = max(0, min(n, 5))
-	on := lipgloss.NewStyle().Foreground(cGold).Render(strings.Repeat("● ", n))
-	off := pDim.Render(strings.Repeat("○ ", 5-n))
-	return strings.TrimRight(on+off, " ")
-}
+	selectedColor := m.theme.Highlight()
+	if m.shop.selected >= 0 && m.shop.selected < len(m.Coffees) {
+		if c := m.Coffees[m.shop.selected].Color; c != "" {
+			selectedColor = lipgloss.Color(c)
+		}
+	}
+
+	var normal, highlighted lipgloss.Style
+	if m.size < large {
+		menuWidth = m.widthContent
+		normal = m.theme.TextBody().
+			Width(menuWidth - 1).Align(lipgloss.Center)
+		highlighted = m.theme.TextAccent().
+			Width(menuWidth - 1).Align(lipgloss.Center).
+			Background(selectedColor).Bold(true)
+	} else {
+		normal = m.theme.TextBody().
+			Width(menuWidth+2).Padding(0, 1)
+		highlighted = m.theme.TextAccent().
+			Width(menuWidth+2).Padding(0, 1).
+			Background(selectedColor).Bold(true)
+	}
 
-func (m Model) shopMenuContent(w int) string {
 	var b strings.Builder
 	for i, c := range m.Coffees {
 		if i == m.shop.selected {
-			b.WriteString(lipgloss.NewStyle().Width(w).
-				Background(lipgloss.Color(c.Color)).
-				Foreground(contrastColor(c.Color)).
-				Bold(true).
-				Render(" · " + c.Name))
+			b.WriteString(highlighted.Render(c.Name) + "\n")
 		} else {
-			dot := lipgloss.NewStyle().Foreground(lipgloss.Color(c.Color)).Render("·")
-			b.WriteString(lipgloss.NewStyle().Width(w).
-				Render(" " + dot + " " + pBody.Render(c.Name)))
-		}
-		if i < len(m.Coffees)-1 {
-			b.WriteString("\n")
+			b.WriteString(normal.Render(c.Name) + "\n")
 		}
 	}
-	return b.String()
+	return lipgloss.NewStyle().Padding(0, 1).Render(b.String())
 }
 
-func (m Model) shopDetailContent(w int) string {
+func (m Model) getShopDetailContent() string {
+	if len(m.Coffees) == 0 {
+		return ""
+	}
 	coffee := m.Coffees[m.shop.selected]
+	_, detailWidth := m.calculateShopWidths()
+	if m.size >= large {
+		detailWidth -= 2
+	}
+
 	quantity := 0
 	if item, exists := m.Cart[coffee.ID]; exists {
 		quantity = item.Quantity
 	}
 
-	name := pWht.Bold(true).Render(coffee.Name)
-
-	sep := pDim.Render(" · ")
-	spec := pBody.Render(strings.ToUpper(coffee.RoastType)) + sep +
-		pDim.Render(fmt.Sprintf("%dOZ", coffee.Ounces)) + sep +
-		pDim.Render(strings.ToUpper(coffee.BeanType))
-
-	level := coffee.RoastLevel
-	if level < 1 || level > 5 {
-		level = roastLevel(coffee.RoastType)
-	}
-	strength := pDim.Render("roast  ") + roastMeter(level)
-
-	price := lipgloss.NewStyle().Foreground(lipgloss.Color(coffee.Color)).Bold(true).
-		Render(fmt.Sprintf("$%d.%02d", coffee.Price/100, coffee.Price%100)) +
-		pDim.Render("  usd")
-
-	// Stock is not modeled in the backend yet, so the indicator is static.
-	stock := lipgloss.NewStyle().Foreground(cGreen).Render("● in stock")
-
-	desc := clampLines(pBody.Width(w).Render(coffee.Description), shopDescLines)
-
-	// stepper: git-diff coloring — red minus, green plus
-	minus := lipgloss.NewStyle().Foreground(cRed).Bold(true).Render("−")
-	plus := lipgloss.NewStyle().Foreground(cGreen).Bold(true).Render("+")
-	count := lipgloss.NewStyle().Foreground(cWhite).Bold(true).
-		Padding(0, 2).Render(fmt.Sprintf("%d", quantity))
-	stepper := pDim.Render("qty  ") + minus + count + plus
-
-	return lipgloss.JoinVertical(lipgloss.Left,
-		name,
-		spec,
-		strength,
+	detail := lipgloss.JoinVertical(lipgloss.Left,
+		m.theme.TextAccent().Bold(true).Render(coffee.Name),
+		m.theme.TextBody().Render(
+			fmt.Sprintf("%s | %doz | %s", coffee.RoastType, coffee.Ounces, coffee.BeanType),
+		),
 		"",
-		price+"    "+stock,
+		lipgloss.NewStyle().Foreground(lipgloss.Color(coffee.Color)).Bold(true).Render(
+			fmt.Sprintf("$%.2f", float64(coffee.Price)/100),
+		),
 		"",
-		desc,
+		m.theme.TextAccent().Width(detailWidth).Render(coffee.Description),
 		"",
-		stepper,
+		fmt.Sprintf("-  %d  +", quantity),
 	)
+	return lipgloss.NewStyle().Width(detailWidth).Render(detail)
 }
 
 func (m Model) ShopView() string {
+	if !m.shop.viewportsReady {
+		m = m.updateShopViewports()
+	}
 	if len(m.Coffees) == 0 {
 		return lipgloss.Place(m.widthContent, m.heightContainer,
 			lipgloss.Center, lipgloss.Center, "No products available.")
 	}
 
-	_, menuW, detailW, _ := m.shopLayout()
+	m.shop.menuViewport.SetContent(m.getShopMenuContent())
+	m.shop.detailViewport.SetContent(m.getShopDetailContent())
 
-	mc := m.shopMenuContent(menuW)
-	dc := m.shopDetailContent(detailW)
-
-	var body string
 	if m.size < large {
-		body = lipgloss.JoinVertical(lipgloss.Left,
-			panel(menuW, 0, mc),
-			panel(detailW, 0, dc),
-		)
-	} else {
-		bodyH := max(shopBodyInnerHeight, lipgloss.Height(mc), lipgloss.Height(dc))
-		body = lipgloss.JoinHorizontal(lipgloss.Top,
-			panel(menuW, bodyH, mc),
-			" ",
-			panel(detailW, bodyH, dc),
+		return lipgloss.JoinVertical(lipgloss.Top,
+			m.shop.menuViewport.View(),
+			m.shop.detailViewport.View(),
 		)
 	}
-
-	// Blank rows separate the body from the header and footer boxes.
-	return "\n" + body + "\n"
+	return lipgloss.JoinHorizontal(lipgloss.Top,
+		m.shop.menuViewport.View(),
+		"  ",
+		m.shop.detailViewport.View(),
+	)
 }
 
 func (m Model) ShopUpdate(msg tea.Msg) (Model, tea.Cmd) {
+	var cmd tea.Cmd
+	var cmds []tea.Cmd
+
 	if len(m.Coffees) == 0 {
 		return m, nil
 	}
@@ -207,7 +197,16 @@ func (m Model) ShopUpdate(msg tea.Msg) (Model, tea.Cmd) {
 		}
 	}
 
-	return m, nil
+	// Pass messages to the detail viewport so pgup/pgdn scroll works
+	m.shop.detailViewport, cmd = m.shop.detailViewport.Update(msg)
+	cmds = append(cmds, cmd)
+
+	if m.shop.viewportsReady {
+		m.shop.menuViewport.SetContent(m.getShopMenuContent())
+		m.shop.detailViewport.SetContent(m.getShopDetailContent())
+	}
+
+	return m, tea.Batch(cmds...)
 }
 
 func (m Model) shopMoveSelected(previous bool) Model {
@@ -217,8 +216,18 @@ func (m Model) shopMoveSelected(previous bool) Model {
 	} else {
 		next++
 	}
-	next = max(next, 0)
-	next = min(next, len(m.Coffees)-1)
+	if next < 0 {
+		next = 0
+	}
+	if next >= len(m.Coffees) {
+		next = len(m.Coffees) - 1
+	}
 	m.shop.selected = next
+
+	if m.shop.viewportsReady {
+		targetY := (m.shop.selected + 2) * 1
+		m.shop.menuViewport.SetYOffset(targetY - m.shop.menuViewport.Height()/2)
+		m.shop.detailViewport.GotoTop()
+	}
 	return m
 }

pkg/tui/styles.go

@@ -8,13 +8,13 @@ import (
 
 func (m Model) createBoxInner(content string, selected bool, position lipgloss.Position, paddingH int, paddingV int, totalWidth int) string {
 	padded := lipgloss.PlaceHorizontal(totalWidth, position, content)
-	base := m.theme.Base().Border(lipgloss.RoundedBorder()).Width(totalWidth)
+	base := m.theme.Base().Border(lipgloss.NormalBorder()).Width(totalWidth)
 
 	var style lipgloss.Style
 	if selected {
-		style = base.BorderForeground(cWhite)
+		style = base.BorderForeground(m.theme.Highlight())
 	} else {
-		style = base.BorderForeground(cLine)
+		style = base.BorderForeground(m.theme.Border())
 	}
 	return style.Padding(paddingV, paddingH).Render(padded)
 }

pkg/tui/theme/doc.go

@@ -1,3 +0,0 @@
-// Package theme keeps the colors and styles in one spot so the whole UI
-// looks like it was built by the same person.
-package theme

pkg/tui/update.go

@@ -16,6 +16,8 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		if tick.seq == m.resizeSeq {
 			m = m.updateLayout(m.pendingWidth, m.pendingHeight)
 			switch m.currentPage {
+			case shopPage:
+				m = m.updateShopViewports()
 			case cartPage:
 				m = m.updateCartViewport()
 			case shippingPage:
@@ -98,10 +100,9 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		}
 		if msg.Data.User.ID != 0 {
 			u := models.User{
-				ID:             msg.Data.User.ID,
-				Name:           msg.Data.User.Email,
-				Email:          msg.Data.User.Email,
-				SelfLimitCents: msg.Data.User.SelfLimitCents,
+				ID:    msg.Data.User.ID,
+				Name:  msg.Data.User.Email,
+				Email: msg.Data.User.Email,
 			}
 			m.User = &u
 			m.Username = u.Name
@@ -177,11 +178,6 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		if m.shipping.form != nil || m.payment.form != nil {
 			break
 		}
-		// spend-limit input owns keys while focused - skip global nav so a
-		// keystroke edits the field instead of switching pages (s/c/a/q/etc...)
-		if m.account.spendLimitFocused {
-			break
-		}
 		// Refund overlay owns input when open; dispatched below before page handlers.
 		if m.refund.open {
 			break

pkg/tui/views.go

@@ -62,8 +62,7 @@ func (m Model) renderString() string {
 	if breadcrumbs != "" {
 		breadcrumbsHeight = lipgloss.Height(breadcrumbs)
 	}
-	footer := m.BuildFooter()
-	footerHeight := lipgloss.Height(footer)
+	footerHeight := 1
 	marginTop := 1
 	marginBottom := 1
 	bufferSpace := 1
@@ -88,15 +87,17 @@ func (m Model) renderString() string {
 			errorStyle = errorStyle.Width(m.widthContent - 4)
 		}
 		errorBanner := errorStyle.Render(m.error.message)
-		content = errorBanner + "\n" + m.buildPageContent()
+		content = errorBanner + "\n" + m.buildPageContent(availableContentHeight)
 	} else if m.notice != nil {
 		noticeStyle := m.theme.TextSuccess().Border(lipgloss.NormalBorder()).BorderForeground(m.theme.Success()).Padding(0, 1).MarginBottom(1)
 		noticeBanner := noticeStyle.Render(m.notice.message)
-		content = noticeBanner + "\n" + m.buildPageContent()
+		content = noticeBanner + "\n" + m.buildPageContent(availableContentHeight)
 	} else {
-		content = m.buildPageContent()
+		content = m.buildPageContent(availableContentHeight)
 	}
 
+	footer := m.BuildFooter()
+
 	isViewportPage := m.currentPage == shopPage || m.currentPage == cartPage ||
 		m.currentPage == shippingPage || m.currentPage == paymentPage ||
 		m.currentPage == confirmPage || m.currentPage == accountPage
@@ -136,10 +137,10 @@ func (m Model) renderString() string {
 	)
 }
 
-func (m Model) buildPageContent() string {
+func (m Model) buildPageContent(height int) string {
 	switch m.currentPage {
 	case accountPage:
-		return m.BuildAccountView()
+		return m.BuildAccountView(height)
 	case shippingPage:
 		return m.ShippingPageView()
 	case paymentPage:

pkg/utils/doc.go

@@ -1,3 +0,0 @@
-// Package utils is the catch-all drawer for tiny HTTP helpers that didn't
-// earn a package of their own.
-package utils

pkg/utils/response.go

@@ -8,8 +8,8 @@ import (
 
 // SuccessResponse represents a successful API response
 type SuccessResponse struct {
-	Success bool `json:"success"`
-	Data    any  `json:"data"`
+	Success bool        `json:"success"`
+	Data    interface{} `json:"data"`
 }
 
 // ErrorResponse represents an error API response
@@ -20,13 +20,13 @@ type ErrorResponse struct {
 
 // Error contains error details
 type Error struct {
-	Code    string         `json:"code"`
-	Message string         `json:"message"`
-	Details map[string]any `json:"details,omitempty"`
+	Code    string                 `json:"code"`
+	Message string                 `json:"message"`
+	Details map[string]interface{} `json:"details,omitempty"`
 }
 
 // RespondSuccess sends a successful JSON response
-func RespondSuccess(w http.ResponseWriter, statusCode int, data any) {
+func RespondSuccess(w http.ResponseWriter, statusCode int, data interface{}) {
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(statusCode)
 
@@ -39,7 +39,7 @@ func RespondSuccess(w http.ResponseWriter, statusCode int, data any) {
 }
 
 // RespondError sends an error JSON response
-func RespondError(w http.ResponseWriter, statusCode int, code, message string, details map[string]any) {
+func RespondError(w http.ResponseWriter, statusCode int, code, message string, details map[string]interface{}) {
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(statusCode)
 

pkg/validate/doc.go

@@ -1,3 +0,0 @@
-// Package validate gives user input a once-over before the rest of the app
-// trusts it.
-package validate

scripts/backups/01-log-tail.sh

@@ -1,13 +0,0 @@
-#!/usr/bin/env bash
-# Show last 20 lines of the cron log + its mtime. Cheapest "did it run" check.
-set -euo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source "$SCRIPT_DIR/lib.sh"
-
-print_header "Backup log: mtime + last 20 lines"
-spinner_start "fetching log from $SSH_HOST..."
-ssh "$SSH_HOST" "
-  sudo stat -c 'Last modified: %y' '$BACKUP_LOG'
-  echo; sudo tail -20 '$BACKUP_LOG'
-"
-spinner_stop

scripts/backups/02-snapshots.sh

@@ -1,14 +0,0 @@
-#!/usr/bin/env bash
-# List every restic snapshot with timestamps and tags.
-set -euo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source "$SCRIPT_DIR/lib.sh"
-
-print_header "All restic snapshots"
-spinner_start "querying restic via SFTP..."
-ssh "$SSH_HOST" "
-  export RESTIC_PASSWORD_FILE='$RESTIC_PASSWORD_FILE'
-  export RESTIC_REPOSITORY='$RESTIC_REPO'
-  sudo -E restic -o sftp.args='-i $RESTIC_SSH_KEY' snapshots
-"
-spinner_stop

scripts/backups/03-check.sh

@@ -1,21 +0,0 @@
-#!/usr/bin/env bash
-# restic repo integrity check.
-#   ./03-check.sh         metadata only (~5s)
-#   ./03-check.sh --deep  + 10% data-pack re-read (~30s)
-set -euo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source "$SCRIPT_DIR/lib.sh"
-
-EXTRA=""
-if [ "${1:-}" = "--deep" ]; then
-  EXTRA="--read-data-subset=10%"
-fi
-
-print_header "restic check ${EXTRA:-(metadata only)}"
-spinner_start "running restic check on $SSH_HOST..."
-ssh "$SSH_HOST" "
-  export RESTIC_PASSWORD_FILE='$RESTIC_PASSWORD_FILE'
-  export RESTIC_REPOSITORY='$RESTIC_REPO'
-  sudo -E restic -o sftp.args='-i $RESTIC_SSH_KEY' check $EXTRA
-"
-spinner_stop

scripts/backups/04-restore-verify.sh

@@ -1,57 +0,0 @@
-#!/usr/bin/env bash
-# Restore the latest snapshot to /tmp on the remote box, then:
-#   - PRAGMA integrity_check on the restored DB
-#   - row-count diff vs the live DB
-# Cleans up /tmp dir at the end.
-set -euo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source "$SCRIPT_DIR/lib.sh"
-
-print_header "Restore latest snapshot and verify SQLite"
-spinner_start "restoring latest snapshot to /tmp on $SSH_HOST..."
-
-ssh "$SSH_HOST" \
-  "PWFILE='$RESTIC_PASSWORD_FILE' \
-   REPO='$RESTIC_REPO' \
-   KEY='$RESTIC_SSH_KEY' \
-   LIVE='$LIVE_DB' \
-   bash -s" <<'REMOTE'
-set -e
-DIR=/tmp/tshop-restore-test
-sudo rm -rf "$DIR" && sudo mkdir -p "$DIR"
-
-sudo -E RESTIC_PASSWORD_FILE="$PWFILE" RESTIC_REPOSITORY="$REPO" \
-  restic -o sftp.args="-i $KEY" restore latest --target "$DIR"
-
-DB=$(sudo find "$DIR" -name 'terminalshop.db' | head -1)
-if [ -z "$DB" ]; then
-  echo 'restored DB not found' >&2
-  exit 1
-fi
-
-echo
-echo '--- restored file ---'
-sudo stat -c '%y  %s bytes  %n' "$DB"
-
-echo
-echo '--- PRAGMA integrity_check ---'
-sudo sqlite3 "$DB" 'PRAGMA integrity_check;'
-
-echo
-echo '--- PRAGMA quick_check ---'
-sudo sqlite3 "$DB" 'PRAGMA quick_check;'
-
-echo
-echo '--- restored vs live row counts ---'
-printf '%-22s %10s %10s\n' table restored live
-for t in $(sudo sqlite3 "$DB" 'SELECT name FROM sqlite_master WHERE type="table";'); do
-  r=$(sudo sqlite3 "$DB" "SELECT COUNT(*) FROM \"$t\";")
-  l=$(sudo sqlite3 "$LIVE" "SELECT COUNT(*) FROM \"$t\";" 2>/dev/null || echo 'n/a')
-  printf '%-22s %10s %10s\n' "$t" "$r" "$l"
-done
-
-sudo rm -rf "$DIR"
-echo
-echo 'OK'
-REMOTE
-spinner_stop

scripts/backups/05-freshness.sh

@@ -1,41 +0,0 @@
-#!/usr/bin/env bash
-# Print latest snapshot age. Exit 0 if fresh, 1 if older than STALE_HOURS.
-set -euo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source "$SCRIPT_DIR/lib.sh"
-
-print_header "Latest snapshot freshness"
-
-spinner_start "querying latest snapshot..."
-LATEST=$(ssh "$SSH_HOST" "
-  export RESTIC_PASSWORD_FILE='$RESTIC_PASSWORD_FILE'
-  export RESTIC_REPOSITORY='$RESTIC_REPO'
-  sudo -E restic -o sftp.args='-i $RESTIC_SSH_KEY' snapshots --json
-" | jq -r 'max_by(.time) | .time')
-spinner_stop
-
-if [ -z "$LATEST" ] || [ "$LATEST" = "null" ]; then
-  echo "ERROR: could not parse latest snapshot time" >&2
-  exit 2
-fi
-
-NOW=$(date -u +%s)
-# GNU date (Linux) first, then BSD date (macOS) as fallback.
-if THEN=$(date -u -d "$LATEST" +%s 2>/dev/null); then
-  :
-else
-  CLEAN=$(echo "$LATEST" | sed 's/\.[0-9]*Z$/Z/')
-  THEN=$(date -u -j -f "%Y-%m-%dT%H:%M:%SZ" "$CLEAN" +%s)
-fi
-
-AGE_HRS=$(( (NOW - THEN) / 3600 ))
-echo "Latest snapshot: $LATEST"
-echo "Age:             ${AGE_HRS}h"
-echo "Threshold:       ${STALE_HOURS}h"
-
-if [ "$AGE_HRS" -lt "$STALE_HOURS" ]; then
-  print_ok "snapshot within freshness window"
-else
-  print_fail "STALE — investigate"
-  exit 1
-fi

scripts/backups/06-lfs-direct.sh

@@ -1,59 +0,0 @@
-#!/usr/bin/env bash
-# Independent filesystem check on lfs-remote. No restic, no password needed.
-# Proves the repo dir exists, files are present, recent uploads landed,
-# and the backup partition has room.
-set -euo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source "$SCRIPT_DIR/lib.sh"
-
-print_header "lfs-remote filesystem-level repo check"
-spinner_start "inspecting $LFS_HOST filesystem..."
-
-ssh "$LFS_HOST" "
-set -e
-REPO='$LFS_REPO_PATH'
-WARN_PCT=$LFS_DISK_WARN_PCT
-
-if [ ! -d \"\$REPO\" ]; then
-  echo 'ERROR: repo dir missing on lfs' >&2
-  exit 1
-fi
-
-echo '--- snapshot pointer count (one file per restic snapshot) ---'
-COUNT=\$(find \"\$REPO/snapshots\" -type f 2>/dev/null | wc -l)
-echo \"snapshots/: \$COUNT files\"
-
-echo
-echo '--- repo size on disk ---'
-du -sh \"\$REPO\"
-
-echo
-echo '--- recent uploads (files newer than 48h) ---'
-RECENT=\$(find \"\$REPO\" -type f -mtime -2 2>/dev/null | wc -l)
-echo \"files added in last 48h: \$RECENT\"
-if [ \"\$RECENT\" -eq 0 ]; then
-  echo 'WARN: no new files in last 48h' >&2
-fi
-
-echo
-echo '--- most recent snapshot pointer ---'
-LATEST=\$(ls -t \"\$REPO/snapshots\"/* 2>/dev/null | head -1)
-if [ -n \"\$LATEST\" ]; then
-  stat -c '%y  %n' \"\$LATEST\"
-else
-  echo 'WARN: no snapshot files found' >&2
-fi
-
-echo
-echo '--- disk usage ---'
-df -h \"\$REPO\"
-USED=\$(df --output=pcent \"\$REPO\" 2>/dev/null | tail -1 | tr -dc 0-9)
-if [ -n \"\$USED\" ] && [ \"\$USED\" -gt \"\$WARN_PCT\" ]; then
-  echo \"FAIL: backup partition \${USED}% full (threshold \${WARN_PCT}%)\" >&2
-  exit 1
-fi
-
-echo
-echo 'OK'
-"
-spinner_stop

scripts/backups/07-lfs-restic-check.sh

@@ -1,38 +0,0 @@
-#!/usr/bin/env bash
-# Independent restic check from the lfs-remote side. Reads repo via a
-# LOCAL filesystem path (not SFTP), so it proves the data is parseable
-# without any involvement from the prod box at restic level.
-#
-# Needs:
-#   - restic installed on lfs-remote (see scratchpkg port at /usr/ports/main/restic)
-#   - SSH access to both prod (to fetch the repo password) and lfs
-set -euo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-source "$SCRIPT_DIR/lib.sh"
-
-print_header "lfs-remote restic check (independent vantage point)"
-
-# Precondition: restic must be on lfs.
-if ! ssh "$LFS_HOST" 'command -v restic >/dev/null 2>&1'; then
-  echo 'ERROR: restic not in PATH on lfs-remote' >&2
-  echo "Install via scratchpkg, then re-run." >&2
-  exit 2
-fi
-
-# Pull restic password from prod (needs sudo on prod).
-spinner_start "fetching restic password from $SSH_HOST..."
-PW=$(ssh "$SSH_HOST" "sudo cat '$RESTIC_PASSWORD_FILE'")
-spinner_stop
-if [ -z "$PW" ]; then
-  echo 'ERROR: could not read restic password from prod' >&2
-  exit 2
-fi
-
-# Run restic against the LOCAL repo path on lfs. Password fed via stdin
-# so it never lands in argv or a file on lfs.
-spinner_start "running restic check from $LFS_HOST..."
-ssh "$LFS_HOST" "restic -r '$LFS_REPO_PATH' --password-file=/dev/stdin check" <<<"$PW"
-spinner_stop
-
-echo
-print_ok "lfs-side restic check passed"

scripts/backups/check-all.sh

@@ -1,138 +0,0 @@
-#!/usr/bin/env bash
-# Master runner. Executes every backup check in sequence.
-#   ./check-all.sh              stop on first failure; interactive menu when TTY
-#   ./check-all.sh --keep-going keep running after failures (no menu)
-#   ./check-all.sh --deep       use --deep on 03-check.sh
-#
-# When stdin and stdout are TTYs, a failed step opens a drill-down menu:
-#   [r]etry  [l]og  [u]nlock  [s]kip  [q]uit
-# Non-TTY (cron / piped) skips the menu and behaves like the old runner.
-set -uo pipefail
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-
-KEEP_GOING=0
-DEEP=0
-for arg in "$@"; do
-  case "$arg" in
-    --keep-going) KEEP_GOING=1 ;;
-    --deep)       DEEP=1 ;;
-    -h|--help)
-      echo "Usage: $0 [--keep-going] [--deep]"
-      echo "  --keep-going  don't stop on first failure, suppress interactive menu"
-      echo "  --deep        pass --deep to 03-check.sh (10% data re-read)"
-      exit 0
-      ;;
-    *)
-      echo "unknown flag: $arg" >&2
-      exit 2
-      ;;
-  esac
-done
-
-# Pull in config + color helpers (also gives us SSH_HOST + restic env for unlock).
-source "$SCRIPT_DIR/lib.sh"
-
-declare -a STEP_NAMES=()
-declare -a STEP_STATUS=()   # OK | FAIL
-FAIL=0
-
-prompt_after_fail() {
-  # returns 0=skip, 1=quit, 2=retry
-  local script="$1"
-  while :; do
-    printf '\n%sNext?%s [r]etry  [l]og  [u]nlock  [s]kip  [q]uit > ' "$C_BOLD" "$C_RESET"
-    local choice
-    read -r choice
-    case "$choice" in
-      r|R) return 2 ;;
-      l|L) "$SCRIPT_DIR/01-log-tail.sh"; echo ;;
-      u|U)
-        echo
-        ssh "$SSH_HOST" "
-          export RESTIC_PASSWORD_FILE='$RESTIC_PASSWORD_FILE'
-          export RESTIC_REPOSITORY='$RESTIC_REPO'
-          sudo -E restic -o sftp.args='-i $RESTIC_SSH_KEY' unlock
-        "
-        echo
-        ;;
-      s|S) return 0 ;;
-      q|Q) return 1 ;;
-      "")  ;;
-      *)   printf 'unknown: %s\n' "$choice" ;;
-    esac
-  done
-}
-
-run_step() {
-  local script="$1"; shift
-  echo
-  printf '%s########## %s %s ##########%s\n' "$C_CYAN$C_BOLD" "$script" "$*" "$C_RESET"
-
-  local attempts=0
-  while :; do
-    attempts=$((attempts + 1))
-    if "$SCRIPT_DIR/$script" "$@"; then
-      STEP_NAMES+=("$script")
-      STEP_STATUS+=("OK")
-      return 0
-    fi
-
-    printf '%sFAILED:%s %s\n' "$C_RED$C_BOLD" "$C_RESET" "$script" >&2
-
-    if [ -t 0 ] && [ -t 1 ] && [ "$KEEP_GOING" -eq 0 ]; then
-      prompt_after_fail "$script"
-      case "$?" in
-        0) STEP_NAMES+=("$script"); STEP_STATUS+=("FAIL"); FAIL=$((FAIL + 1)); return 0 ;;
-        1) STEP_NAMES+=("$script"); STEP_STATUS+=("FAIL"); FAIL=$((FAIL + 1)); print_summary; exit 1 ;;
-        2) echo
-           printf '%s>>>>>> retry %s (attempt %d) <<<<<<%s\n' "$C_CYAN$C_BOLD" "$script" $((attempts + 1)) "$C_RESET"
-           continue ;;
-      esac
-    fi
-
-    # non-interactive path
-    STEP_NAMES+=("$script")
-    STEP_STATUS+=("FAIL")
-    FAIL=$((FAIL + 1))
-    if [ "$KEEP_GOING" -eq 0 ]; then
-      print_summary
-      exit 1
-    fi
-    return 0
-  done
-}
-
-print_summary() {
-  echo
-  printf '%s===============================================%s\n' "$C_CYAN$C_BOLD" "$C_RESET"
-  printf '   %-28s %s\n' "Script" "Result"
-  printf '   %-28s %s\n' "----------------------------" "--------"
-  local i
-  for i in "${!STEP_NAMES[@]}"; do
-    local name="${STEP_NAMES[$i]}"
-    local status="${STEP_STATUS[$i]}"
-    local color sym
-    case "$status" in
-      OK)   color="$C_GREEN"; sym="✓ OK"   ;;
-      FAIL) color="$C_RED"  ; sym="✗ FAIL" ;;
-    esac
-    printf '   %-28s %s%s%s\n' "$name" "$color" "$sym" "$C_RESET"
-  done
-  printf '%s===============================================%s\n' "$C_CYAN$C_BOLD" "$C_RESET"
-  if [ "$FAIL" -eq 0 ]; then
-    printf '%sAll checks passed.%s\n' "$C_GREEN$C_BOLD" "$C_RESET"
-  else
-    printf '%s%d check(s) failed.%s\n' "$C_RED$C_BOLD" "$FAIL" "$C_RESET"
-  fi
-}
-
-run_step 01-log-tail.sh
-run_step 02-snapshots.sh
-if [ "$DEEP" -eq 1 ]; then run_step 03-check.sh --deep; else run_step 03-check.sh; fi
-run_step 04-restore-verify.sh
-run_step 05-freshness.sh
-run_step 06-lfs-direct.sh
-run_step 07-lfs-restic-check.sh
-
-print_summary
-[ "$FAIL" -eq 0 ] || exit 1