chore/any-pragmatism #1

marcusDenslow · 2026-06-06T15:01:50+02:00

marcusDenslow commented

2026-06-06 15:01:50 +02:00

No description provided.

marcusDenslow added 35 commits 2026-06-06 15:01:50 +02:00

add ci (#1 ) 60f52f9851

* ci(checks): add pull request workflow and golangci-lint config

* refactor(lint): resolve golangci-lint findings

* style(tui): drop traling blank line for gofmt

* fix(cards): handle crypto/rand.Read error in storeRedirect

test(dillydallying): testing the ci workflow (#2 ) 366d80a9ee

docs(comments): cleanup comments (#3 ) 85b0c53c0a

docs(comments): add some comments (#4 ) 50e1ba32f3

docs(comments): add some comments (#5 ) c429c1966e

this is the subject of the commit

docs(comments): add some comments (#6 ) c78021f520

feat(tui): render customer-facing event timeline in order detail veiew (#7 ) 48d65c48fa

Pulls events off the new order_events table and shows them as a timeline
  block in the order detail view: Paid, Label created, In transit,
  Delivered (etc) with timestamps. Filters out ops-only events like
  payment_critical, label_orphaned, and tracking_marked_manually so the
  customer never sees internal plumbing.

  DisplayLabel on OrderEvent decides what's customer-visible and what's
  redacted, so the same order_events rows can later power an admin view
  with no filter.

feat(notify): daily slack reminder for paid orders awaiting labels (#8 ) b404303f84

so the ain was that older paid orders were getting buried in the #orders
channel in slack and i would just forget about them. Pin/unpin from
earlier helped, but if i missed pinning one or the channel got noisy, it
was still easy to lose track.

this adds a 24h cron that queries any paid order older than 24h with no
label yet and dumps them all into one #orders message. Each line shows
the order id, how old it is, total, where it is going, and a permalink
back to the orders slack thread so i can hop in and hit Buy Label

Ports the idea from terminal.shops cron/unshipped.ts but out stuch state
is different( we auto-promote paid->shipped on label-buy so
PRE_TRANSIT-stuck can not happen), so the query is "paid + no tracking
number + >24h" instead.

NO orders get a "Bring blocked" tag since i dont have the norwegian org
set up yet and can not actually ship those today. Also fires once 40s
after startup so a deploy does not black out the reminder for a full
day.

refactor(tui): port to charm v2 (#9 ) dee6172875

* refactor(tui): port to charm v2

bumped bubbletea, lipgloss, bubbles, wish, and huh to v2. Mostly
mechanical chur, new import paths, vewport getter/setter api, view()
returns tea.view now, huh.theme became an interface so the theme package
needed a small reshape. Render plumbing is gone (no more lipgloss.Render
field on the Model or MakeRenderer in main.go). All pages still work
over ssh. setting up for the refund composer next

* style(tui): gofmt main.go and menu.go

feat(refund): add refund request flow (#10 ) bce94b6d10

* feat(refund): add refund request flow

- tui modal composer with reason select + free-form message
  (pkg/tui/refund.go)
- POST /api/v1/orders/{id}/refund-request posts to orders slack thread
- 15 min server side cooldown via Order.LastRefundRequestAt (429 +
  retry-after)
- shared refundrequestreasons + can requestrefund hoisted to pkg/models
- slack message includes customer name, email, order total, quoted body
- tests over invalid-state, missing-message, and cooldown paths

* style(tui): run gofmt to fix formatting

fix(tui): way to much to write (#11 ) a21485f91d

style(tui): update refund page ui (#12 ) d9404ab31e

feat(cart): pass off_session=true on PaymentIntent for SCA exemption eligibility (#13 ) 0fe013c399

feat(sca): add order status endpoint adn SCA error code mapping (#14 ) 95b9fa91b1

* feat(sca): add order status endpoint adn SCA error code mapping

adds server-side infra for the upcoming SCA / 3DS challenge flow im
working on. No behavior change to existing checkout paths.

* fix(sca): suppress unused lint on SCA scaffolding helpers

feat(sca): map stripe error codes to user-facing copy in tui (#15 ) a8e45bc82b

feat(sca): return 202 + 3ds redirect token when checkout requires auth (#16 ) bba5a0dfa0

fix: allow redirect next_action so 3ds challenge url surfaces (#17 ) c2b2b6e834

fix(sca): re-fetch payment intent when error response omits next_action (#18 ) 8b2889a524

fix(sca): re-confirm payment intent on-session to surface 3ds next_action (#19 ) e6301e662f

fix(sca): pass payment method on reconfirm so 3ds next_action surfaces (#20 ) 1c5765d25b

feat(sca): handle 3ds checkout end to end with qr poll and race fix (#21 ) 7c8a2b562f

* feat(sca): handle 3ds checkout end to end with qr poll and race fix

* fix(sca): drop unused pollOrderStatusCmd helper

feat(sca): persist redirect tokens to sqlite with 10min ttl (#22 ) 3a3c7ee80b

chore(ci): skip golangci-lint under act to avoid node path issue (#23 ) c8b7545ca6

chore(ci): bump checkout and setup-go to node24-ready majors (#24 ) 03009ea6df

fix(ci): pin deploy go-version to go.mod to match ci.yml (#25 ) c3e6eb2b84

feat(sca): cap per-order total ro prevent oversize charges (#26 ) 2f65cf0d90

chore(ops): add nightly backup verification scripts (#27 ) 1096c85b10

fix(sca): return over-limit checkout errors to cart (#28 ) 728ac24c96

feat(sca): expire inactive saved cards (#29 ) 67e19eca98

* feat(sca): expire inactive saved cards

* fix(sca): address card ttl review feedback

- Correct sql typos breaking GET /cards and /view/init (used_id, id_default)
- Stop swallowing backfillCardStorageExpiration error in Migrate
- Wrap expireStoredCard local writes in a transaction and run stripe
  detach + audit only after commit, preventing double-fire on retry
- Drop redundant ttl refresh in ConvertCart; webhook is authoritative
- Rename validation_expired_at metric label to validation_card_expired
- Fix CardStorageExpiresAt doc comment and test failure message typos
- Add handler-level tests for expireStoredCards (user scoping + cart deref)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(sca): move card expiration to periodic reconciler

Read paths (GetCards, GetViewInit) now filter expired cards from
query results instead of detaching them inline, so request handlers
no longer block on Stripe API calls. Physical deletion runs in a
new ReconcileExpiredCards goroutine on an hourly ticker, mirroring
the existing ReconcileOrders / ReconcileUnshipped jobs. Per-card
action sites (SetCard, SetDefaultCard, ConvertCart) still expire
synchronously since they operate on one row the user is acting on.

ViewHandler's stripeKey dependency is dropped now that GetViewInit
no longer touches Stripe.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(sca): address card ttl review feedback

- guard zero order.CardID before refreshing card storage ttl in
  payment_intent.succeeded webhook to avoid noisy warn logs on payment
  paths that did not use a saved card
- delete unused Card.RefreshStorageTTL model method; the SQL-only
  refreshCardStorageTTL helper is the single canonical path
- clarify duplicate-card webhook path: storage_expires_at reset is a
  card-add refresh, not a payment-success refresh, so last_used_at
  intentionally stays untouched

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(sca): cover card ttl read paths and expired-card sync sites

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

chore(test): add gotestsum + tparse runner with ci wiring (#30 ) f3b94c3271

* chore(test): add gotestsum + tparse runner with ci wiring

* chore(tests): change the tests around a little

feat(sca): add retry-auth endpoint for failed 3ds challenges (#31 ) 3420c8dce0

* feat(sca): add retry-auth endpoint for failed 3ds challenges

* fix(sca): retry-auth unexpected-state branch out of card-decline

just fixes up in some of the things the review of the last commit
noticed

fix(tui): fix the menu always selecting the first entry in the refund page (#32 ) 732353d9a4

feat(sca): wire retry-auth keybind on authfailed review screen (#33 ) 64deba7e03

fix(products): update pricing on products (#34 ) 135f1361e4

* fix(products): update pricing on products

* fix(test): pin coffee price in cart-limit fixture

TestConvertCartLimit's quantities and expected totals were keyed to
the original 500-cent latte price. After the product price bump in
1ce63fb, coffee_id=4 became 2500 cents, so under_cap/at_cap subtests
overshot the $200 cap and over_cap's expected total magnitude was
wrong by 5x. Override coffee_id=4's price to 500 in test setup so the
cap math stays stable regardless of seed changes.

chore(repo): change all instances of interface{} to any as of newer go standards

CI / check (pull_request) Has been cancelled

Details

f9c9b7dff5

marcusDenslow merged commit b5ad61eca6 into master

2026-06-06 15:02:02 +02:00

marcusDenslow referenced this issue from a commit

2026-06-06 15:02:04 +02:00

chore/any-pragmatism (#1)

Sign in to join this conversation.